From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82E951FBC8C for ; Wed, 10 Dec 2025 01:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765330955; cv=none; b=e2NChRglJDhfupTalI9JudYINTt1PIBCtJkGmf64VMFvxel5CE8IGI6Pzp7Qra4/h5pysbu+mz1A3Z1TmX3zKxq9agsqlRoTJqG1ec2+WgtqIcphbmRZBcL5QYWLJvbgji4YQo5WEmLzGbUioSmgby6wnYOitHsijPNrB63UlFI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765330955; c=relaxed/simple; bh=T9Cq8aIyNZREDh0tPYDT2Pf4p9IsmY+P8k1Dth1dqkg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fUOmw4ZKAo4rgU0lNkrno9mngnT0gGahBepnTr0XRoeTrX8yFmDwzaSx0WM///ES73pR4e/grOnmadA+D10V7P3L9wG2zDfkbeGsj4sJgLI4E5K83Gwko33aYfVyy68eZdJXoly/iulyP1MsaL3VZ29NvX5n+AQBeAQLnzLq8Jk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jimz5vCr; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jimz5vCr" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-29812589890so86949695ad.3 for ; Tue, 09 Dec 2025 17:42:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765330953; x=1765935753; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZTOj8mtvz7bMiDNO/pkswPuq5T3Do7BAnSCOIfTK70g=; b=Jimz5vCr3Ds4Iuo/T2OfJV5WAiZqgvGMF42OdIPBlyGQWdVE0TVNv9f53jO0tgCGJg N628glt4P5Muh+8cFpblRGTHszKRQQovrI+hySRg06O55G0Y/qeZWD7WS+yUJBXFsioX tz7hQohPniSH/KtQb8hnZTKgaOcoTOKFx96I2WORgyh596HHa9Ow9IvaLZYSJr/dKkma KPTUFrqwgOhDSxtOxqbIWwr0Ww0lvIKd0GKvMTv70/W3Ew7wi9mDbeltasgYNvofbqKz M93j4Dv7imkbPxrQ5GuN3p1uipr2ImghBTy3m0FeKgS7D/IiMX5j+JpzkL9q22seVEei DWWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765330953; x=1765935753; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZTOj8mtvz7bMiDNO/pkswPuq5T3Do7BAnSCOIfTK70g=; b=wCd8ntrZbuuPvBGjIcUvY+Nq876NHyoTe519XuQ1ClYF8NgEaEQTQIrqAs6IsCK15e I2Hl0IZVsjJtK3Qoa+yFrMUwo+L1fjdU8zAmOXgaOB7CL0TwoUEojTToW3MiBRro44TJ IPteaL4dYZmiJWYjmuPWkDGk0depXS2Ko4cGwb/oJ+6aqG/MClwn+/RZ6vuDofwY7jnq mL0r8DMH8sCI8rUINe39756RWtF7RwLskpj5556CzCErTY+uXN2QJWW96fR4FhfLpqTv +37dt5wQgs8sQi7so6YAlW9ew9mqfXzufuDSZIQ99I48GBvV1ZUhjncGeu8tNdBinVdd m+QQ== X-Forwarded-Encrypted: i=1; AJvYcCWqMJc1ljTYB45uoGVCkPRTPbjm8f0I3HZBj7z24UVOHoyQW9q/gQ6f58dRBSoebjXl/Eaa4/TPEokw8Us=@vger.kernel.org X-Gm-Message-State: AOJu0YzbfcOVxvVKl7OElI8BTak8sY0nWIizmaUH8pHwNrDeTPB2mo3C 9PDiqo4UAHAdv7gZf+FFlAnOeym7KB+2S1S+b2ZYhCwi+VrAKXGMJ5JEK737CQ== X-Gm-Gg: ASbGncv8aw/dnJx5ITdIclZG6idl8UB5V6wATzyM+kF6oCP13+veY3AaaXKFSnD6BUE BAS4JfNBQdLJ1BY1micyE5IjI4aRd1XzFSjZHzuWZ7fK9ep5/tDGaTi0HSrA8aeWMCZ8v81O5fr U4Hoem6Ol25vLu7YE66vh53GqBPqp7xE25TBzupMNUSJb2WdWvpK9cqEpVYAKM1nQr61+82Xols doBgUSt7T2PQQg38YQ9dvWqYXDwlX+ZJYqZoaJO6vw5O6dSy/PDZic7+c8Xix+a8Su1D2vCLXut prhZgiHGV/0dPwFD6GBB6+WYcph8xo/ODbjpq2KzZV5HH8wDZY4VKn+PaTV84jJBBIB6wAW+afM Owvyn4jtRp9WkRQ5mN9HD++bcaH4sXkfbO5c7R35wiOYnM3tldpfoqRaJIuJQQHDkMuWQtEWjgi fDH0KnS3UuM46FJa28jAjJxMmdDWw4r6c= X-Google-Smtp-Source: AGHT+IEdUNw2zNQhZ/I2Qr+XBs/n7tKIMF5djW7gIs2sFqNkyOiwmZ90hxdyuKZt0RmU/52skct44A== X-Received: by 2002:a05:7022:fc07:b0:11d:f441:6c9b with SMTP id a92af1059eb24-11f2966ff55mr540711c88.22.1765330952646; Tue, 09 Dec 2025 17:42:32 -0800 (PST) Received: from deb-101020-bm01.dtc.local ([149.97.161.244]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11df76e2eefsm80274777c88.6.2025.12.09.17.42.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 17:42:32 -0800 (PST) From: sw.prabhu6@gmail.com To: James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org Cc: bvanassche@acm.org, linux-kernel@vger.kernel.org, mcgrof@kernel.org, kernel@pankajraghav.com, dlemoal@kernel.org, Swarna Prabhu Subject: [v1 0/2] enable sector size > PAGE_SIZE for scsi Date: Wed, 10 Dec 2025 01:41:34 +0000 Message-ID: <20251210014136.2549405-1-sw.prabhu6@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Swarna Prabhu Hi All, This is non RFC v1 series sent based on the feedback received on RFC v2 [1] and RFC v1 [2]. This patchset enables sector sizes > PAGE_SIZE for sd driver and scsi_debug driver since block layer can support block size > PAGE_SIZE. There was one issue with write_same16 and write_same10 command, which is fixed as a part of the series. Motivation: - While enabling LBS on ZoneFS, zonefs-tools tests were being skipped for conventional zones when tested on nvme block device emulated using QEMU. Hence there was a need to enable scsi with higher sector sizes to run zonefs tests for conventional zones as well. Changes since RFC v2: - Replaced open coded check for enabling sdebug_sector_size > PAGE_SIZE with blk_validate_block_size() in scsi_debug. - Replaced open coded check for enabling sector_size > PAGE_SIZE with blk_validate_block_size() in sd driver. - Replaced 'struct request *rq' argument in 'sd_set_special_bvec()' to 'struct scsi_cmnd *cmnd' and used that to get SCSI device pointer 'struct scsi_device *sdp'. - Slightly modified the commit title for scsi sd driver fix patch. - Added "Cc: stable@vger.kernel.org" tag to scsi sd driver fix patch. Changes since RFC v1: - Re organized the patch series into one patch for scsi_debug driver and one patch for sd driver. - Updated commit title and description to accommodate the above re organization on commit titled - scsi: sd: fix write_same(16/10) to enable sector size > PAGE_SIZE. - Updated commit title and description to reflect the re organization on commit titled - scsi: scsi_debug: enable sdebug_sector_size > PAGE_SIZE. Thanks to Bart for feedback on the RFC v1 and v2 series. Testing: -Test suite: xfs and generic from fstest + QEMU emulated block device(scsi and nvme) - fstest Config for patched xfs 16k block size [xfs_reflink_16k_scsi] TEST_DEV=/dev/sda SCRATCH_DEV_POOL="/dev/sdb" MKFS_OPTIONS='-f -m reflink=1,rmapbt=1, -i sparse=1, -b size=16384, -s size=16384' - Generic test results Baseline: 6.18.0-rc7 kernel + nvme 16k logical block size Patched: 6.18 kernel + scsi 16k logical block size 5 failures seen on generic tests and the same seen on baseline No regressions introduced by the patch. - XFS tests results Baseline: 6.18.0-rc7 kernel + nvme16k logical block size Patched: 6.18 kernel + sci 16k logical block size 30 failures seen on patched and baseline No regressions introduced by the patch - Blktests results scis and block layer tests with 16k and 32k logical block size. config used: TEST_DEVS=(/dev/sda) EXCLUDE=(block/010 block/011) # these didn't run on baseline(nvme 16k) All tests passed. Link to RFC v2: https://lore.kernel.org/all/20251203230546.1275683-2-sw.prabhu6@gmail.com/ [1] Link to RFC v1: https://lore.kernel.org/all/20251202021522.188419-1-sw.prabhu6@gmail.com/ [2] Swarna Prabhu (2): scsi: sd: fix write_same(16/10) to enable sector size > PAGE_SIZE scsi: scsi_debug: enable sdebug_sector_size > PAGE_SIZE drivers/scsi/scsi_debug.c | 8 +------- drivers/scsi/sd.c | 27 +++++++++++++++++---------- 2 files changed, 18 insertions(+), 17 deletions(-) -- 2.51.0