From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2268121ABAA for ; Wed, 10 Dec 2025 01:51:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765331470; cv=none; b=oElwj2XxlpvnVwH/XtKoTM57QFgptyuEELOS5jLGEZMIruilvak9mxeLUOp7SZTau/A+F1PoWVnbZ60Da8DOylEcpDy0QYox6tL8WD+md628sG9obNVLzwzrVdjQmkSsC79R/56Cta8SDeMxwUCl9ew594v0T048fhXlFJAN0R4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765331470; c=relaxed/simple; bh=6uOO2c6HJrwvoCnbPOaIYnYESzn2oI4AxxCCGofjFAA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=B0FpvssKLtWvoD2IvO7QWQV3Kif7wca/dne+uCb4FUdfqskF/VuLnv0L2/r+ulwbeLrmC4Q4OkdiXGOTAQ7jEv+EDJbqaK7/+fY0MgUM/iq/15jqE0T1qUmwZ6MIzblWiUiY9G6ogahUbHz1jhSbvqs5SNihYdf7Mgql4hAbp/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Tcwjdvb8; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Tcwjdvb8" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-477985aea2bso7019655e9.3 for ; Tue, 09 Dec 2025 17:51:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1765331465; x=1765936265; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=p9JWvH5K0pV03Rn5hCmHs5OiyWYm6zlJzjBCuutciN0=; b=Tcwjdvb8w3mQP69tjIEpY3BC8jxABRM0f/xPETG7oUNANknCDpj2zzDYq4963R2KHO h8iVQWK26odAQfoB9aosqwBLwPTDDqJDQXjWyZ5GX2Yj53jH4lFt9NFF4PRykWn7t/ik 0RW9OsyIeX1HWoo95+sf56gjJr7ZXAkuHQC4mRKwFyd7q84L9PESO18RpgTt6auhS1Yg Meqkbg7Mv4dcLO+jO4K4yS2IoQeM94oQ4RSbTBjMqnuc9mEyJlk95ogzOtYgDVO7Oe7G MB2FZBXDmIt/qihbSpDXVBo03oKbDDjYV3kSIze48UhEetvShFB6zxFtM/R5sH2JDxtD 7sGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765331465; x=1765936265; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p9JWvH5K0pV03Rn5hCmHs5OiyWYm6zlJzjBCuutciN0=; b=fk7q/xR2TyazWC05rwNSQ7IeYPMtYvtGu02HgfKLoj3PwB5OhBa60mLNrG4O8b+WeY we4OGkJU38ppzTwBo7tSXI8xiSqxaq9892eRPSosxNNOe28Z2+rAiFvp5Z4409Pys+u5 6iR728TRbUu3IwVd3sgKCfsiYIwkS+BW8qXUAVDT80oA3+5COJjhhn4Z6PVQ+/PZYNvy NU5uK0oGePmhdPTWvOf0uyVM1+BIUlc6+ayHJF+qZljaTwwyLyNKnXqmsDTNXhwd3+3K 9NetESm6tw21/qpl/WPMKAr8yJKEorRISG/ewrYd1O3Ssj+JS3K1YJdXlsRRqtHmcR/B uyBw== X-Forwarded-Encrypted: i=1; AJvYcCUh+8bZYjUVfxW2NcaVFQXYLyZqbG87prMtXrl/BYDYz6i/kv31yd32jnJIW1W3olLMyXNUPxDGRsrCgs8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+x37GvCI3hGJkfLqtyjoy9yB7GJwE8HXlN6Gq56AQfuYR7YSm zFdnWYcVy+xbizGkyXfmil/GxalPs5lblQAcXk6FHQ1gSt9LC+UkLLxTyOQVztluSmsDg5/Edax f9tz3 X-Gm-Gg: ASbGncsrugEJLYWvUuChoCJN52FS2yLDeasOhaVQbo2fx6GdsXAVx3/D1oI7qKCnOqx LTm1hgnjjXhlWUO9CryOgnvy3BEMARHtW4AGD3p05AoBApqI7jsMHe1spIBb2LHCqlexx4aCSYo qf3fnH6HbAqrNdQW0LutT5OHiaCJG2Td+8M0Py7fXhbxmbI8KUUR6N4xbOR29DIkAuLP8/j0lRd 1CuaP4UUIknkAanVQSNQVWYHSXwCdXeAxBVa0ax2dt8QjawU57UrSmns/NBGZxNkgk8E8ketd9p k80EleZsGQ6rZmjbS6LCunObQAO0jiG/IBmMXyKjNhXpYBUxHRSLYvPfXCb9VNBPZei53KOKxuG L51gl1hZiKMVLvoUuhXRZUknvj0E8s/RZmyf7quPU/GiRktAqPOmmKv4zep6Fjgh+3JtDUKhcgI cVcFho2jp6RKFHVB9YkLBrJnw6akO736ef7BI= X-Google-Smtp-Source: AGHT+IHR2utxLGAAdWRVngXH7j/+O9Uc46BiluisKeqZOUmbtdE0a6ESz7D+8AtSNGsK8pf+cSlN+g== X-Received: by 2002:a05:600c:310c:b0:477:9c9e:ec7e with SMTP id 5b1f17b1804b1-47a8380c6a8mr4334015e9.6.1765331465446; Tue, 09 Dec 2025 17:51:05 -0800 (PST) Received: from localhost.localdomain ([202.127.77.110]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bf748c6bcacsm15706689a12.0.2025.12.09.17.51.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 17:51:04 -0800 (PST) From: Heming Zhao To: joseph.qi@linux.alibaba.com, mark@fasheh.com, jlbec@evilplan.org Cc: Heming Zhao , ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 0/1] ocfs2: fix reflink preserve cleanup issue Date: Wed, 10 Dec 2025 09:50:47 +0800 Message-ID: <20251210015058.8327-1-heming.zhao@suse.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Linus and Andrew are busy, so I don't include them in the patch review phase. This patch continues Linus's job to fix the remaining issue in the reflink preserve path. The patch passed the following tests. from xfstests: ``` ./check -g quick -T -b -s ocfs2 -e generic/032 -e generic/076 \ -e generic/081 -e generic/266 -e generic/272 -e generic/281 \ -e generic/331 -e generic/338 -e generic/347 -e generic/361 \ -e generic/479 -e generic/480 -e generic/628 -e generic/629 \ -e generic/648 -e generic/650 ``` from ocfs2-test: ``` single_run-WIP.sh -f 1 -k /usr/local/ocfs2-test/tmp/linux-2.6.39.tar.gz -l /usr/local/ocfs2-test/log -m /mnt/ocfs2 -d /dev/vde -b 4096 -c 32768 -s pcmk -n hacluster -t reflink xattr-single-run.sh -o /home/ocfs2test/results/ -d /dev/vdb -b 1K -s pcmk -n hacluster -C 4K /mnt/ocfs2 ``` special test: (reflink command is from ocfs2-tools) ``` ## this case will leave one entry after cleanup job ## create file cp /usr/bin/basename /mnt/ocfs2/a0 ## set OCFS2_XATTR_INDEX_POSIX_ACL_ACCESS setfacl -m u:ocfs2test:rwx /mnt/ocfs2/a0 ## check, will output: "user:ocfs2test:rwx" getfacl /mnt/ocfs2/a0 ## set OCFS2_XATTR_INDEX_USER, don't trigger cleanup setfattr -n user.comment -v "tst-xattr" /mnt/ocfs2/a0 ## check, will output: "tst-xattr" getfattr -n user.comment /mnt/ocfs2/a0 ## set OCFS2_XATTR_INDEX_SECURITY setfattr -n security.selinux -v "unconfined_u:object_r:user_home_t:s0" /mnt/ocfs2/a0 ## reflink non-preserve reflink /mnt/ocfs2/a0 /mnt/ocfs2/ra0 ## reflink preserve reflink -p /mnt/ocfs2/a0 /mnt/ocfs2/ra0-p ## check getfacl /mnt/ocfs2/ra0 # "user:ocfs2test:rwx" non-exist getfacl /mnt/ocfs2/ra0-p getfattr -n user.comment /mnt/ocfs2/ra0 # "tst-xattr" exist getfattr -n user.comment /mnt/ocfs2/ra0-p getfattr -n security.selinux /mnt/ocfs2/ra0 # no security attr item getfattr -n security.selinux /mnt/ocfs2/ra0-p ## this case will trigger cleaning up all array entries. ## create file. then set file with OCFS2_XATTR_INDEX_POSIX_ACL_ACCESS and ## OCFS2_XATTR_INDEX_SECURITY cp /usr/bin/basename /mnt/ocfs2/b0 setfacl -m u:ocfs2test:rwx /mnt/ocfs2/b0 setfattr -n security.selinux -v "unconfined_u:object_r:user_home_t:s0" /mnt/ocfs2/b0 ## reflink non-preserve reflink /mnt/ocfs2/b0 /mnt/ocfs2/rb0 ## reflink preserve reflink -p /mnt/ocfs2/b0 /mnt/ocfs2/rb0-p ## check getfacl /mnt/ocfs2/rb0 # "user:ocfs2test:rwx" non-exist getfacl /mnt/ocfs2/rb0-p getfattr -n security.selinux /mnt/ocfs2/rb0 # no security attr item getfattr -n security.selinux /mnt/ocfs2/rb0-p ``` Heming Zhao (1): ocfs2: fix reflink preserve cleanup issue fs/ocfs2/xattr.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.43.0