From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 094B12FC879 for ; Wed, 10 Dec 2025 11:25:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765365956; cv=none; b=nuIjPiGQPAlfEEammexJnVyhYA7rrd2xIYKDLCH0fxknKRskbrpuhpTQmOKa76VWTkkB9Rpz2XkzmpfIgaln8xLYQp3uN79EdNsLgPBwDD+sSRcbjiOSoNp8YQmO9i6YIpmsbmz8su3JI5ZEgqVA7hvhyveYCdVK6BhqonHWwUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765365956; c=relaxed/simple; bh=NxaejPVy5zX3CAISSbHdAuh5rBKgsRi2//Wnojr6Zxs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nQulQakRmOUUJ7j9CaKeUGjOLPKrsTkFdc/1iN6mYerTuyr6R1qs47yGiKVKdCiMnUoo6UdYguH10p7fiRC3F/segCbzS09kQRKQqjs/JIn7/xQgn661cSDVgWgzyZ9UYFXgGiSPWhwA3IvH4fd9xClRuhpd2VDnESKv3UJ0oTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=markoturk.info; spf=pass smtp.mailfrom=markoturk.info; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=markoturk.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=markoturk.info Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b75c7cb722aso1091353566b.1 for ; Wed, 10 Dec 2025 03:25:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765365953; x=1765970753; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KhKA/M8ILyto7eBkY1icHzY0SmIbHoLL7uqqcVLehkQ=; b=wu+HJVgQ5TnEGWxIYAraahN5oyvs4UqNJT7KXDTPT9VZvvcDGko4qHIjNGsxlNpYea s2BGMdGh+8aDSoKMC/81G9dLyrC5S6Z/6hg3Cqn+Jk/eOZPfCrh5tWVRMbNzhXQJyrCq AZWQpCc+Oa0pcgXy/qdBkR/kRHTF+fDa7eSUbdAdhURQ0sSxxBEYzXOlI43bCIRGuh78 fhp1436ICft1dfu9PYErbL8+T6TOO/QNM96jg8tYRrFzCdQK3/WhS10hNpwKH0LO8oOu a8yxKda3Di7ViTsUsU66PYYdmmFG3jnmWlNyzntFDIfqwrMsELo2OFRuwCFAH57GOiQ4 Fbmw== X-Forwarded-Encrypted: i=1; AJvYcCXyZRzBZXtQBG1gJViwbf3K/JTC1LMUsrqF8ROvQpVjr38eU6CV4sfvAeWwCYBa5Zhzf0Ufu8WZFPj1FeE=@vger.kernel.org X-Gm-Message-State: AOJu0YxZyZd49DLLwr2ruiM/mw+3HN4fEnoGOOnB7RlJeuQtiHatxO0d TZ74UcTZbc4iida4o+WHwpIx91YQQAF5k0WkvextehFX9jaMSc6bN4kH0HWu9UYbTI8= X-Gm-Gg: ASbGncsZLQ7iZOUAnTu7l3CZg2evSoY89BHpoaWa1JZ3KzdYuf4OsYVWUBMLXerAl6t m+GmcbFp7rWrtndXLbbDKtgwyZUmzD2/VBjcfQaqUeupbykRit1gaZstFdROri2lE7OKdgLZoDU IARGZdkbMCKA3NlsW/p4dznmdWUkUTOC4snQK3fvbf0Zrqxq/Ap62mU3W7+eYUbDQbwstXQg5rE s1QVQW+BRpTxeHkKaYg7LuIdl+NMTmgNs5OF1Ln0jxBWhs/iO9cM2dl13Q8X7lIee/we1UO6tvY OwxIKDiXDU9Dno/99yt8lfEGGd5MSM/EoIuM1YPnkfmhIb35LyC5HKg3VSVY/GOojjuOlYYWuhD aUI6EMzNyVjnqZGEShXvvzyQFzwGHQRDfmRJY2EfIFgVZ3sgNOY9BUksUHQCtoVT4lq1OzR17zL ZJWzI6ipAWOvm5GRj0vexXzlcFRZc5S00zwy+s6yljp1G3YFDHlh0= X-Google-Smtp-Source: AGHT+IENi1ktbPcvqm8o67r+a0ZkfTe1GJgMQHe0nCoe1GbJgKTbUpT8P6okldqfK7WtN9cYy2O6sQ== X-Received: by 2002:a17:907:60cf:b0:b72:91bc:9b35 with SMTP id a640c23a62f3a-b7ce83c40b1mr202143966b.39.1765365953201; Wed, 10 Dec 2025 03:25:53 -0800 (PST) Received: from vps.markoturk.info (cpe-109-60-37-145.st4.cable.xnet.hr. [109.60.37.145]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b79f49d841bsm1657032766b.56.2025.12.10.03.25.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 03:25:52 -0800 (PST) Date: Wed, 10 Dec 2025 12:25:51 +0100 From: Marko Turk To: dakr@kernel.org, bhelgaas@google.com, kwilczynski@kernel.org, miguel.ojeda.sandonis@gmail.com, dirk.behme@de.bosch.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, mt@markoturk.info Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Marko Turk Subject: [PATCH 2/2] samples: rust: fix endianness issue in rust_driver_pci Message-ID: <20251210112503.62925-2-mt@markoturk.info> References: <20251210112503.62925-1-mt@markoturk.info> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251210112503.62925-1-mt@markoturk.info> X-Mailer: git-send-email 2.51.0 MMIO backend of PCI Bar always assumes little-endian devices and will convert to CPU endianness automatically. Remove the u32::from_le conversion which would cause a bug on big-endian machines. Signed-off-by: Marko Turk Fixes: 685376d18e9a ("samples: rust: add Rust PCI sample driver") --- samples/rust/rust_driver_pci.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/rust/rust_driver_pci.rs b/samples/rust/rust_driver_pci.rs index 5823787bea8e..fa677991a5c4 100644 --- a/samples/rust/rust_driver_pci.rs +++ b/samples/rust/rust_driver_pci.rs @@ -48,7 +48,7 @@ fn testdev(index: &TestIndex, bar: &Bar0) -> Result { // Select the test. bar.write8(index.0, Regs::TEST); - let offset = u32::from_le(bar.read32(Regs::OFFSET)) as usize; + let offset = bar.read32(Regs::OFFSET) as usize; let data = bar.read8(Regs::DATA); // Write `data` to `offset` to increase `count` by one. -- 2.51.0