From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10E92325708 for ; Wed, 10 Dec 2025 13:33:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765373612; cv=none; b=mGYglqRUSbYOanqPlhFFc5UXQ4O0PfHijPltCCsCXYeARZMAirVE6Ed2L7F69erjFpBzkOglUAX36Ka8oKhS2JBe4nhOvAtCG0DbQ8ywAB9JNruJvsvMXLZtY+SQFPpOxM9+BOYeHZLZOq1hbJhwmQWGW9VsqFF3wDwOpBt79xE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765373612; c=relaxed/simple; bh=HNC9E8nuYvBYOQu1COxJJPI0QwvlVzqBMATbbcrdljw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mgCFuinqrCe4JnKwFdO+444AqfX/WEY2hFXs+j1u7EskR5KjU8YQxxM7LUKCPBsPSQKL+Pl6VlROzPnP/MvnRwsMiugLtVkEKUOnAyTHzS0LPiL/yYvs9FkyX2dw5Oz+bUpAQj6r4L5nIWB+QCtc9p6wEJglk5Fr7XIc57KthaU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=hUguhi03; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="hUguhi03" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NP8Zk/8BePAeQ/mvOqWPv2GHCSjOrQo6N+jbZiWJykk=; b=hUguhi03eE968hxa1RZBZuzFrc 6gi8hrDwqjJ+skCf/QfhvfzlqV+3uXj5HFDfMHbzVPs1Xw9uGQBHLNXpSHcVF/KuowigN1a3+v4H2 thOfNGRcyfud6df+n1eOTSasjgLmFZpMQ+Z6tFBoVKamk6Q0vtb36euk56Jnk6GENVhLXEfh7d1AY GLCWIS7gzxM2tqseHGYfMIATZBM/XEmxEjJi+w9V4aeFjAJyuU/+xndLuB1TL4FhbUUpvhNeKPHVe 1QBLoRhUUkmFWfZ98wW9A6vvgih5naNGBSKol8Yi3dgPPuztK/kwM/XvQ36/7EVYfMG9g4PrSdoh/ TURtikKQ==; Received: from 2001-1c00-8d85-5700-266e-96ff-fe07-7dcc.cable.dynamic.v6.ziggo.nl ([2001:1c00:8d85:5700:266e:96ff:fe07:7dcc] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vTKJJ-0000000CtFA-3Sx1; Wed, 10 Dec 2025 13:32:54 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id DC0DE302EC2; Wed, 10 Dec 2025 14:32:52 +0100 (CET) Date: Wed, 10 Dec 2025 14:32:52 +0100 From: Peter Zijlstra To: Tim Chen Cc: Ingo Molnar , K Prateek Nayak , "Gautham R . Shenoy" , Vincent Guittot , Juri Lelli , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Madadi Vineeth Reddy , Hillf Danton , Shrikanth Hegde , Jianyong Wu , Yangyu Chen , Tingyin Duan , Vern Hao , Vern Hao , Len Brown , Aubrey Li , Zhao Liu , Chen Yu , Chen Yu , Adam Li , Aaron Lu , Tim Chen , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 12/23] sched/cache: Add migrate_llc_task migration type for cache-aware balancing Message-ID: <20251210133252.GU3707891@noisy.programming.kicks-ass.net> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Dec 03, 2025 at 03:07:31PM -0800, Tim Chen wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index db555c11b5b8..529adf342ce0 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -9547,7 +9547,8 @@ enum migration_type { > migrate_load = 0, > migrate_util, > migrate_task, > - migrate_misfit > + migrate_misfit, > + migrate_llc_task > }; > > #define LBF_ALL_PINNED 0x01 > @@ -10134,6 +10135,10 @@ static int detach_tasks(struct lb_env *env) > env->imbalance -= util; > break; > > + case migrate_llc_task: > + env->imbalance--; > + break; > + > case migrate_task: > env->imbalance--; > break; > @@ -12181,6 +12199,16 @@ static struct rq *sched_balance_find_src_rq(struct lb_env *env, > } > break; > > + case migrate_llc_task: > +#ifdef CONFIG_SCHED_CACHE > + dst_llc = llc_id(env->dst_cpu); > + if (dst_llc >= 0 && > + busiest_pref_llc < rq->nr_pref_llc[dst_llc]) { > + busiest_pref_llc = rq->nr_pref_llc[dst_llc]; > + busiest = rq; > + } > +#endif > + break; > case migrate_task: > if (busiest_nr < nr_running) { > busiest_nr = nr_running; > @@ -12363,6 +12391,8 @@ static void update_lb_imbalance_stat(struct lb_env *env, struct sched_domain *sd > case migrate_misfit: > __schedstat_add(sd->lb_imbalance_misfit[idle], env->imbalance); > break; > + case migrate_llc_task: > + break; > } > } The enum and all switch statements had the same order; you wrecked it!