From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10FE030E0D9 for ; Wed, 10 Dec 2025 16:16:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765383400; cv=none; b=KjxShByqfZcUY39QWs3gqXrPwAArY7wyBobAu9/0iHeOMQsE1i6YSJ/+ekQnpO70hDII55hDRoAI/XoooTHSaMDL+8MEse/2cBzqa02H1TtCEebgkagkOPjKZdQtL0XPHLeHIHOeJzqd3d+tsJO595H69f2sJliJITHfV1qnuiU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765383400; c=relaxed/simple; bh=KY7UcVKJx2M5vV0fy/PMjqMS2fQo1kzZvxVGFq1E7iU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hsYS9jRnjomtPmk74LzimwprABKSWPucpRfkM7H3xLZaE/8SkyxaTA1W3A30UJ7u3n4w4Nvtyu4h9++gN2Nf3yrfo+DH6SMv3SA6vrAxA8vwVTI1WKp16PAXvwCc3RTc60m5bzxW6zQ9n7tL88kwellFVPvYWziwUKDc/BVa2rA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dkkHka/p; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dkkHka/p" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-47797676c62so8997355e9.1 for ; Wed, 10 Dec 2025 08:16:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765383397; x=1765988197; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J7gaiGsdHBlurzADrHTXibNWYhZRYOpdVz83hckt/C8=; b=dkkHka/pe/1yLTARMD55cmjZF7iDyvnKa0tfWrL4JwwW6eGKk3fXVvDGOziPSNuPxk 33x2iiTE1S2CnYQAU43Lb4CI55uTIskpGNF31JJnEAYcfdqhxIuGAlIJxw+tQ2+aVV9I YgodhWs0E7FHERtC6PMJyPJhb/QspxdN/6LUJBL0fNJJwignQt16vBPH1Jmid423Rc71 sg0ebORgQIBrtlw4fM8PX5mbUUPJzetkDPwMLfkxKraM8QsQet7EXF8h2W60Kb0vZrDW XVPRs6MW3cx0nBZfzID8NCNL2MTsekNgYnl3Kl/oYAvIb+As5y4SlDBYFoc0K084YMm/ wdEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765383397; x=1765988197; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J7gaiGsdHBlurzADrHTXibNWYhZRYOpdVz83hckt/C8=; b=wkMEYqNyhNIwP9DWFevv9pkbtkpnp3n2ITrxFMREpOuC9WDimArULYW20In+zgcydo eSUow+taX6p5HBalIMOU0rNaGvvmU81bFspFxjg3KOdLXiR1+YC6dDTT1SzCEtPJ+vxQ xGzKYWBmfDJVYQ+4kytZ+cjLiIONNHpz1MvYDCB6mxsSH2zpovK6wwIlJ2C8/4myICOK TuMSdMBEifA9P0tttQ7mMhibCfZqsElovlpMwqbUN1mirdJn8hmGeApoNDroLo68FGzC QfCulX6vTaf8xIKPREnuXPqxYdB2iCRtPAk7EgC7jAC9dbaoWKBFgFIcT/AnF492CXlb ulwQ== X-Forwarded-Encrypted: i=1; AJvYcCURDVowYuxlBRVLJt1axObAx7BRQkuI0DAhJERAcwyacUBRsH//lANFAZZNohcZB4B1o+gtZzXPPRYmAWI=@vger.kernel.org X-Gm-Message-State: AOJu0YxkrCqd3fSlBTQLkXMNVv+RX4jHRAAJsn9raIe2J9kY/nLovA3L b81nI9TdH9zD43coNPhjTyHEtOxGco94RCy7pcyIPCHzFjKx0vK4/7gM X-Gm-Gg: ASbGnct5Y2IB4r3/cxHrxU1zM7lOz5AM0OETx7Qeb2q5sPgUx/kWiDwkHy6CO0WK+iP bwKtKSDRk0mYqvgeJvpwie0Z0HF5b6XzI59nGo0SU8NbIi5v1K5bllXZOXdKdSLP/VceTXR+E6p NXuyfWO7Yr1UGsD9dWsDuv8ExfirN+94OU+dkNJ0ySKBV7cQT6uU8TMDlGQnVjBb4ue53ZICqS+ geUatzBWPZ5UN6ciIr8v2BTzTndpaytzPhodmrgy6QHAXzhoX38V3QN0eW1RvBAv7tDI3Vr5tRw vSHz9maXcU4bWvl2jDIv1CLfyKhwcYtmVWxcQG+UOvoNdtws4Ri8N4CiVYYik9RP7RERvkYY+e+ pqW3D292MEJM0wQWz+KFcWj5shHRLLy5exYSOVfqudIyDnUXKRzcmBkPPTHP7fQDsIMW2ufw743 ZaH4Q= X-Google-Smtp-Source: AGHT+IEn8XVJm38BXtgQpJHwPIRYh4SSmVYEP+9EFtVHZZlB7PB7qz8jRUrBe8HeGAVKj/Wk4hOcHw== X-Received: by 2002:a05:600c:1c93:b0:477:9a4d:b92d with SMTP id 5b1f17b1804b1-47a8380c622mr19222925e9.5.1765383397243; Wed, 10 Dec 2025 08:16:37 -0800 (PST) Received: from skbuf ([2a02:2f04:d106:d600:6346:5010:4ce7:245c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a882fe683sm270275e9.5.2025.12.10.08.16.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 08:16:36 -0800 (PST) Date: Wed, 10 Dec 2025 18:16:33 +0200 From: Vladimir Oltean To: Daniel Golle Cc: Hauke Mehrtens , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Rasmus Villemoes , "Benny (Ying-Tsan) Weng" , John Crispin Subject: Re: [PATCH net v4 0/4] net: dsa: lantiq: a bunch of fixes Message-ID: <20251210161633.ncj2lheqpwltb436@skbuf> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Dec 09, 2025 at 01:27:42AM +0000, Daniel Golle wrote: > This series is the continuation and result of comments received for a fix > for the SGMII restart-an bit not actually being self-clearing, which was > reported by by Rasmus Villemoes. > > A closer investigation and testing the .remove and the .shutdown paths > of the mxl-gsw1xx.c and lantiq_gswip.c drivers has revealed a couple of > existing problems, which are also addressed in this series. > > Daniel Golle (4): > net: dsa: lantiq_gswip: fix order in .remove operation > net: dsa: mxl-gsw1xx: fix order in .remove operation > net: dsa: mxl-gsw1xx: fix .shutdown driver operation > net: dsa: mxl-gsw1xx: manually clear RANEG bit > > drivers/net/dsa/lantiq/lantiq_gswip.c | 3 -- > drivers/net/dsa/lantiq/lantiq_gswip.h | 2 -- > drivers/net/dsa/lantiq/lantiq_gswip_common.c | 19 +++++----- > drivers/net/dsa/lantiq/mxl-gsw1xx.c | 38 +++++++++++++++++--- > 4 files changed, 44 insertions(+), 18 deletions(-) > > -- > 2.52.0 >From a DSA API perspective this seems fine. Reviewed-by: Vladimir Oltean