From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D80FC32E139 for ; Wed, 10 Dec 2025 21:17:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765401458; cv=none; b=twKDoCoYRSXJF7bUcvo1vTZ13SwX00qLfYpM6ggvXrX22mh+1NyZogzsimVfp14k8TC0F7RuptGjtQasNktpC971/3CC0GjAlc5KEwluItmJ0kFNKXL4HoHqF3KOs7N6IQCgoccAo6BY8v7uBU6Do4VGBQ+lcqO+U0hpivzk3qg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765401458; c=relaxed/simple; bh=TGnIFeubVY7VeY994lX8aOuQktK904Czk8dQrCal58c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=U/flBypXx+uBOhtUCI8o1d2vo+xgU+ZA9EZFtwm7eysKxmBsRckmgtwNIJC0ZI6xctM9hlr/Qp3rd1UFhjCIS94Mkam2SyIrGcg+qjAVgPnsFmpcUJLylo3gtc2OQ/kGFF4yYZYChAsBYgyuNaSFO4RS10lxwwDiL6y16yMdHKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aUSe8LzF; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aUSe8LzF" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-477632b0621so1359595e9.2 for ; Wed, 10 Dec 2025 13:17:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765401455; x=1766006255; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tOfFY77gZCltiZjkrHeQ4oE/3Skq9gP62li7AIVP3wU=; b=aUSe8LzFZAZ2QfpvEagHuotgsoG81zEDjOhDuERcADIpYjMN+o48HMbB0t9gfWDF7g idiiaF/a6Ie+xFnUBQT7skrZi4QAMHt1B+DJHEipWcxgCwdpzs4rjsy8Qv8GXdnpcMJo g/mjt32ymMp221ogQGhn0qaxS3Ws6pWqKUGHAtpq1AUxbKWohp44VhyBZdIn2a1Qhk83 8odwNaUcWlnAocHfoNqkcWWmOM1nV19bj6kZwBY1fqw/sq6EkkL5ejU4OBWB5mbaJ44B Bakz4ZNwqzr5TgGXLGx2NOD389lMxix6nHVaIW9C/CK/JhnyGrDY/XmlurjD40Lc06ea NKVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765401455; x=1766006255; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tOfFY77gZCltiZjkrHeQ4oE/3Skq9gP62li7AIVP3wU=; b=pTg/vilqS0FlXdK4tLi1gqIGvQmj2/jhrDX0enMeFVII97Ss+NIAEr96yzRXBVDgzW 2yUT/YtomRBgd/pmn5DZ/FbG9HtSK/SiwiOhleCT72NhKz7dyNhgJ6DVxj5WzNW2za0u +ngGTWXlBlk4PA0th8lo+yjVaXnqxM9quVop3ylpz+AvJukEAtdt7M3HIkIftKIb9aJj V479OrRfMPkij7a3zbZ0c0EP4oXxC81pN6euX1jKT303C4oarZq2uiccM1Fi4psi6+xF DydiJEL3FCayEpX8VgL/qb1qo7NSGkTw63wrRIf8/Ln8QXMe9EqDVWG6D9JwELs4Bno2 j4jA== X-Forwarded-Encrypted: i=1; AJvYcCXMBwj9gZz8psD1OZxQZV5WQvNGYIyPdwrmVXBA7GoSLXvRL1F/B5jIbk19itKACGdO2CZ1n6gqTVNdY/c=@vger.kernel.org X-Gm-Message-State: AOJu0YxpjF494KWFd+UNOi/QnJ4g2bZOy4cVQLPLrVXQd8z5VejZR2R8 hQu8JRdr5V8kXuoaMFk+HsJBbdX1MWyA6n4PS7qBHlYGqUCkkxws85pJ X-Gm-Gg: ASbGnctrRqNbM/st5sYR6vDr/9szrMnwxRx1oxX697ZnoM2vDyKXQign16UDTYCvWrq Lb7WXy5CMq3q2VRo6Q02GKV+UJPhNUwxFKmLlGyeZ2uGc1tWXm+8t3bwQr3pNdkcKY3CxCAg3P1 EiXpq+ozlgrSbfQ9zJFKYbv9+CpeYhKn1XRbErFKEme+d7TZchQ1Ca2KWCKwUInjhVaq1GM570I 9WOyna6BnqHHsGi1hRpWRvJCOAdvesjQstFZiuNJsBXe9BKthm5l37pDQ+QrtjP4OuHjJRtFSvW boAk+ih6G7h0BYfLxCZq1IwncctrvM9hJigTy5CI7j3fn4Cq7ChDQ8QwzSLwGpGbjBWXT5bEmEe VEF08Z3mt2VIXYa8G1sleHmG65c1ZLdVQ6Tr4cOHxh8A8BLuluh+n4YCLxdeXhPLMzmX1b3a7BL SD3o4XZeGf9XkdvmgGGfN7/JNG/e5EUZnaeLGiiAPFw34= X-Google-Smtp-Source: AGHT+IEllRKC6NDjpHfpSYxwBWFGd/XV/21Iks7SFysobBhsAwJQ/2swNyMn8d0YVqdg6M9x4r2d4A== X-Received: by 2002:a05:600c:8b16:b0:471:131f:85b7 with SMTP id 5b1f17b1804b1-47a8375ab5fmr38139825e9.15.1765401455052; Wed, 10 Dec 2025 13:17:35 -0800 (PST) Received: from dev-linux.homserver.local ([51.154.248.7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42fa8a66614sm1113198f8f.5.2025.12.10.13.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 13:17:34 -0800 (PST) From: Vaibhav Gupta To: Sven Peter , Janne Grunau , Marcel Holtmann , Luiz Augusto von Dentz , Neal Gompa Cc: Vaibhav Gupta , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 1/2] Bluetooth: hci_bcm4377: Use generic power management Date: Wed, 10 Dec 2025 21:17:25 +0000 Message-ID: <20251210211728.544677-1-vaibhavgupta40@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Switch to the generic PCI power management framework and remove legacy callbacks like .suspend() and .resume(). With the generic framework, the standard PCI related work like: - pci_save/restore_state() - pci_enable/disable_device() - pci_set_power_state() is handled by the PCI core and this driver should implement only hci_bcm4377 specific operations in its respective callback functions. Signed-off-by: Vaibhav Gupta --- drivers/bluetooth/hci_bcm4377.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm4377.c index 45e6d84224ee..925d0a635945 100644 --- a/drivers/bluetooth/hci_bcm4377.c +++ b/drivers/bluetooth/hci_bcm4377.c @@ -2416,8 +2416,9 @@ static int bcm4377_probe(struct pci_dev *pdev, const struct pci_device_id *id) hdev); } -static int bcm4377_suspend(struct pci_dev *pdev, pm_message_t state) +static int bcm4377_suspend(struct device *dev) { + struct pci_dev *pdev = to_pci_dev(dev); struct bcm4377_data *bcm4377 = pci_get_drvdata(pdev); int ret; @@ -2431,8 +2432,9 @@ static int bcm4377_suspend(struct pci_dev *pdev, pm_message_t state) return 0; } -static int bcm4377_resume(struct pci_dev *pdev) +static int bcm4377_resume(struct device *dev) { + struct pci_dev *pdev = to_pci_dev(dev); struct bcm4377_data *bcm4377 = pci_get_drvdata(pdev); iowrite32(BCM4377_BAR0_SLEEP_CONTROL_UNQUIESCE, @@ -2441,6 +2443,8 @@ static int bcm4377_resume(struct pci_dev *pdev) return hci_resume_dev(bcm4377->hdev); } +static DEFINE_SIMPLE_DEV_PM_OPS(bcm4377_ops, bcm4377_suspend, bcm4377_resume); + static const struct dmi_system_id bcm4377_dmi_board_table[] = { { .matches = { @@ -2541,8 +2545,7 @@ static struct pci_driver bcm4377_pci_driver = { .name = "hci_bcm4377", .id_table = bcm4377_devid_table, .probe = bcm4377_probe, - .suspend = bcm4377_suspend, - .resume = bcm4377_resume, + .driver.pm = &bcm4377_ops, }; module_pci_driver(bcm4377_pci_driver); -- 2.51.0