From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E69A229B38 for ; Thu, 11 Dec 2025 20:41:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765485683; cv=pass; b=j8eDdbBiGmkxm7Dyoiwa1bU+Sxozz6Zt5phxzatGlAXewUjTJmaSCqqT5JtJlqFFEGXWOy+q/tJ1f4kHCxkAgbkGljIIyJ/7HTsuSvWRghescTyVKTn5LnLrM4D7sjF8XPQIRlKubaBDyiL8ij7Nsy6rDJodaZARYa6hckgmP7o= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765485683; c=relaxed/simple; bh=+9gVQifBnLpjLkkpJ2i87AeMnJmyCmG3xVurMaSaiYM=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=jz97DOUNS+ESxXse+MesEdzVG2RdEr72ce5HNu/gBy5X08v720kd55qtfdOyYetPNXqajI7mhgSMaRlBVscqoh7IWo2enKg+h6wlrLgjsCAbP85Fyja9IxqlY9hC1wlTaTJtTw8+bwXt0NxIpjGuJw/NYWlWtJvgGz7HWX1/Hcc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=Ks/WAVTb; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="Ks/WAVTb" ARC-Seal: i=1; a=rsa-sha256; t=1765485653; cv=none; d=zohomail.com; s=zohoarc; b=cd4y1wTcC0md9w6PVhpjgs5uzh6GE6uW2e6nVpGEb185Nbxh+0xndu0Y8MGNppsj9OWC4ItgeHpgO3gWlEjvDiAFJRsb4jKHiFWzu/DRWj9Mpj5/ddZ/ZqCSXeMmwguRrLsSeqwY8QomUAoCSZ6SeY69daD2vV5yHyHKiKkoMPY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765485653; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=mRlyajT7IR/ZPwR0TcfbPCQ8y++sA/LhQlBPz1JwgLo=; b=fI2nfLLNMZlLUavsmyrsZOgHmNZKIDBqqvkasKzQP1nnj3Y2GVE82AOn8iEs0F3Gts32SJpWodv4g5fxiWjiUOwu9sjc2gZcDRZ7y9hzMojymZ6Wjh10Ykg6hFQg8qF6sZ4zF1AslmJlgiO1/qcLQHd3FOhgjHhaUpF53vzSmls= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1765485653; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Type:Content-Transfer-Encoding:To:To:Cc:Cc:Reply-To; bh=mRlyajT7IR/ZPwR0TcfbPCQ8y++sA/LhQlBPz1JwgLo=; b=Ks/WAVTbm8cj8T6kIscqxN8b9el0n5XoGwG0QJUCRfTWNtJa8JsEJxU/iQPlHMGa xdX9cxHIosm54hkHL+UQDNO+rd9FAnBV9pwkY9BabBM8L2t5RIdDWarqh6azWYBm1Mp wTWYM0slzowvp0Q+3OhF3/X332OkdkbHuwPwIaF0= Received: by mx.zohomail.com with SMTPS id 1765485651850645.5059208739942; Thu, 11 Dec 2025 12:40:51 -0800 (PST) From: Nicolas Frattaroli Subject: [PATCH v4 0/8] drm/rockchip: No more post-atomic_check fixups Date: Thu, 11 Dec 2025 21:40:30 +0100 Message-Id: <20251211-vop2-atomic-fixups-v4-0-5d50eda26bf8@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-B4-Tracking: v=1; b=H4sIAD4sO2kC/33OwQ6CMAwG4FchO1tTBihy8j2Mh212ukQYbmPBE N7dCRcTjce/zf+1E/PkDHnWZBNzFI03tkuh3GRM3UR3JTCXlBlHXuUcdxBtz0EE2xoF2oxD7wF VgYSHGnVdsVTsHaXNgp7Oa3b0GJId1iGTwhMo27YmNFlHY4DVz3P2LtyMD9Y9l6ciXxr/7kcOC Hsty0pKLUlejsre70JaJ7bpyELG4pM5/GSKxOBelbVGnWv8YuZ5fgHMbVqFMAEAAA== X-Change-ID: 20251206-vop2-atomic-fixups-0c30e0980f85 To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chaoyi Chen Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Stone , kernel@collabora.com, Nicolas Frattaroli X-Mailer: b4 0.14.3 I'm taking over this series to get it across the finish line. Original cover letter from Daniel Stone on v1: > Hi, > This series is a pretty small and consistent one for VOP2. The atomic > uAPI very clearly specifies that drivers should either do what userspace > requested (on a successful commit), or fail atomic_check if it is not > for any reason possible to do what userspace requested. > > VOP2 is unfortunately littered with a bunch of cases where it will apply > fixups after atomic_check - doing something different to what userspace > requested, e.g. clipping or aligning regions - or throw error messages > into the log when userspace does request a condition which can't be met. > > Doing something different to what was requested is bad because it > results in unexpected visual output which can look like artifacts. > Throwing errors into the log is bad because generic userspace will > reasonably attempt to try any configuration it can. For example, > throwing an error message on a plane not being aligned to a 16 pixel > boundary can result in 15 frames' worth of error output in the log when > a window is being animated across a screen. > > This series removes all post-check fixups - failing the check if the > configuration cannot be applied - and also demotes all messages about > unsupported configurations to DEBUG_KMS. > > Cheers, > Daniel --- Changes in v4: - s/64-byte/64-pixel/ - Link to v3: https://lore.kernel.org/r/20251209-vop2-atomic-fixups-v3-0-07c48f0f1f0d@collabora.com Changes in v3: - Change the AFBC source rectangle debug message to talk about 4-pixel alignment instead of 4-byte alignment. - Fix another eSmart->Esmart casing case in a debug message - Link to v2: https://lore.kernel.org/r/20251206-vop2-atomic-fixups-v2-0-7fb45bbfbebd@collabora.com Changes in v2: - Dropped patches [1, 5] as they were already applied. - Changed the patch subject to use prefix "drm/rockchip: vop2:" for the remaining ones. - Fixed a checkpatch nag about commenting style in "Switch impossible pos conditional to WARN_ON". - Reworded "eSmart" to "Esmart" for consistency, and to avoid drawing Tim Apple's ire. - Make the hopefully impossible WARN_ON format conditional in vop2_plane_atomic_check still bubble the error up to userspace, instead of continuing on. - Use dest_w instead of dsp_w in patch "Enforce scaling workaround in plane_check", to avoid a compiler error. - Only reject non-multiple-of-4-pixel-wide framebuffers on RK3566/RK3568, as the other SoCs have no such limitation. (Thank you to Andy Yan for doing the research to confirm this!) - Consequently also only WARN_ON if this condition is violated in atomic_update on those SoCs. - Link to v1: https://lore.kernel.org/dri-devel/20251015110042.41273-1-daniels@collabora.com/ Signed-off-by: Daniel Stone Cc: Daniel Stone To: Chaoyi Chen To: Sandy Huang To: Heiko Stübner To: Andy Yan To: Maarten Lankhorst To: Maxime Ripard To: Thomas Zimmermann To: David Airlie To: Simona Vetter Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: kernel@collabora.com Signed-off-by: Nicolas Frattaroli --- Daniel Stone (8): drm/rockchip: vop2: Switch impossible format conditional to WARN_ON drm/rockchip: vop2: Switch impossible pos conditional to WARN_ON drm/rockchip: vop2: Fix Esmart test condition drm/rockchip: vop2: Enforce scaling workaround in plane_check drm/rockchip: vop2: Enforce AFBC source alignment in plane_check drm/rockchip: vop2: Enforce AFBC transform stride align in plane_check drm/rockchip: vop2: Use drm_is_afbc helper function drm/rockchip: vop2: Simplify format_mod_supported drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 137 ++++++++++++--------------- 1 file changed, 62 insertions(+), 75 deletions(-) --- base-commit: 7b1d0dfc434030b66fd2837f17db5c966a72590e change-id: 20251206-vop2-atomic-fixups-0c30e0980f85 Best regards, -- Nicolas Frattaroli