From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3CC51F936 for ; Thu, 11 Dec 2025 07:35:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765438544; cv=none; b=UdvRGHsTLblCRBsYNND4S6aBGYq4iVBcslETUBt7piwqGdPQx87fJFgD3lK1U/wsE+S/Rynaj9dXiV6XJ9sq+zAojJ8oK2Ftz6OIHG0SQATLSQNfr1vmejINIwlWaWoOmUlh4raObREIs+w1nIwTp+Ko2piXFDdNgEHmBSg9FqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765438544; c=relaxed/simple; bh=D9L3NlYN0YqGBEdLUPdxfdpbeolFXHZmFSSeiZG1E+Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E7xYTgZGNtylrFzoPgTupWzwvcqM12mk65en1iyu6nkVRXdcKjCR25O5UFXwtduRT+XUPOri3l4vzsgNEpDQ3jUq07TZuxF65tr/PYav+h6MbllJxKYCA4KXTuifbVvACQF+udG0s+fEw9ayA6Dz8ExhntCKEJuNBqkuX7lnwh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=CVGj2JFS; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="CVGj2JFS" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7b75e366866so268185b3a.2 for ; Wed, 10 Dec 2025 23:35:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1765438541; x=1766043341; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5cRIyUToWBqfDVg5RwgWa/mJtHaJ3ZD2Xr1P/TceRSA=; b=CVGj2JFSSYXw1vUEObIAYhKJu+GrOq+InkXUBVKRqsm+rGVHn29QYgvJJx5YFLfBeK 4Se9W0k9c/RingXjjotYMd0JE5yPMZB3ygRvTI4/gsWJVP4+JZmODsEw2GKKFTK8HHf7 yo0xyHKcBmLX/XqdRMxZG2oxHtTZucD/93OLUoNmLhJ3lLcdj92s+mEgbYxu00MktOxT u07EveaKpTXF+Mfdof1ufkly5LEVwNvJX6e6lyjhghV6RtpfubFtfAmSP7M//znvaP9u haEuOXMlUXJnXEJ/lM2LI6ALAUE686LMDhwVj7Pqat8ZgD8j0dAjyJOWMZc8G3J8gzBw xUkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765438541; x=1766043341; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5cRIyUToWBqfDVg5RwgWa/mJtHaJ3ZD2Xr1P/TceRSA=; b=XLN4hBnapTvNjloivYXBAKKoL5eFxHR+eeyp1zvxMhdn6Tud/r+0gzUdJ+vosmtao5 uU0A9qqscsvGxVM9hee3fC9DvgtZq2aIM5WHFJG1FlcFFq6RxKbStk8XKr/wFp1qSBr7 zGDNxVRcNFur4xZv6dqI+Nlq6gBs0gt8ljkmIQVNd31NRLXTkNno/UOkROrIpvS+G/NM zTtfXR+SfeQjeYHzeXc9/T99PXJqX7Td1NN7SxDD0DCmA1BzASurMuM/5bkiHU7Gyk7T p70Cg69IBqDtWXpCbsWseE+2EWsKpyju3jojKgs2hvlA2zINri1IGvNjLoKHZTfFLqG8 5Pkw== X-Forwarded-Encrypted: i=1; AJvYcCWkAAb4WZO/b9yqaJ4b7DAmlUFtjnjqNQ5OODi1eaHzgUuuqSdpvaKuUwBsS0pbOL0XrvKK45OFysoZP3M=@vger.kernel.org X-Gm-Message-State: AOJu0YyzkthwBUX14e8be1CVAGdX35BYtNc3dJPpyCK0tT4Icwl0kdJX 4RZ1HKVKE8WW2797pm/VZqqoc2WdgPDVdFbVUCDrUw+vlHPTOuueKqK3tUO5dpHFLtA= X-Gm-Gg: AY/fxX5iDHlLQFDv7FVjgh0f0uerKFWFj6Y7N7JPf08Um7j4OYSueS3hZONnmcMonrx 2VEN+tcbkz1q6JIqIzTskkLE5lYuwwaDNttSgLWMph4bqllpSMRY0aui7kw4sIya0Zll4VAtWbK cFAsGzY84ngZTidO26873n1pHpDjVGxMZ78zestev+eAL4Hoh6SMZ5MdYvznAZbDl/1Ti8kNVdq F7aDnLVQP1LM+nYyt/jlXbMfG6AmmTOmWK6cf+nkmg1w+tHQ18D1NrvxAbBoRxxdDnJz36wtAT9 tL4ttofUb7Fr7U3wEsTFLmVw4tftPq+QpVEZ3ischvMyMfc+UJutG3PKInb8OjMmksE5SYGR8lz zQAVMKXrPitRMae5XsQQW1ppO2mB5tmMR61UU5f3KZ01LIskFdlbYYoLdmIDPAf78sIwf/xbKvE m9apMkhTpmkp0aNRP5P1e0MwJ3+90Se0nOvBltcEf+LL/l8HE= X-Google-Smtp-Source: AGHT+IGoUuUHw4G8GEx6LIfCNmK4Wz0P7Vv4+W+//KXKrKQNRYKoJQHJnPyRAtlt73kARbQ3vU0CQQ== X-Received: by 2002:a05:6a21:3086:b0:366:58cc:b74b with SMTP id adf61e73a8af0-366e07dae21mr5212459637.21.1765438541298; Wed, 10 Dec 2025 23:35:41 -0800 (PST) Received: from localhost.localdomain ([2a12:a304:100::202f]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34a9277e13dsm392594a91.5.2025.12.10.23.35.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 23:35:40 -0800 (PST) From: Guodong Xu To: jyc0019@gmail.com Cc: alex@ghiti.fr, andi.shyti@kernel.org, aou@eecs.berkeley.edu, conor+dt@kernel.org, devicetree@vger.kernel.org, dlan@gentoo.org, krzk+dt@kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, p.zabel@pengutronix.de, palmer@dabbelt.com, pjw@kernel.org, robh@kernel.org, spacemit@lists.linux.dev, troy.mitchell@linux.spacemit.com, troymitchell988@gmail.com Subject: Re: [PATCH 2/3] i2c: k1: add reset support Date: Thu, 11 Dec 2025 15:35:26 +0800 Message-ID: <20251211073526.3164875-1-guodong@riscstar.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251119-i2c-k1_reset-support-v1-2-0e9e82bf9b65@gmail.com> References: <20251119-i2c-k1_reset-support-v1-2-0e9e82bf9b65@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, Nov 19, 2025 at 07:46:44PM +0800, Encrow Thorne wrote: > Add reset control handling to the K1 I2C driver. > > Signed-off-by: Encrow Thorne > --- > drivers/i2c/busses/i2c-k1.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c > index 6b918770e612..64d817d8315d 100644 > --- a/drivers/i2c/busses/i2c-k1.c > +++ b/drivers/i2c/busses/i2c-k1.c > @@ -10,6 +10,7 @@ > #include > #include > #include > + #include > > /* spacemit i2c registers */ > #define SPACEMIT_ICR 0x0 /* Control register */ > @@ -113,6 +114,7 @@ struct spacemit_i2c_dev { > void __iomem *base; > int irq; > u32 clock_freq; > + struct reset_control *resets; Thanks for the patch! A few suggestions to simplify this: The reset_control structure doesn't need to be stored in the device struct since the devm API automatically manages the resource lifecycle. > > struct i2c_msg *msgs; > u32 msg_num; > @@ -571,6 +573,15 @@ static int spacemit_i2c_probe(struct platform_device *pdev) Please use a local variable in the probe function instead: struct reset_control *rst; > if (IS_ERR(clk)) > return dev_err_probe(dev, PTR_ERR(clk), "failed to enable bus clock"); > > + i2c->resets = devm_reset_control_get_optional(dev, NULL); There is a new API, I would suggest this: rst = devm_reset_control_get_optional_exclusive_deasserted(dev, NULL); > + if (IS_ERR(i2c->resets)) > + return dev_err_probe(dev, PTR_ERR(i2c->resets), > + "failed to get reset\n"); > + > + reset_control_assert(i2c->resets); > + udelay(2); > + reset_control_deassert(i2c->resets); > + Why you need to call assert() then deassert()? Wouldn't the single API fit? Best regards, Guodong > spacemit_i2c_reset(i2c); > > i2c_set_adapdata(&i2c->adapt, i2c); >