From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFD7172602 for ; Thu, 11 Dec 2025 22:38:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765492708; cv=none; b=MYWVKDoce4nbUt80a3lDYwk0XkcEaLFwivGCQOmEtHPQTAjBtzwmJWIg4F2D+IMPZ4Y8daxmXZdUAWIJVtqJAChCsEol5U6tiEtS3WKg3UaE0wsJ8njQdYHlSIvg2eWMxnEcyxGSZnZK69KaKpA/xrCvbeqHb5td0cjAOv907fs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765492708; c=relaxed/simple; bh=1/8Key9jPUF9kdFywxexQQJ77qY8t1G1QLavT6pKn2w=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SBZ0u32MlmNt+6w+Euq45DZtgJPduqNarPksYmB7XSaKZYxdGzHWeay5Q2xxCtFwk1VGPtlNGgBJ1JOlZowQxymLsp/Xo/s31zbWg37Q8AHuyt1s9/DgkKUCVnqhJtF+yyEdF3jChK4+F0VafEKbvmsJB8TAdkBQBpYp8rzXlIs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ci04RLJJ; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ci04RLJJ" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-477bf34f5f5so5401495e9.0 for ; Thu, 11 Dec 2025 14:38:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765492705; x=1766097505; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hJB9vsPJhBGqG1y/+P5/s4l3WFLRuJ78lA6bLowUWtk=; b=ci04RLJJlHGTrh2wWAHZQuU9RaW+FO2LYd2gORGosDU12vLKNtDjyn2e6AOdkzSbST wEs06w5eEwEjY1XE6+GVk8q6b2H7RTHbqvAyzENw11+73cobcx8QsuzV4h2+29VaWS+N ZBkaXSjCDmGvPMmx10q6iV6DyyRORmSAq2LAcY2bYDUcN/Nl5+8rWS5oxYAZkhwZjVUu 9IEtHZ2xkcXuBggLzKRZFBO92Estw+lQZquTGsJJpJdTRzf8lcd1E7ZyZ785NHhdJ9za nEDF7LaYimkT2BX15YAuEEct07kvWBNcTuEJoe/iqwPVu78Hf0m++gQq2/3goHck3PuC hVZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765492705; x=1766097505; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hJB9vsPJhBGqG1y/+P5/s4l3WFLRuJ78lA6bLowUWtk=; b=i8wLjW+mFYseYI/KWqCrEhkJfC9+VNNttXvdw6FjgKmbOApjvh4LytvRG+YK0kHtTJ AU0RoJsBCaD3K75HNAJW1oRXm0KoJB9MK0QEbGVXmy5nJUn1zNGeeCd76zEWtp8OQCs8 5pEeZeYuWGsh3wehjH07MnHUepp16m8juivHvYsGMskHQAX1BeWRdztB8Y1/dKtrRIaY 8EvtzmvknrmWjkaGLNslsmM3i0OpC4bsCNyIbG/Ha4uzBSlrj6dawaFbc8XXWkE7dWFl EguFt+ORle7CBUi1Ty5XaM/nM+bGrI0/9+FklqUfjZiN9oP/omYL5s0plSuUQGEWBuUx /mkw== X-Forwarded-Encrypted: i=1; AJvYcCW6y/DvqSadzyvQ8OYJxlNSmWtfuD85SEILrIbyGWaRVdlieHGHN/IHltdej6l65Zu4ZgEKIf44HlZJ56E=@vger.kernel.org X-Gm-Message-State: AOJu0YyGK8CbbqDQ8wY0iw/RwDXGX6lz9Oap83MYUgSzTZWBMHdnwBzQ By6w7WT7av1WcXLphl7PQcud6HPdzge5PXJ65zXNmER3hfKbBi0FO1Vh X-Gm-Gg: AY/fxX7LEdrT0Ubyc2kSbMXAYW7JFfJKiLX8e0ujsMVVg8y5X+dLA3a5X+UQWh78dmz OwWGDT/7mFPPNYWGyABXaC5ldph2pCvdq+A1J2Ta2UJ0H0Z+l8KqlL3f0b3glHd1frqh1eo4/9Q XMxIB0+H112phlWXKbcennd/9jZm/c0gjD/sXDi7ZuwtpKSs+X2BmjieBWEG/9wuKvIa9+k2qrZ PcA85/9J7Oo2/0iQSwcYAYpTVzYdQgFC3PmpBYVuvjlOWdAcruarIb0ACOwG10PVzV0d7Q9sMxV Y8uQerLaDINWHKU3V+KpCUKhsI/vZgGsGcgMO5lbs5X1qkNUEIkFghPfmLWC+uZhC4lU/GDKzzM FIv/gFhoa97Kkcn+F3mKCBHA3tn9o3L1G1i2U+HunybVPE8A7elB5+E01NinDErGFAwjtWxg5JK egGuL9wCDgCbWOpuciqbl3trktTSCzKQ2g/AiVQ+miHbKOAbaMoRRn X-Google-Smtp-Source: AGHT+IHLwdFc72oZ+XpABv665DoqMI2joXHmdbmUSRJgh1kVpg1rJGVTxEvlCZOJHg/L9U83lkVLTQ== X-Received: by 2002:a05:600c:a06:b0:475:e007:bae0 with SMTP id 5b1f17b1804b1-47a8375362emr95622175e9.16.1765492704852; Thu, 11 Dec 2025 14:38:24 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a8f3a20c2sm508975e9.6.2025.12.11.14.38.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 14:38:24 -0800 (PST) Date: Thu, 11 Dec 2025 22:38:22 +0000 From: David Laight To: Nicolas Frattaroli Cc: Sandy Huang , Heiko =?UTF-8?B?U3TDvGJuZXI=?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chaoyi Chen , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Stone , kernel@collabora.com Subject: Re: [PATCH v4 1/8] drm/rockchip: vop2: Switch impossible format conditional to WARN_ON Message-ID: <20251211223822.6eeabb4d@pumpkin> In-Reply-To: <20251211-vop2-atomic-fixups-v4-1-5d50eda26bf8@collabora.com> References: <20251211-vop2-atomic-fixups-v4-0-5d50eda26bf8@collabora.com> <20251211-vop2-atomic-fixups-v4-1-5d50eda26bf8@collabora.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 11 Dec 2025 21:40:31 +0100 Nicolas Frattaroli wrote: > From: Daniel Stone > > We should never be able to create a framebuffer with an unsupported > format, so throw a warning if this ever happens, instead of attempting > to stagger on. It doesn't look like you've changed the behaviour. Except that all the systems with PANIC_ON_WARN set will panic. I believe that is somewhere over 90% of systems. David > > Signed-off-by: Daniel Stone > Signed-off-by: Nicolas Frattaroli > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > index 498df0ce4680..20b49209ddcd 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > @@ -1030,7 +1030,8 @@ static int vop2_plane_atomic_check(struct drm_plane *plane, > return 0; > > format = vop2_convert_format(fb->format->format); > - if (format < 0) > + /* We shouldn't be able to create a fb for an unsupported format */ > + if (WARN_ON(format < 0)) > return format; > > /* Co-ordinates have now been clipped */ >