From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20C4621A449 for ; Sat, 13 Dec 2025 11:05:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765623943; cv=none; b=em2H4W7gwYqpRGQswZh1+sDr0wbccGhkoRRukO7MCyS8k+bWooloqjD11scBI31URSOXre7f/9CS1gxBD5cYRtHdP9ffXVlLVuuIU0XlakP+RZSIUCqHgoyVpEza86DN3V86ZsZV4AWCZrUH0wj0YZ1EUQWkUa7wiO54oMmwjQg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765623943; c=relaxed/simple; bh=eIJlkmB/GRZzqWXY/TXR/frfHynJkJBeE5Cp5x0g4pc=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=BC3uPW6u6dpQqMVE+XcZCiPhnv/Hnpb6Q1o6IWwlh9JkHEmrTCAgpenJp9G9ZmMVdg7QyF3GtQoiRZJ8qM7kl0WvDqa+ooWL6a7ZmJKgCN0SZDl6b7tFjyjuRb4W7ALIYqz5DUgsj3SSkrK2E9tS7BjBvTXOfAenA/Q4ueyepes= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=EdyLJXts; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EdyLJXts" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-477aa218f20so13292515e9.0 for ; Sat, 13 Dec 2025 03:05:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765623939; x=1766228739; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=akrEjsebCHvdmAghGI3gbVT9gvRKLMOOrbNDoLAYklU=; b=EdyLJXtsd/UJeECjUH0cM+r49wZ79v0htNeYXTjHRT9xzEEPEnVUXoTOhhuW8UFQkK IbuQCqeLMQU2oC5YFdQC5XEzb+S9n462bMB1ZyvA//2ToRIe14Bpkki20DT7qCWTChL1 vq5rcjrUY35ekm3jrO/Yu/wXbDqjKPGYHVYQGdV2RVUe3+3ICv+1qmIv02KcVblyQwDp Ejm2rKNdwNvf0Gj/3r34GJ0yYqRB2eYibJEFSKM3rTlmsKC6CeaX+L3HJGg0+btdCpj3 0bzKLtwm8e6cgWPmyEZIcHhr/bWe6V2c1Vjg6ujv7LLrYnrTy2LhD6RA/47aP6Ywq0m7 NDBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765623939; x=1766228739; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=akrEjsebCHvdmAghGI3gbVT9gvRKLMOOrbNDoLAYklU=; b=P3EpX8QOAvDVoKyOqqEKKwDdk7cYgNrRmbDqlYnqNWtjWdOS59J7v7GCh284GCMFX8 ec9/3cqsnqs59i1lTXrKw2Z+OCYoQdHJi1is49YJ0Lf+yYupDadmP/ThryECJIYcxtRw jbfOD72KQPiTzzVlBWCrbva2gnkJydMoLwvkgbbjDQVtPoFMGzEn78mhxWx4ssbqkd0/ Rg1ZmzvgJcMxYBsFzJgL0vEOnVD/HywZoaMWnjX5CJZguQ3v+O4epobOOjZWCPp7Ibtj 4A85OBAZtn1UdicDbT9HGPzOxpfpauzCtCF0kFkBUTn/IY8G0AVaQPe8n3mmYdzb3yJc wM7A== X-Forwarded-Encrypted: i=1; AJvYcCUW+udMnDVyrBAPmdtnIjV7t+U+s6fitSZkIGJU0NCxQKxly0lj+Gf9WymGUGnFqj5+zgI7bQu/lxig2sg=@vger.kernel.org X-Gm-Message-State: AOJu0YwS0/n5wCeMpcSNABl3J/REcVyFbIswVkSXmqtblgEl3sZTveXn 21pveztIxYKezAY4590/7DMGn+3V7PIX7oyj6yo1OctMzF6nkcO5CLkXJq9lfRkce3E= X-Gm-Gg: AY/fxX7tqEl0BWoy/Cc9COUyQLi5tng70LtffW3KCMIdtpgcZEcnT71zDYsaqY6+vck V8a4CyS1LFCSlQ3ffNBEZAE7bg7wHOerdlbbKHDU5Iu2ARFRx51OazSo7s3FnabpHLY2vlstQvz OBY8V2OYR/0cPb8Fbv3ZAt2dlJFP2o/Xm7lJQ5CCwTm6HATEZbHbI752Uxw4rooK5Wiz0WM2mfQ MVP9CBNTe0MOzfdVf8PLATEThWyS+npDs6ke9Rg7l4jeS+zZrY6IWm1iSCf95ZrZZ9r2UpFzkES nZXNMss+VbJNBRR/eXbwegi0FmbJCUy2/I5H+jyH2bUA8/g6rXMQDOrAAWHtJiWDh8x43BmNrpY UL7F5kIamm4tY4wdUBE6p5MY5+waYfW6PCnsEkCfstjMqboAsxLQF4DXfR8d4e+s2NmmGV/p+Q4 63u8OCzObYm1gOsSPi X-Google-Smtp-Source: AGHT+IE+pX8X2Ot532bTKW7TF2VDVMGDA06itUIEaUomojq7OnkTUqThaR9z92r+Z3ptlzWx+7Cing== X-Received: by 2002:a05:600c:1c92:b0:477:333a:f71f with SMTP id 5b1f17b1804b1-47a8f905306mr68638335e9.17.1765623939317; Sat, 13 Dec 2025 03:05:39 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43009dfe55asm4252942f8f.41.2025.12.13.03.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Dec 2025 03:05:38 -0800 (PST) Date: Sat, 13 Dec 2025 14:05:35 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Amirreza Zarrabi Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Jens Wiklander , Sumit Garg Subject: drivers/tee/tee_core.c:735 tee_ioctl_object_invoke() warn: potential user controlled sizeof overflow '20 + (size_mul(32, (arg.num_params)))' '20 + 0-u32max' Message-ID: <202512130645.3njk1yxJ-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 187d0801404f415f22c0b31531982c7ea97fa341 commit: d5b8b0fa1775d8b59c3fc9e4aa2baa715d08f3ee tee: add TEE_IOCTL_PARAM_ATTR_TYPE_OBJREF config: csky-randconfig-r071-20251212 (https://download.01.org/0day-ci/archive/20251213/202512130645.3njk1yxJ-lkp@intel.com/config) compiler: csky-linux-gcc (GCC) 15.1.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202512130645.3njk1yxJ-lkp@intel.com/ New smatch warnings: drivers/tee/tee_core.c:735 tee_ioctl_object_invoke() warn: potential user controlled sizeof overflow '20 + (size_mul(32, (arg.num_params)))' '20 + 0-u32max' Old smatch warnings: arch/csky/include/asm/uaccess.h:191 __get_user_fn() error: uninitialized symbol 'retval'. vim +735 drivers/tee/tee_core.c d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 710 static int tee_ioctl_object_invoke(struct tee_context *ctx, d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 711 struct tee_ioctl_buf_data __user *ubuf) d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 712 { d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 713 int rc; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 714 size_t n; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 715 struct tee_ioctl_buf_data buf; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 716 struct tee_ioctl_object_invoke_arg __user *uarg; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 717 struct tee_ioctl_object_invoke_arg arg; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 718 struct tee_ioctl_param __user *uparams = NULL; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 719 struct tee_param *params = NULL; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 720 d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 721 if (!ctx->teedev->desc->ops->object_invoke_func) d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 722 return -EINVAL; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 723 d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 724 if (copy_from_user(&buf, ubuf, sizeof(buf))) d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 725 return -EFAULT; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 726 d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 727 if (buf.buf_len > TEE_MAX_ARG_SIZE || d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 728 buf.buf_len < sizeof(struct tee_ioctl_object_invoke_arg)) d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 729 return -EINVAL; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 730 d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 731 uarg = u64_to_user_ptr(buf.buf_ptr); d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 732 if (copy_from_user(&arg, uarg, sizeof(arg))) d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 733 return -EFAULT; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 734 d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 @735 if (sizeof(arg) + TEE_IOCTL_PARAM_SIZE(arg.num_params) != buf.buf_len) This isn't a runtime bug, because if arg.num_params is too high the kcalloc() will fail. But eventually we're going to create a KMSan thing to make it a runtime warning when there is an integer overflow in a size_t math. Integer overflows are complicated because the integer overflow is harmless. It's just math. If there is a bad effect, it always happens later. But we want to start considering it a bug in a limited way just for sizes because that makes preventing bugs easier. You could use: if (size_add(sizeof(arg), TEE_IOCTL_PARAM_SIZE(arg.num_params)) != buf.buf_len) return -EINVAL; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 736 return -EINVAL; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 737 d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 738 if (arg.num_params) { d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 739 params = kcalloc(arg.num_params, sizeof(struct tee_param), d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 740 GFP_KERNEL); d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 741 if (!params) d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 742 return -ENOMEM; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 743 uparams = uarg->params; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 744 rc = params_from_user(ctx, params, arg.num_params, uparams); d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 745 if (rc) d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 746 goto out; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 747 } d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 748 d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 749 rc = ctx->teedev->desc->ops->object_invoke_func(ctx, &arg, params); d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 750 if (rc) d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 751 goto out; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 752 d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 753 if (put_user(arg.ret, &uarg->ret)) { d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 754 rc = -EFAULT; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 755 goto out; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 756 } d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 757 rc = params_to_user(uparams, arg.num_params, params); d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 758 out: d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 759 if (params) { d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 760 /* Decrease ref count for all valid shared memory pointers */ d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 761 for (n = 0; n < arg.num_params; n++) d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 762 if (tee_param_is_memref(params + n) && d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 763 params[n].u.memref.shm) d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 764 tee_shm_put(params[n].u.memref.shm); d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 765 kfree(params); d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 766 } d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 767 return rc; d5b8b0fa1775d8 Amirreza Zarrabi 2025-09-11 768 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki