From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45EC7184 for ; Fri, 2 Jan 2026 14:49:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767365387; cv=none; b=PqX9j2G5zeX0VmR31ly9+t5gsW8c5YVXfaX49cRWiSd7joJCUGdKOfRyhKe4/SRIImgvmk34MMQb6YVpL4+EBo331KEC9svJgYVBUTpgRbfA0B36oRxnJRZ1plEjO2p9kBx+sVA21oj8z83lUro++OCXpCM4GiC/0nC7U3S7Kqg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767365387; c=relaxed/simple; bh=CUM8SWey49IY454Cqm5r4265//7UfKy+pC3HLEFDWdI=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Z7Y4+QJ3OmJLsRbghjCbOacDC1Dtbai9odm+PrWo7rW0DQdMfoVB3TzNlahoPtHlgYn8+ZzIduAV5NDpqkSb+TU3R7ObX8xG8bx+m5xc+mzDKJ1tsVOhuB9B1frGv2GXfIPL3H78Dy3r78M/J4mTw432mqAc1UTY2D0eS/ZJ0yE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gxChNqVL; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gxChNqVL" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-4779cb0a33fso124555475e9.0 for ; Fri, 02 Jan 2026 06:49:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767365384; x=1767970184; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=RjMCcg/MDTN/xKiOvEQlPAUaIosRslZ1GZtEMqixl5c=; b=gxChNqVLkJGiVrPgOXxIGp8Sbk+kZicUCToO9QMTd+Vxo21dCm/EqOcjZtRbnGJAAB PY1DHOkRvbxoOQV3hlU9T2c+rDD+bt9VAVTszsvuEhp1xW4gW2Kvbi5BbpXgZYqnqHn7 DhNGot5BqcR6ggPwBfTE4v5D/wOPzUSHN7odKHrs9YKpJG494+8PM4gONSLN7+p84XTp jY3q7gH0FW/c8nNlXFnfzHSOduY7juT4b/2GuWR/jATqwD96Z16tW3mDMNq9m0m0N67U 92D0Ka4m2XutVshwGczkU0q/eOtAQJK1WwA85l53CDlqN6kgMN/IWOTbYbSiUojwrjG7 sKOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767365384; x=1767970184; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RjMCcg/MDTN/xKiOvEQlPAUaIosRslZ1GZtEMqixl5c=; b=N+WJJECV5bumtAIzqnKKeXvQAQfH3SCzjI+XN5qY9iHueNP7uzjHWP5aouG+MdjiIk 5SYYGr4PABYhrT4yGsg6vgGcA7Y/1P4irG975pZfggYWNMHsC08eGtjJxPnYOem2utDs 3pJXV1ld3hYRyGL1Vy/sKs1g/jatVmVTq/yhXvG4zES2XZ/14VWpkQeRsBLTBAUaIHYR 8G1zIkJ5f78EXyEIPBcHkEcdIuSJDeQev6tsGUqTjJeSwy1umcv56n0bzFoA29VCYsGF fIRIynYUf8YOfheMdKBLmySZBdTJqU6xWZNW4qyi2CJpnXXp2YwJ3iA9EJW15BlSIIMH uYIQ== X-Forwarded-Encrypted: i=1; AJvYcCVaDpi7jRXzGGsYoZNYyGGdN5ZYcCEw/aF/g5CwJ/GXctR5VhsjI15gJX0DLCptYLY4NTBiUnJvIInI6MQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwDSgCMNpjMEo4uwn2EZgOVl+Uc/ZVuFdDCYo33KwX7kC8eoqt8 6qomBQGcHPtYaWAjuBtF+DL8f7C1of0aLrKbch0GwtaTES8ngwYVtpemEGFNWBrCD1Y= X-Gm-Gg: AY/fxX6mEKihpFvrHp8kJa3iHGsMON5qmQCnkYdelXtwmOm0OyczXaFN0/f63i+qiYD tIgPKM6L27a1Eh1qo2CXeYLf5/iqYsQAytvbCWvENaUvMjmW1UyF6hSj0FYEVeLq18Flzsh1yHD cLiXjZ/j7Yap5QJVmCSpNwRJWepIhZfT90uuMIaM10xWly9Tx585zrZATJdDw7R9OMl6pBhLjX1 lAJETz4YrlR3UyoFXT/paHR9FJwDLXquD9EzEkcDpN8ZcXna5he2214c0u8ytQRJmlMAeaD7OA0 21GWloVbJHnMNB+K/RJZ2igCJNbUOIRtxDqpXEXgGtbD32ZKbpJ/8ojptiyeiIHfr3aWUJQLTrk sR8JMw7bAi4Y7NAV/mNTx/LIYBKD0HDev6VhIWsiYv9qCnrbsVuPcRUods+5gzp71ARbIiQxn9O dtQdyCW5hTSNVTXKWr X-Google-Smtp-Source: AGHT+IFhicLtOgLW5YhNppgbobIblo2mgTPdzhYu4oOqTVS2NcDuC+HmtEtmYQP1aF1z6wPu4tx3cA== X-Received: by 2002:a05:600c:1f13:b0:47d:6856:9bd9 with SMTP id 5b1f17b1804b1-47d68569c53mr46877375e9.23.1767365383541; Fri, 02 Jan 2026 06:49:43 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be272e46fsm775669275e9.4.2026.01.02.06.49.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 06:49:43 -0800 (PST) Date: Fri, 2 Jan 2026 17:49:39 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, "Masami Hiramatsu (Google)" Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, "Steven Rostedt (Google)" Subject: kernel/trace/fgraph.c:834 __ftrace_return_to_handler() error: we previously assumed 'fregs' could be null (see line 830) Message-ID: <202512131657.JQUt5fXQ-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a919610db43b34621d0c3b333e12db9002caf5da commit: 2ca8c112c9676e2394d76760db78ffddf21d93b5 fgraph: Pass ftrace_regs to retfunc config: arm64-randconfig-r073-20251212 (https://download.01.org/0day-ci/archive/20251213/202512131657.JQUt5fXQ-lkp@intel.com/config) compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 1335a05ab8bc8339ce24be3a9da89d8c3f4e0571) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202512131657.JQUt5fXQ-lkp@intel.com/ smatch warnings: kernel/trace/fgraph.c:834 __ftrace_return_to_handler() error: we previously assumed 'fregs' could be null (see line 830) vim +/fregs +834 kernel/trace/fgraph.c a3ed4157b7d898 Masami Hiramatsu (Google 2024-12-26 810) static inline unsigned long a3ed4157b7d898 Masami Hiramatsu (Google 2024-12-26 811) __ftrace_return_to_handler(struct ftrace_regs *fregs, unsigned long frame_pointer) d864a3ca883095 Steven Rostedt (VMware 2018-11-12 812) { 7aa1eaef9f4282 Steven Rostedt (VMware 2024-06-03 813) struct ftrace_ret_stack *ret_stack; d864a3ca883095 Steven Rostedt (VMware 2018-11-12 814) struct ftrace_graph_ret trace; 7aa1eaef9f4282 Steven Rostedt (VMware 2024-06-03 815) unsigned long bitmap; d864a3ca883095 Steven Rostedt (VMware 2018-11-12 816) unsigned long ret; 7aa1eaef9f4282 Steven Rostedt (VMware 2024-06-03 817) int offset; 7aa1eaef9f4282 Steven Rostedt (VMware 2024-06-03 818) int i; 7aa1eaef9f4282 Steven Rostedt (VMware 2024-06-03 819) 7aa1eaef9f4282 Steven Rostedt (VMware 2024-06-03 820) ret_stack = ftrace_pop_return_trace(&trace, &ret, frame_pointer, &offset); 7aa1eaef9f4282 Steven Rostedt (VMware 2024-06-03 821) 7aa1eaef9f4282 Steven Rostedt (VMware 2024-06-03 822) if (unlikely(!ret_stack)) { 7aa1eaef9f4282 Steven Rostedt (VMware 2024-06-03 823) ftrace_graph_stop(); 7aa1eaef9f4282 Steven Rostedt (VMware 2024-06-03 824) WARN_ON(1); 7aa1eaef9f4282 Steven Rostedt (VMware 2024-06-03 825) /* Might as well panic. What else to do? */ 7aa1eaef9f4282 Steven Rostedt (VMware 2024-06-03 826) return (unsigned long)panic; 7aa1eaef9f4282 Steven Rostedt (VMware 2024-06-03 827) } d864a3ca883095 Steven Rostedt (VMware 2018-11-12 828) 7aa1eaef9f4282 Steven Rostedt (VMware 2024-06-03 829) trace.rettime = trace_clock_local(); 2ca8c112c9676e Masami Hiramatsu (Google 2024-12-26 @830) if (fregs) It's strange that Smatch is only now complaining about something which is from 2024... This line assumes "freqs" can be NULL. 2ca8c112c9676e Masami Hiramatsu (Google 2024-12-26 831) ftrace_regs_set_instruction_pointer(fregs, ret); 2ca8c112c9676e Masami Hiramatsu (Google 2024-12-26 832) a1be9ccc57f07d Donglin Peng 2023-04-08 833 #ifdef CONFIG_FUNCTION_GRAPH_RETVAL a3ed4157b7d898 Masami Hiramatsu (Google 2024-12-26 @834) trace.retval = ftrace_regs_get_return_value(fregs); ^^^^^ Unchecked dereference. a1be9ccc57f07d Donglin Peng 2023-04-08 835 #endif 7aa1eaef9f4282 Steven Rostedt (VMware 2024-06-03 836) 7aa1eaef9f4282 Steven Rostedt (VMware 2024-06-03 837) bitmap = get_bitmap_bits(current, offset); 420e1354bcb6f0 Steven Rostedt (Google 2024-06-03 838) -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki