From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE9BA382D2F for ; Wed, 17 Dec 2025 14:28:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765981724; cv=none; b=FaOKVfY42IWoxmk97vG0riirD3UtaqF6a76QQpO5btdfp1pW5yr1A/ubowaLM6+sYuLofRZWdfJPIsfSB1Ljrf0pKtb2pJRECg3Fzg9Hp477dVlh3S8+o91sRu66zFBhXCpuCntd9Uq2kih2O02K7D0DtPYYZ79eWJuRPbbI6Dw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765981724; c=relaxed/simple; bh=J6NSUzD2V2k2/q+qqNzY1IFQg+Meq4nswaVLTHkSkI4=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Gyxs8+ZOZ/CEmdR+5RSJmYxKZ6wkzV8WA5/okw4iniVEPGqGhsq+ZWr9zzQdQLqi1JMJi/LAFP5oxqUMuWNH8E1a8aNJxNAio/DiK7cmyG7YSig4k98BDd7a+0Bvz8BfmZ98djiD8pupo5G2dHa1KysQ71Ijtsp32ggi7cTAdAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tQAxF0g+; arc=none smtp.client-ip=209.85.128.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tQAxF0g+" Received: by mail-wm1-f68.google.com with SMTP id 5b1f17b1804b1-4779adb38d3so44512715e9.2 for ; Wed, 17 Dec 2025 06:28:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765981721; x=1766586521; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=MHx7DZEBmfQLYTq+RgL+Ee4so8rfbbSfi7WOO0Gbr+4=; b=tQAxF0g+d7gvO2LrnTIru/ONSgsMf3U19W2AwCOBUETihbHMqDBDnHobT5HxOd8+ZC c5/a97iPmRPIRAr1nVFPJqq7tB4N/E9xL1WCnmcJsIKil1D3Be0nFUN+PzqwAElS+gnH chex/N8MOu7sK0Jpg/Q/m9O2PxpCvoQl1tbxsSKroKEZMkcJrPEPIfLVCCSYHQlqLtov zduO6z2ieDM+wz3kUWVVjyPbjdIHQTNxgZyxM6k1z1GQ5rvO9MdJLlQhYc0OeFw2SSzd /LKz6cQQgG24qpXK8C2bpXHbL8SMWiAL6oKQnGcVFzrarkJUmbbagR2k7dn0aFkW+N29 e8xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765981721; x=1766586521; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MHx7DZEBmfQLYTq+RgL+Ee4so8rfbbSfi7WOO0Gbr+4=; b=qV/M3f7wQ5+D+7zRIodpdrXlvuFxXL98yu8jnPr4htI2nFE6k4MfEDbH9DsYQDZm6J bpD5sxOgWcLU+gtBKFZHRw30EdjDAid6i9tXMNdQpPoPIgFHUNftYcs/y1rrw8psLVAN Td0JXppDoluxbtS6ERwdtdQfblGl83il4pa/TtDt8pfW+Xgfx4vyDffMDOfmUwIjYN/S PqVjZY+ufs6sdb5ILxDs6P9PJ5d6OSqb1q/iQ52nJfaKI37gNu7yjiS9FEudQ7mknRDb Is7hUXmWW+VWNJA9siNzMGp5j4Jl2dAPK1lJBYfeWCB11Fu8SLqXt3Bu7XuVUw0GPc5I RVvw== X-Forwarded-Encrypted: i=1; AJvYcCVaVXetx2W8U9qbbMjtj3hrl0sA9wPeeiDo4UBzlpzQkjmP4ni/4hM7bOyO1FH94O461Gm/ROvJicsK1v8=@vger.kernel.org X-Gm-Message-State: AOJu0YyjRpQqCccV4vMJ0hPC9FswNg2arO/JZBA7qH5g96dxp/yIgGW6 NIdhVku3DVoZS5QO+uSjpk7oF5HKnqB8fIhudu3/FzvpN+5PA+iMQQTyH8gTNLDym3Y= X-Gm-Gg: AY/fxX6BsD9WoCVCUjrA+RnX7nHRBXpRDRqtGaEsFCLFwIZ/7cdtiODq+pNGYyAlWLT l6YG8wz2Lw4bTZ7Jf6ZKk0vjnddyMTIuMxsT8oWZfbPNyIqCidtxl7EnJgF5IHWJvjghdVv7DMG KscV2r/t7iDuzRsQQh/FeDdWYvFpxztGsIs2cN01VMwPd4ECQK7bTDqZzEW7Hdse4vd0ImzfTws A0YyUYvvHDNq+7VBNFU6zhM6MnRs8Hy7K1gD6aJsvYax3VRKX7oMSJfJS6IDJP3Kkt6CjBsObqU DVmBFBV2LRYllfoeKIUJcyqlyplLmK+PBTicg3B8tvV5JT7sLd65cluJQwjM6oWhVvakYQLa9Kc 8zXZz7wf3KqLjOMA3UCbvdNgmxphQZkkjPbM8vfsNOcYk0PsDMeAPu04aBuIqdFcfs9a/iZH6sQ eTHFqxKTuW01NE5va4 X-Google-Smtp-Source: AGHT+IG+XNDdLvIHjDWrz7xBYNWynyjVwkhnneYUAaXVF1orqrHeVdrqwUGfJiVZQRW2LglRzOTRBQ== X-Received: by 2002:a05:600c:5286:b0:479:2a0b:180d with SMTP id 5b1f17b1804b1-47bd60152abmr72370455e9.11.1765981720725; Wed, 17 Dec 2025 06:28:40 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4310adeeedcsm5059934f8f.31.2025.12.17.06.28.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 06:28:40 -0800 (PST) Date: Wed, 17 Dec 2025 17:28:37 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Arvind Yadav Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Shashank Sharma Subject: drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:100 amdgpu_gem_update_bo_mapping() error: we previously assumed 'bo_va' could be null (see line 85) Message-ID: <202512131704.dhYp30j8-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a859eca0e4cc96f63ff125dbe5388d961558b0e9 commit: 70773bef4e091ff6d2a91e3dfb4f29013eb81f1f drm/amdgpu: update userqueue BOs and PDs config: s390-randconfig-r071-20251213 (https://download.01.org/0day-ci/archive/20251213/202512131704.dhYp30j8-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 10.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202512131704.dhYp30j8-lkp@intel.com/ smatch warnings: drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:100 amdgpu_gem_update_bo_mapping() error: we previously assumed 'bo_va' could be null (see line 85) vim +/bo_va +100 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c 70773bef4e091f Arvind Yadav 2024-09-25 76 static void 70773bef4e091f Arvind Yadav 2024-09-25 77 amdgpu_gem_update_bo_mapping(struct drm_file *filp, 70773bef4e091f Arvind Yadav 2024-09-25 78 struct amdgpu_bo_va *bo_va, 70773bef4e091f Arvind Yadav 2024-09-25 79 uint32_t operation, 70773bef4e091f Arvind Yadav 2024-09-25 80 uint64_t point, 70773bef4e091f Arvind Yadav 2024-09-25 81 struct dma_fence *fence, 70773bef4e091f Arvind Yadav 2024-09-25 82 struct drm_syncobj *syncobj, 70773bef4e091f Arvind Yadav 2024-09-25 83 struct dma_fence_chain *chain) 70773bef4e091f Arvind Yadav 2024-09-25 84 { 70773bef4e091f Arvind Yadav 2024-09-25 @85 struct amdgpu_bo *bo = bo_va ? bo_va->base.bo : NULL; bo_va can be NULL. 70773bef4e091f Arvind Yadav 2024-09-25 86 struct amdgpu_fpriv *fpriv = filp->driver_priv; 70773bef4e091f Arvind Yadav 2024-09-25 87 struct amdgpu_vm *vm = &fpriv->vm; 70773bef4e091f Arvind Yadav 2024-09-25 88 struct dma_fence *last_update; 70773bef4e091f Arvind Yadav 2024-09-25 89 70773bef4e091f Arvind Yadav 2024-09-25 90 if (!syncobj) 70773bef4e091f Arvind Yadav 2024-09-25 91 return; 70773bef4e091f Arvind Yadav 2024-09-25 92 70773bef4e091f Arvind Yadav 2024-09-25 93 /* Find the last update fence */ 70773bef4e091f Arvind Yadav 2024-09-25 94 switch (operation) { 70773bef4e091f Arvind Yadav 2024-09-25 95 case AMDGPU_VA_OP_MAP: 70773bef4e091f Arvind Yadav 2024-09-25 96 case AMDGPU_VA_OP_REPLACE: 70773bef4e091f Arvind Yadav 2024-09-25 97 if (bo && (bo->tbo.base.resv == vm->root.bo->tbo.base.resv)) 70773bef4e091f Arvind Yadav 2024-09-25 98 last_update = vm->last_update; 70773bef4e091f Arvind Yadav 2024-09-25 99 else 70773bef4e091f Arvind Yadav 2024-09-25 @100 last_update = bo_va->last_pt_update; Unchecked dereference. If "bo" is non-NULL we would know that bo_va is also non-NULL, but the fact that bo is possibly NULL makes us even more suspicious of bo_va. I reported this before and never got a response. https://lore.kernel.org/all/7074cf24-b136-44fc-a86d-4394d62c5242@stanley.mountain/ 70773bef4e091f Arvind Yadav 2024-09-25 101 break; 70773bef4e091f Arvind Yadav 2024-09-25 102 case AMDGPU_VA_OP_UNMAP: 70773bef4e091f Arvind Yadav 2024-09-25 103 case AMDGPU_VA_OP_CLEAR: 70773bef4e091f Arvind Yadav 2024-09-25 104 last_update = fence; 70773bef4e091f Arvind Yadav 2024-09-25 105 break; 70773bef4e091f Arvind Yadav 2024-09-25 106 default: 70773bef4e091f Arvind Yadav 2024-09-25 107 return; 70773bef4e091f Arvind Yadav 2024-09-25 108 } 70773bef4e091f Arvind Yadav 2024-09-25 109 70773bef4e091f Arvind Yadav 2024-09-25 110 /* Add fence to timeline */ 70773bef4e091f Arvind Yadav 2024-09-25 111 if (!point) 70773bef4e091f Arvind Yadav 2024-09-25 112 drm_syncobj_replace_fence(syncobj, last_update); 70773bef4e091f Arvind Yadav 2024-09-25 113 else 70773bef4e091f Arvind Yadav 2024-09-25 114 drm_syncobj_add_point(syncobj, chain, last_update, point); 70773bef4e091f Arvind Yadav 2024-09-25 115 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki