mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Swaraj Gaikwad <swarajgaikwad1925@gmail.com>
To: sam@ravnborg.org
Cc: Frank.Li@nxp.com, akpm@linux-foundation.org,
	david.hunter.linux@gmail.com, deller@gmx.de,
	donettom@linux.ibm.com, dri-devel@lists.freedesktop.org,
	hverkuil+cisco@kernel.org, kees@kernel.org,
	konrad.dybcio@oss.qualcomm.com, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, nicolas.dufresne@collabora.com,
	rongqianfeng@vivo.com, skhan@linuxfoundation.org,
	swarajgaikwad1925@gmail.com, vivek.kasireddy@intel.com,
	ydirson@free.fr, ziy@nvidia.com
Subject: Re: [PATCH v2] fbdev: arkfb: Request legacy VGA I/O region
Date: Sun, 14 Dec 2025 11:19:14 +0000	[thread overview]
Message-ID: <20251214111914.4976-1-swarajgaikwad1925@gmail.com> (raw)
In-Reply-To: <20251213223850.GA419250@ravnborg.org>

Hi Sam,

Thanks for the review.

You are right that the cast to (void __iomem *) makes it look like memory,
but the resource is explicitly initialized as I/O ports a few lines earlier:

    vga_res.flags = IORESOURCE_IO;

Since the resource flag is IORESOURCE_IO (targeting the legacy VGA ports),
I used devm_request_region() instead of devm_request_mem_region().

Best regards,
Swaraj

      reply	other threads:[~2025-12-14  5:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-13 20:22 Swaraj Gaikwad
2025-12-13 22:38 ` Sam Ravnborg
2025-12-14 11:19   ` Swaraj Gaikwad [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251214111914.4976-1-swarajgaikwad1925@gmail.com \
    --to=swarajgaikwad1925@gmail.com \
    --cc=Frank.Li@nxp.com \
    --cc=akpm@linux-foundation.org \
    --cc=david.hunter.linux@gmail.com \
    --cc=deller@gmx.de \
    --cc=donettom@linux.ibm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hverkuil+cisco@kernel.org \
    --cc=kees@kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.dufresne@collabora.com \
    --cc=rongqianfeng@vivo.com \
    --cc=sam@ravnborg.org \
    --cc=skhan@linuxfoundation.org \
    --cc=vivek.kasireddy@intel.com \
    --cc=ydirson@free.fr \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®