From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F103640855 for ; Sun, 14 Dec 2025 16:35:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765730147; cv=none; b=b/8TsgRxzpRraA5MxjPgwRP6yN0rmQash88eZfMYTcsPs5oWMyeO5AWuUN8r1H/IfqNUidejhsULMCSTqNHgBkTe4DvOpSVO+b1M/bz+IBNViFY2YxlKbPUOw3ufNp2rPYnWsonNWxO9WTlXvcHFbd/oCdPJKg9hQMukqsgADRw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765730147; c=relaxed/simple; bh=AilalJvyzrbLh//upEdwxFdU5Ag0Ak9V0tS0tcvk790=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=b2wH4KNCHcy58mMCQpkuNZlWlmTMUM29qG0LhyQ9JtYaKW7qk7b47ifDMP2D3pc7NgVZkAD/sa92jLAqHAIcJ7An0GLrNq2m/KtFibOS36z98kYpZFzW7OACBmGCZoHcerH0qjC+AyY0gQXVsJbEhy6iR7s4yUP96OfomeWs5rE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mVpOnH7g; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mVpOnH7g" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-59584301f0cso2834200e87.0 for ; Sun, 14 Dec 2025 08:35:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765730144; x=1766334944; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KW14eOIkaYwqJSzWMg8OOBiyNxtSIoZ6QzdhSZdq80k=; b=mVpOnH7g6J9fr4YTJH52ozVYSUdIRAlpIh7i1Pt0vu0mxTs7tzhEKerV5Cxrqg0miE sG1V+tR08gPXiafcwX1Lsn8Emy6WioDFBDnVXWZeNeDfiKDLRldLmaLlfY2yUI54wMC3 dqOIG6+xGh2Ag3v8oXva/9DZuRtcLCellAyDLVRTXI45PbpZx+0dWqVtBzpAvOnFmZ4l Pp4BmsNYw4XVOqGgyCor7fk8l4/Ks6qp24Bzp8YWQT/0bBtsFWBCm2o9IdfJvO787GOD HXyymaPe1cz4tNP/gH7pEPD9kr8u4IbUlyGvPnUVSt4qN6xEtdKB6vj6GHyIPq8yS3Iu /kew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765730144; x=1766334944; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KW14eOIkaYwqJSzWMg8OOBiyNxtSIoZ6QzdhSZdq80k=; b=u7C2OXn5h+F5wVqeYuH7ngmnBV0hSa1nVdpMCLWQEO6snxNO6o5zeahhOfcb9yOwsk zu7QIEIMkZl3r5PyCb6JrQ5fGbt7iESY3kjaOjIc5yezJ7R6eFwnZHArbnMe3FgIyoLI Wlcovsl2p+8dgnKg/s0ttsqPwMcKMXC4D2Y8k27SCAEyio2xy4b7XSrOzbxbPRW7Lr1p ND5bdJhjP8j+AeBLhknHrRa0mJF+m6gbGKbkBm2Xg6WWvdZFfjEgpL1UH1HYXvnXbFHR toJaLV4ByIJ5V+Xa3+RLG0dzpdbBQzLZNXifTSCQOwDtjjPH6rypdg8VLpgVM2PnYhmp jTaA== X-Forwarded-Encrypted: i=1; AJvYcCVClKAILEfYv7xXvsswX2aynPuAujaAn0PXRvimdNu95ytx8Byrz9I2rrDOLCPaZTp0l6S9d7PweYpQXgs=@vger.kernel.org X-Gm-Message-State: AOJu0Yxdv4GCMZ9AUSr3SMpQGHFCD6xX9L3mj1E7Jp+AOzNLWffwsvHw HLvhXwGASgVOhgqYw3P2QLcTJ/Y+pTXOQ5bcm6fDRGV2AoD+B2p+AGyQ X-Gm-Gg: AY/fxX6yFUYTNzsGrg2R/3iVw6LzWJL8yKDHwEP0Zqg8TWlAO2OL2P6hHhtaNjV+vxw Cp7hrS5r9K1aXKIt47dJHVWRTgqNkviVjsaUh3WbTw7Hmn3GXn3j16gRhciW5lJ1XXNKff4VkTq 1/v5WKmvHfNmMBhDcdyTS5v6ImDBG46MU2Z3EBOG0JnhCVfqWYONN6VqfvoC4PPNY2PRCpGxWvq ZKF4cDUuH91ekaLrYLp8BMUIqmVn+TjO2Q1prxqOJuMq8g+xoZuInLb+IGX5QOnSbe1VGrYIFHa NO4XdYnjhJI1M6IqGDIUH6IvduP07sOcvcg1mAVWsgQEDCPyKDTtf+ni9mDMX2t7D47XbcaOn7Q XvncGgSwpKrdOU3GiIN65lRdffOC4ZsaHulxKlmPZzSiQr3jDeBq/wu3MiOqJ82na7oM5AoEvdh flFQ== X-Google-Smtp-Source: AGHT+IF0fXC+uv8d2AkqLZUwN0Kj5Ka9OMORJEEFQOxcLCnJNaAOH3tMwrpqZgf74HUK7PX9yUcEbA== X-Received: by 2002:a05:6512:39ce:b0:595:7d40:df10 with SMTP id 2adb3069b0e04-598faa8effbmr2438191e87.40.1765730143778; Sun, 14 Dec 2025 08:35:43 -0800 (PST) Received: from curiosity ([5.188.167.4]) by smtp.googlemail.com with ESMTPSA id 2adb3069b0e04-598f7717b79sm3789618e87.60.2025.12.14.08.35.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Dec 2025 08:35:41 -0800 (PST) From: Sergey Matyukevich To: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Oleg Nesterov , Shuah Khan , Thomas Huth , Charlie Jenkins , Andy Chiu , Samuel Holland , Joel Granados , Conor Dooley , Yong-Xuan Wang , Heiko Stuebner , Guo Ren , Sergey Matyukevich Subject: [PATCH v5 0/9] riscv: vector: misc ptrace fixes for debug use-cases Date: Sun, 14 Dec 2025 19:35:04 +0300 Message-ID: <20251214163537.1054292-1-geomatsi@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series suggests fixes for several corner cases in the RISC-V vector ptrace implementation: - init vector context with proper vlenb, to avoid reading zero vlenb by an early attached debugger - follow gdbserver expectations and return ENODATA instead of EINVAL if vector extension is supported but not yet activated for the traced process - validate input vector csr registers in ptrace, to maintain an accurate view of the tracee's vector context across multiple halt/resume debug cycles For detailed description see the appropriate commit messages. A new test suite validate_v_ptrace is added to the tools/testing/selftests/riscv/vector to verify some of the vector ptrace functionality and corner cases. So far tested on the following platforms: - test in QEMU rv32/rv64 - test on c908 (BananaPi CanMV K230D Zero) - test on c906 (MangoPi MQ Pro) Previous versions: - v4: https://lore.kernel.org/linux-riscv/20251108194207.1257866-1-geomatsi@gmail.com/T/#u - v3: https://lore.kernel.org/linux-riscv/20251025210655.43099-1-geomatsi@gmail.com/T/#u - v2: https://lore.kernel.org/linux-riscv/20250821173957.563472-1-geomatsi@gmail.com/T/#u - v1: https://lore.kernel.org/linux-riscv/20251007115840.2320557-1-geomatsi@gmail.com/T/#u Changes in v5: - add support and minimal set of tests for XTheadVector Changes in v4: The form 'vsetvli x0, x0, ...' can only be used if VLMAX remains unchanged, see spec 6.2. This condition was not met by the initial values in the selftests w.r.t. the initial zeroed context. QEMU accepted such values, but actual hardware (c908, BananaPi CanMV Zero board) did not, setting vill. So fix the selftests after testing on hardware: - replace 'vsetvli x0, x0, ...' by 'vsetvli rd, x0, ...' - fixed instruction returns VLMAX, so use it in checks as well - replace fixed vlenb == 16 in the syscall test Changes in v3: Address the review comments by Andy Chiu and rework the approach: - drop forced vector context save entirely - perform strict validation of vector csr regs in ptrace Changes in v2: - add thread_info flag to allow to force vector context save - force vector context save after vector ptrace to ensure valid vector context in the next ptrace operations - force vector context save on the first context switch after vector context init to get proper vlenb --- Ilya Mamay (1): riscv: ptrace: return ENODATA for inactive vector extension Sergey Matyukevich (8): riscv: vector: init vector context with proper vlenb riscv: csr: define vtype register elements riscv: ptrace: validate input vector csr registers selftests: riscv: test ptrace vector interface selftests: riscv: verify initial vector state with ptrace selftests: riscv: verify syscalls discard vector context selftests: riscv: verify ptrace rejects invalid vector csr inputs selftests: riscv: verify ptrace accepts valid vector csr values arch/riscv/include/asm/csr.h | 17 + arch/riscv/kernel/ptrace.c | 98 +- arch/riscv/kernel/vector.c | 12 +- .../testing/selftests/riscv/vector/.gitignore | 2 + tools/testing/selftests/riscv/vector/Makefile | 10 +- .../selftests/riscv/vector/v_helpers.c | 23 + .../selftests/riscv/vector/v_helpers.h | 2 + .../riscv/vector/validate_v_ptrace.c | 919 ++++++++++++++++++ 8 files changed, 1075 insertions(+), 8 deletions(-) create mode 100644 tools/testing/selftests/riscv/vector/validate_v_ptrace.c base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 -- 2.52.0