From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEF06332EC3 for ; Mon, 15 Dec 2025 12:46:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765802788; cv=none; b=IYwSvSsaC1/h3YFWkqk0J8VF6PbGVK9k2aXrgTAMy8hMh/RIVsY4PzTKe8qhoZaZ+05puixm2Q1EQmR5e0K8ZZ9fnjClht+UpfrVgSuN68M2TJpH0bd/DVslIPLxHqsHF5SI8TwPuLurjscYohpZLYUUAUTSE2h/4Jp6sQ+Nwcc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765802788; c=relaxed/simple; bh=VHZNWEa9BNR2eoKefEkLKf3P0SU7eO5ScT4xqjEBFeE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jxkbTF1Yux44CoOnaLDBsBDqvBbWPSKBFTp8efkIqrACRLsHl1KtIkyBp4BNWk0JUAQswwaC31pE2jS4GjN18XfpLDfe0cUYCxPOfcXix/dIQDPx6jnq9yBb4+Dm1FJ5hWODVVEgIhhLrwDSe9tpvYWAzYcDoimCTUYv768Nlu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=o02dzuCE; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="o02dzuCE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1765802784; bh=VHZNWEa9BNR2eoKefEkLKf3P0SU7eO5ScT4xqjEBFeE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=o02dzuCEgC8HYmeAUXCnw4OeWLB3jc9m/ITP6lFMapaPTKctF4Bx98zkVMuamV1Lq JgiH/2aGKTXrPZroseUmWsaKhb/EHgeEdL3S9LgIjDwqaHteygkZeBNY+Nk+YoVlFu IsHjgX/XSkzt9tsZ0je/VqEZmrf9qUQBOUpHR9oFyTM/IsdQYjjPEcuCjDzeEoeYMH PxpaGNmzIhzy9CTrWFx7J2LonJfyxSdNz1ZJ0/OM0ZqMiSQ350AJTYSrWK2Bq0Sw7V 3xltWpkthBKb5xojfSMXBZNKK8eEPo2zN64iI63BLGU68RmBuligAqXOUFIOpYnM54 8dil5wn0nzaIw== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 6909417E1155; Mon, 15 Dec 2025 13:46:24 +0100 (CET) Date: Mon, 15 Dec 2025 13:46:18 +0100 From: Boris Brezillon To: Lukas Zapolskas Cc: Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , nd@arm.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 4/5] drm/panthor: Propagate VM-level faults to groups Message-ID: <20251215134618.22e92624@fedora> In-Reply-To: <20251215115457.2137485-5-lukas.zapolskas@arm.com> References: <20251215115457.2137485-1-lukas.zapolskas@arm.com> <20251215115457.2137485-5-lukas.zapolskas@arm.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 15 Dec 2025 11:54:56 +0000 Lukas Zapolskas wrote: > group->task_info.pid, group->task_info.comm); > > group->fatal_queues |= BIT(cs_id); > + > + if (panthor_vm_has_unhandled_faults(group->vm)) { > + struct panthor_vm_fault *fault; > + > + fault = panthor_vm_get_fault(group->vm); > + if (fault) > + group->fatal = *fault; group->vm can't be NULL, meaning fault can't be NULL either. > + } > }