From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011023.outbound.protection.outlook.com [40.93.194.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8B937494 for ; Mon, 15 Dec 2025 21:12:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.23 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765833181; cv=fail; b=ajDnD4tKrXQ/yL3mEbWizPFUs+zPuHGG4uk4kvrzilROe0IsgreV/VxY3kggPeS4fmR/KT5kaH2Xzo/SmANugFqJQbJrGaNQtYHyAqwR5U2BYr/TaHmqSzStM1wjCvQMUfA1EpCIQGUiEUaPYdBqHUB1CB4E4jDqkd/+ECI5CrE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765833181; c=relaxed/simple; bh=QULg3YbLZJ+5jm6E84SSLK18qwiqrdqBXv7KXQilASA=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=LeYDZYM5pbDBNofOPul6OxxRmUr+BVvJeXOzcWFTb8vclFc0dEzMUjZEK+ZkDFcN0jtbltsMxHLey3sZa8IFZBGs0817MGyjwjVZ7Y66nTb0K1gZ8z3RvWdyXAUzL5fRuiW/evcTWqBmVyj92goiT4rHegL3Kwt08EqXs2ODWH8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Cs7CMS5F; arc=fail smtp.client-ip=40.93.194.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Cs7CMS5F" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D5IzRbZhRcqqU4snATe821d9vJAlLzTHvwo2avHCy6NTrTN4tabtA+TKjFflFRMvVcWwEW2v2sNXbKx/k5hKOWCFXjs+z+CtmmYG5tNM6drEhvvinGAP0DuFQIPnQ0aM/DaNo1iX4P726rg6eZG+twvzLVMMyx8WC2sUHoPjoC9FO9BZdELL5h0aJrUwUdQ+MnWPSy+AQB/sp+eBSxVRfUsb8v/3VjPKLRj+ZC/JlCYd0yCNC88pHBxrCSLTGfhfYXavqn9pEJLxLau0Hq9u9rmmBzLSwznwTeutWEKrREvVZ2P5oH25DeUNhfg4xBf+sq9Meqq/OKuUtHbbvRfVhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8WmvE/aCsBn90r9HTwUFgahjJmHb2uApNqEO9zfh/uY=; b=BISSQzWcwMKBWF6s/S4RgyJ+yYDKOuze0fREMFhFw+7bK3f/3hYFRufqgXik5FDNIvUYoAilBMZArzrF/HG4lLiV70TUbKsO2X9y694TbSY2GCiJ2kl9GyvGtccBBk6QI6HkdiNG52Q2xnu9q+4J9Jz53POMHIAsigb8cknIIIMLMJSMWbyJcOzzdZbeT0dwksqjCl2JHLCx/p1GdTG6QZWq/X4QwnO9zMg6DIgiMv+cVeyoU84vNFJ+t/JNS+4WXZohl2RHdTExDZGAqqw5mcQpD1Pb/HZZlyhm/kIDUXwweFU7HtutWdSjD0/zT/5frAMaO0o3r7FULYeFfvaRMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8WmvE/aCsBn90r9HTwUFgahjJmHb2uApNqEO9zfh/uY=; b=Cs7CMS5FY3qLoOuXCGQxtSNS6g36rAWzvjkD8rb/X6E8fXWyyDLLKrptGcTJrP56aiUa+yqrhSbFO6t+nQtdX/xLvPdnWD60dBWAylEe/GrcuRmfaKAKirE2t4A9lgBudhxuMzfI3q9bWhTaPdTwD/yWqOOE77kUavq+owDCEgM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB6373.namprd12.prod.outlook.com (2603:10b6:8:a4::7) by CH3PR12MB8188.namprd12.prod.outlook.com (2603:10b6:610:120::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Mon, 15 Dec 2025 21:12:57 +0000 Received: from DM4PR12MB6373.namprd12.prod.outlook.com ([fe80::12f7:eff:380b:589f]) by DM4PR12MB6373.namprd12.prod.outlook.com ([fe80::12f7:eff:380b:589f%6]) with mapi id 15.20.9412.011; Mon, 15 Dec 2025 21:12:57 +0000 Date: Mon, 15 Dec 2025 16:12:53 -0500 From: Yazen Ghannam To: "Mario Limonciello (AMD)" Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Jean Delvare , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] firmware: dmi: Adjust dmi_decode() to use enums Message-ID: <20251215211253.GB355290@yaz-khff2.amd.com> References: <20251214185309.152614-1-superm1@kernel.org> <20251214185309.152614-3-superm1@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251214185309.152614-3-superm1@kernel.org> X-ClientProxiedBy: BN9PR03CA0114.namprd03.prod.outlook.com (2603:10b6:408:fd::29) To DM4PR12MB6373.namprd12.prod.outlook.com (2603:10b6:8:a4::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB6373:EE_|CH3PR12MB8188:EE_ X-MS-Office365-Filtering-Correlation-Id: 0674fda6-c236-4c35-bf97-08de3c1eb847 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?X6SlnHxh/nBdfyEEkY8u5dDP33w5bUPxolOpszkwBDqcDGpINwD6SnMqmt4y?= =?us-ascii?Q?YfoMXI8PARDA+BOg2H4gRtaizgkdquFMVZqniRYdbwBdsceBgEFIgRxxPSJo?= =?us-ascii?Q?x2L18xzTv68dE3E0uYMQXKv+EC9z6fgTO4xatqOgO2FTRz52I2z03nUxorhL?= =?us-ascii?Q?OluORZmCKmYG+OmXYmQZs3QRTmgJprlBJ7tjxmeR+ssQqqho4niz4Qwz3cjo?= =?us-ascii?Q?6FHrO2TsEhQZf1YFa8iGXFNUDLJqO3uGWoTbnMKOaG11A9sVWo3cjrjU6NlQ?= =?us-ascii?Q?34zLbjmm7CtjzVuE38SEO25eleM3thoHVFI7J1JheRdqhIjCZueCZHtRGQWj?= =?us-ascii?Q?fWj5rLnWFlZqC0uf9Xt1UFGN411GgzZBSqBCMO+lnxoObLwCnXl11s0jLKAi?= =?us-ascii?Q?vneaG3Uqn/QOkkQ9/+eZyNHjbIl80hCgFCsOd4mVqaInTYrC6gae0JX3em8f?= =?us-ascii?Q?Y4GrnTWfxsVr+2zt0IxLHJ1h5Em7gON/ePaVCyt3dWOKraTo3hquOVDGbevU?= =?us-ascii?Q?7J3Gg+eyJ8LI5bRPTNXmoDf0nkvNFeGHGtC9OMcNKuZTca3n1s1AMfUPHi9H?= =?us-ascii?Q?VWfAR9MDszRrmahUX133dbI7uo+fOJdll/Zta56xzwR3OilSMFbVPvZ31SuZ?= =?us-ascii?Q?+VUw8GXYw4pQ+a8P4mNMximKmgdXMwfr8y0rxLsnDrPL/ATHuWMm2V2WDEJs?= =?us-ascii?Q?Av8lcQwIbv7FJMVN/9nbaWQ8rkSGYV1cGX+bz1bZuAGRBu36QGSaqZ3keyhv?= =?us-ascii?Q?5vC03rlViotXUGEa/ifUO5M3nEX6tWnu2jr7s5jPxrnvJ1QxBM3UTs0JgvRe?= =?us-ascii?Q?kEGJY9mZfWd7BOq5ip47uUSBQmOY8ZbVHmKULD54EVqU5vmBL43HxVKxoRjw?= =?us-ascii?Q?4fND68hehAkJjUlZRsnbqKDuNGQiZiBCe9SdTk9JG8PdFfv2/Tsq3t0TKvJm?= =?us-ascii?Q?Gir/R3kiHnYECDSPZu/hLfTX0X9S4gwg/NRd3oK2gSh1CFVQdjpdIMO9ihee?= =?us-ascii?Q?yeMdFl44nLqryZURCu3boG66URDvR1zhZhHN8DW20lYvmzUKoiT1wawnWKpU?= =?us-ascii?Q?Cv9bocmOO5BbLnOeFCHt3MJ8sYgQF5NPsLTKmuD73kZzisSskDJ97XmBPaxB?= =?us-ascii?Q?f+RGefSxuk/WTlDk0shubGExpAO6K157Ax+JWumngIwgPurS9WTWdLDiaZaP?= =?us-ascii?Q?EFu84tc9VpllH7RYBVgrKImC8VasvK4WrOAr5P78h4BMDTdTeKpJDl4+7MiB?= =?us-ascii?Q?K1zhWtw+oeFtXjImRxwqkwYbyPgIGOtJLMfRBINv9Re2IY11BK3VhIlA2SRF?= =?us-ascii?Q?jRNlvGpuhEX2QjS6oVtfbHmYx0CWDQfXEApVrdRgVGKfrhTbOLBVN7vlbzCo?= =?us-ascii?Q?S4a6p0oAdTCFi2fwwk7rjb6jdCQKIfO7hUskz1ulSruyyukAxLOjptvBlyCk?= =?us-ascii?Q?pRlQeqN5eWvkK887dtL0vAmpW/tdXpYA?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB6373.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Pexoekl/pVKktk/jGxXEBjeP8WD5IocZnwjfA1dFgU9Wlr49xTw2Psbhl/rz?= =?us-ascii?Q?xM9Vh/mLm2Sq6QcEjOhHU/7ouLuHHUAESdANQgQA/by3Sx8w5zCXEaKDGNTN?= =?us-ascii?Q?yYdv0DDHKMdsVV9+gFLbx5ne8lsCN+qmsuB+Wr0M6e8XCuvxU8f2M6kPcQ+o?= =?us-ascii?Q?Gf2WOWV0TxfcSZ18uoiKPcEkAMF+FO5DUWB0hUdlxi4wDQrSyJOU++PSIpyk?= =?us-ascii?Q?aUeuCNAs1sfE319JxHcyMolT+hGHyMxCv1zIQwg1JUQ9v38L1gc/09vWPojY?= =?us-ascii?Q?7SA8HrwoArTOvsdhV+m7AP1KGqzyPqEgMbM3IYa/UT5raNhvu1dne4B4cCIp?= =?us-ascii?Q?DbiVW9yrGklgcS8krQxyo/ft7EtG8MYqDslXADp6byjEdQIiQFG87TaSMxGD?= =?us-ascii?Q?9g8/cr4TusxquqpzNulkJjYALMPlAL0XkdlUauqYmn3xyO0q+KLH5N9HaSY6?= =?us-ascii?Q?F+eV5Rous++7l20/67PDVNu7bYZGV3usBLjECGosMlrNirpPFFMX9iVOGV6+?= =?us-ascii?Q?s1MCG17gK+VnxMR62x+Wmujyfux/JGJ2ob4YkFOs6pXM3SM2c9vUGYyFP4Yj?= =?us-ascii?Q?QlVMG73A9uN6IBTUIIe3AvsUcUk++1z1kscj97JQITSuEnGuUI6uq6/WvntH?= =?us-ascii?Q?a/J+vE5B0YHF3r/nOYye6BBATRe66VMjbVetXGD73mjCOuMNRM0qONDCfyHP?= =?us-ascii?Q?iAwx4WI8ITOl83p3+dimIrg9zyfcrtOinX4NZTW/PUePhE67+gbRbKIDB2a9?= =?us-ascii?Q?x0JR1z32xmmJf5mAZpn1SOnLYtxkoHiOOI3GxCiY9iVZA/5HT6AnSk+T6voB?= =?us-ascii?Q?k+NLwtz0ByrszEXLCiJHo804dwddLLI8YbjwU4RbFAVFj5bNZLGqeaUT9Wz4?= =?us-ascii?Q?Jt/MCpcBSazoP3MwIUU228UBEYAYRE/wKed3JJm6sDEXpmRYZgVpwwr02k89?= =?us-ascii?Q?YfDv6qZuXGVy5/BeF3qejFv2VOQtCPlUDqXZMaIBNW3VatBoGxNNtG5iYauF?= =?us-ascii?Q?DuXdX5vm652AJNQouD4QKrpE7nIUd/+7Lwx4VxMB0sROOBgcO5UiaV5hsORi?= =?us-ascii?Q?bZGYowlmC+CbV7kCM6AaL40V2zbYr3CvbNJMNCYQdWdx45lPo9aTQP/eYt15?= =?us-ascii?Q?ga7mRPcwUwXy1/LZnNFNmBx6rUajsoMDIHSMVAA0Dac/8YUu5JkSpADtb08v?= =?us-ascii?Q?zr3XZfJX6J+4+9/zszBhn7s4ZKvJe9akNpsRHGqFubxYdM1G5v+dq+VFLP5J?= =?us-ascii?Q?OUc/8hWSryelA2ieD64KJk0OPlIT1eaqrEeQrKoQ1Yodt3/zxkwW7k77dZPf?= =?us-ascii?Q?7jOgwLKwrCR3J5Q1furCRDOzFwKIAlKx9shIs86xJS9Elia8EQKX81niczUu?= =?us-ascii?Q?nwLl2UV7+jC7MFIwXKY4RaNvaJ22KiMfxoVw9GevF4teQD7g2F8ZhNtRtUqM?= =?us-ascii?Q?aRN17UeO22WLRB+YvovlklQ6j0C0mw6gZAJ6s35Artx8p4G8tx0ILt3ZTFpa?= =?us-ascii?Q?m+Tphng2vln7j4jYFJ7P2KcMg8KxMZy1dGXES1FsS/aa41iNJxSC0KBhoked?= =?us-ascii?Q?VumEPsdiERuEobp1l78YGIgPkalITa2W4fwjcmH/?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0674fda6-c236-4c35-bf97-08de3c1eb847 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2025 21:12:57.3690 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Nig1/R1MBgLdva8P/X0t3B4LZlKhjJp60jlORJWjVZ/J2cixOTEhjZUDAGZHLFWojpiRLYByZWkT5mnNfszxQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8188 On Sun, Dec 14, 2025 at 12:53:06PM -0600, Mario Limonciello (AMD) wrote: > dmi_decode() has hardcoded values with comments for each DMI entry > type. The same information is already in dmi.h though, so drop the > comments and use the definitions instead. > > Signed-off-by: Mario Limonciello (AMD) Reviewed-by: Yazen Ghannam Thanks, Yazen