From: "Rob Herring (Arm)" <robh@kernel.org>
To: soc@kernel.org, Khuong Dinh <khuong@os.amperecomputing.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] arm64: dts: apm/shadowcat: More clock clean-ups
Date: Tue, 16 Dec 2025 14:27:48 -0600 [thread overview]
Message-ID: <20251216-dt-apm-v1-1-0bf2bf8b982c@kernel.org> (raw)
In-Reply-To: <20251216-dt-apm-v1-0-0bf2bf8b982c@kernel.org>
A fixed-factor-clock only provides 1 clock, so "#clock-cells" must be 0.
The "snps,designware-i2c" node is not a clock provider, so drop
"#clock-cells.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
index 5bbedb0a7107..032d37a32193 100644
--- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
@@ -295,7 +295,7 @@ socpll: socpll@17000120 {
socplldiv2: socplldiv2 {
compatible = "fixed-factor-clock";
- #clock-cells = <1>;
+ #clock-cells = <0>;
clocks = <&socpll 0>;
clock-mult = <1>;
clock-div = <2>;
@@ -305,7 +305,7 @@ socplldiv2: socplldiv2 {
ahbclk: ahbclk@17000000 {
compatible = "apm,xgene-device-clock";
#clock-cells = <1>;
- clocks = <&socplldiv2 0>;
+ clocks = <&socplldiv2>;
reg = <0x0 0x17000000 0x0 0x2000>;
reg-names = "div-reg";
divider-offset = <0x164>;
@@ -329,7 +329,7 @@ sbapbclk: sbapbclk@1704c000 {
sdioclk: sdioclk@1f2ac000 {
compatible = "apm,xgene-device-clock";
#clock-cells = <1>;
- clocks = <&socplldiv2 0>;
+ clocks = <&socplldiv2>;
reg = <0x0 0x1f2ac000 0x0 0x1000
0x0 0x17000000 0x0 0x2000>;
reg-names = "csr-reg", "div-reg";
@@ -346,7 +346,7 @@ sdioclk: sdioclk@1f2ac000 {
pcie0clk: pcie0clk@1f2bc000 {
compatible = "apm,xgene-device-clock";
#clock-cells = <1>;
- clocks = <&socplldiv2 0>;
+ clocks = <&socplldiv2>;
reg = <0x0 0x1f2bc000 0x0 0x1000>;
reg-names = "csr-reg";
clock-output-names = "pcie0clk";
@@ -355,7 +355,7 @@ pcie0clk: pcie0clk@1f2bc000 {
pcie1clk: pcie1clk@1f2cc000 {
compatible = "apm,xgene-device-clock";
#clock-cells = <1>;
- clocks = <&socplldiv2 0>;
+ clocks = <&socplldiv2>;
reg = <0x0 0x1f2cc000 0x0 0x1000>;
reg-names = "csr-reg";
clock-output-names = "pcie1clk";
@@ -364,7 +364,7 @@ pcie1clk: pcie1clk@1f2cc000 {
xge0clk: xge0clk@1f61c000 {
compatible = "apm,xgene-device-clock";
#clock-cells = <1>;
- clocks = <&socplldiv2 0>;
+ clocks = <&socplldiv2>;
reg = <0x0 0x1f61c000 0x0 0x1000>;
reg-names = "csr-reg";
enable-mask = <0x3>;
@@ -375,7 +375,7 @@ xge0clk: xge0clk@1f61c000 {
xge1clk: xge1clk@1f62c000 {
compatible = "apm,xgene-device-clock";
#clock-cells = <1>;
- clocks = <&socplldiv2 0>;
+ clocks = <&socplldiv2>;
reg = <0x0 0x1f62c000 0x0 0x1000>;
reg-names = "csr-reg";
enable-mask = <0x3>;
@@ -386,7 +386,7 @@ xge1clk: xge1clk@1f62c000 {
rngpkaclk: rngpkaclk@17000000 {
compatible = "apm,xgene-device-clock";
#clock-cells = <1>;
- clocks = <&socplldiv2 0>;
+ clocks = <&socplldiv2>;
reg = <0x0 0x17000000 0x0 0x2000>;
reg-names = "csr-reg";
csr-offset = <0xc>;
@@ -799,7 +799,6 @@ i2c1: i2c@10511000 {
compatible = "snps,designware-i2c";
reg = <0x0 0x10511000 0x0 0x1000>;
interrupts = <0 0x45 0x4>;
- #clock-cells = <1>;
clocks = <&sbapbclk 0>;
};
--
2.51.0
next prev parent reply other threads:[~2025-12-16 20:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 20:27 [PATCH 0/4] arm64: dts: apm: Fix remaining warnings Rob Herring (Arm)
2025-12-16 20:27 ` Rob Herring (Arm) [this message]
2025-12-16 20:27 ` [PATCH 2/4] arm64: dts: apm: Use recommended i2c node names Rob Herring (Arm)
2025-12-16 20:27 ` [PATCH 3/4] arm64: dts: apm: Add "reg" to "syscon-reboot" and "syscon-poweroff" Rob Herring (Arm)
2025-12-16 20:27 ` [PATCH 4/4] arm64: dts: apm: Drop "dma" device_type Rob Herring (Arm)
2025-12-22 10:05 ` [PATCH 0/4] arm64: dts: apm: Fix remaining warnings Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251216-dt-apm-v1-1-0bf2bf8b982c@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khuong@os.amperecomputing.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®