From: Matthew Maurer <mmaurer@google.com>
To: "Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Maurer <mmaurer@google.com>
Subject: [PATCH v2 1/3] rust: transmute: Support transmuting slices of AsBytes/FromBytes types
Date: Tue, 16 Dec 2025 00:44:41 +0000 [thread overview]
Message-ID: <20251216-transmute-v2-1-b23e5277ad02@google.com> (raw)
In-Reply-To: <20251216-transmute-v2-0-b23e5277ad02@google.com>
Currently, we support either transmuting a byte slice of the exact size
of the target type or a single element from a prefix of a byte slice.
This adds support for transmuting from a byte slice to a slice of
elements, assuming appropriate traits are implemented.
Signed-off-by: Matthew Maurer <mmaurer@google.com>
---
rust/kernel/transmute.rs | 72 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 72 insertions(+)
diff --git a/rust/kernel/transmute.rs b/rust/kernel/transmute.rs
index be5dbf3829e25c92f85083cc0f4940f35bb7baec..5cc5f4fde4c31cea3c51ab078b4d68f3a0a2caa1 100644
--- a/rust/kernel/transmute.rs
+++ b/rust/kernel/transmute.rs
@@ -122,6 +122,78 @@ fn from_bytes_mut_prefix(bytes: &mut [u8]) -> Option<(&mut Self, &mut [u8])>
}
}
+ /// Converts a slice of bytes to a slice of `Self`.
+ ///
+ /// Succeeds if the reference is properly aligned, and the size of `bytes` is a multiple of that
+ /// of `Self`.
+ ///
+ /// Otherwise, returns [`None`].
+ fn from_bytes_to_slice(bytes: &[u8]) -> Option<&[Self]>
+ where
+ Self: Sized,
+ {
+ let size = size_of::<Self>();
+ if size == 0 {
+ return None;
+ }
+ if bytes.len() % size != 0 {
+ return None;
+ }
+ let len = bytes.len() / size;
+ let ptr = bytes.as_ptr().cast::<Self>();
+
+ #[allow(clippy::incompatible_msrv)]
+ if ptr.is_aligned() {
+ // SAFETY:
+ // - `ptr` is valid for reads of `bytes.len()` bytes, which is
+ // `len * size_of::<Self>()`.
+ // - `ptr` is aligned for `Self`.
+ // - `ptr` points to `len` consecutive properly initialized values of type `Self`
+ // because `Self` implements `FromBytes` (any bit pattern is valid).
+ // - The lifetime of the returned slice is bound to the input `bytes`.
+ unsafe { Some(core::slice::from_raw_parts(ptr, len)) }
+ } else {
+ None
+ }
+ }
+
+ /// Converts a mutable slice of bytes to a mutable slice of `Self`.
+ ///
+ /// Succeeds if the reference is properly aligned, and the size of `bytes` is a multiple of that
+ /// of `Self`.
+ ///
+ /// Otherwise, returns [`None`].
+ fn from_bytes_to_mut_slice(bytes: &mut [u8]) -> Option<&mut [Self]>
+ where
+ Self: AsBytes + Sized,
+ {
+ let size = size_of::<Self>();
+ if size == 0 {
+ return None;
+ }
+ if bytes.len() % size != 0 {
+ return None;
+ }
+ let len = bytes.len() / size;
+ let ptr = bytes.as_mut_ptr().cast::<Self>();
+
+ #[allow(clippy::incompatible_msrv)]
+ if ptr.is_aligned() {
+ // SAFETY:
+ // - `ptr` is valid for reads and writes of `bytes.len()` bytes, which is
+ // `len * size_of::<Self>()`.
+ // - `ptr` is aligned for `Self`.
+ // - `ptr` points to `len` consecutive properly initialized values of type `Self`
+ // because `Self` implements `FromBytes`.
+ // - `AsBytes` guarantees that writing a new `Self` to the resulting slice can safely
+ // be reflected as bytes in the original slice.
+ // - The lifetime of the returned slice is bound to the input `bytes`.
+ unsafe { Some(core::slice::from_raw_parts_mut(ptr, len)) }
+ } else {
+ None
+ }
+ }
+
/// Creates an owned instance of `Self` by copying `bytes`.
///
/// Unlike [`FromBytes::from_bytes`], which requires aligned input, this method can be used on
--
2.52.0.305.g3fc767764a-goog
next prev parent reply other threads:[~2025-12-16 0:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 0:44 [PATCH v2 0/3] Support more safe `AsBytes`/`FromBytes` usage Matthew Maurer
2025-12-16 0:44 ` Matthew Maurer [this message]
2025-12-17 16:51 ` [PATCH v2 1/3] rust: transmute: Support transmuting slices of AsBytes/FromBytes types Daniel Almeida
2025-12-26 20:27 ` Matthew Maurer
2025-12-16 0:44 ` [PATCH v2 2/3] rust: Add support for deriving `AsBytes` and `FromBytes` Matthew Maurer
2025-12-17 3:12 ` Alexandre Courbot
2025-12-17 18:01 ` Matthew Maurer
2025-12-17 19:14 ` Daniel Almeida
2025-12-18 7:23 ` Alexandre Courbot
2025-12-18 8:26 ` Alice Ryhl
2025-12-17 17:35 ` Daniel Almeida
2025-12-17 17:57 ` Matthew Maurer
2025-12-17 19:11 ` Daniel Almeida
2025-12-16 0:44 ` [PATCH v2 3/3] rust: Support deriving `AsBytes`/`FromBytes` on bindgen types Matthew Maurer
2025-12-17 3:15 ` Alexandre Courbot
2025-12-17 18:26 ` Matthew Maurer
2025-12-17 19:26 ` Daniel Almeida
2025-12-17 19:33 ` Matthew Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251216-transmute-v2-1-b23e5277ad02@google.com \
--to=mmaurer@google.com \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®