From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FE9F325483 for ; Tue, 16 Dec 2025 05:38:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765863546; cv=none; b=XcP8LrhovT0/kiYWbH8Z7Q3cdkoWUXMbVYUE6+ma9PyDopOA0/7DzvJZObZyUFmSq3EVYrUjo6DYrke9InEHU9achL6P3I6u0d63tsGJOX8dIbFvFLH1qd/1bp9atkomKSsHdO+JDKSPnnRjaNDUp793q62CGVP9oWvQ8dZN1LI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765863546; c=relaxed/simple; bh=nPwZeRF8kFiRZ4JZtZ+XdnRVfVOx5xWBQL81W6Ea19E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=qr3K4oXUv3D6bzcStYdgSW6DUaPxzQsE0OCJbYWHG0BN7/JJkzc+Qjqu3JTGjv8hStb0K8ouIQoKDZ8xR4N986nF5X5etPQS5IheLNV7UeGxebqLzCLhEOizlbaI9VdLtdmFNnoAquwQJK6/504T4xHja6knEaTkYozN7kcmuDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PtlojLaO; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PtlojLaO" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-7fbbb84f034so195865b3a.0 for ; Mon, 15 Dec 2025 21:38:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765863486; x=1766468286; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Lq6x4ZckbeqrbhHEXGhyVB+TxyOJHgz3NTmoMTsb4iA=; b=PtlojLaO2M9GfoC2lb5xf0jrtWK8nM54WGJ9LhzyDHBtiUjP++ZSnhU/mqD9uZhjDR 0FW2RysaL72fsT9K1+IOp8NXoFXlbXz35L5l2YGAguaDPp8se7b1H7wXUQTwvNgv/wGc IYpLe7Rzzxn1hjyoGEndATMYMp2SFN4l1TIBY08KKWPjVzupq+wZT8bzBpTrtuOZD8Oj zBEDa5vAZG/dqK6Ro/eo+K0BPYKh+8jVd6IeeaTLmMKD7surV9qS+PnDv555Tz9Uhreo PsPLcY4vk4ZKmsHk0So3mXb/vCKlJioeyxB/J3Kf53TgAuC6wu3HyElnML9lGRFpnxph JZPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765863486; x=1766468286; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Lq6x4ZckbeqrbhHEXGhyVB+TxyOJHgz3NTmoMTsb4iA=; b=pSjR6fUldzzdvDG7FAtDDE3ZeqLTsNo7d9LQsXryRbi2MkTIgKnrnGFxrncdV+S3Ig 0kN0cKEkHsRVrZ9WAl28tPM7W/nvytRI3S56QWTVxcslnsmyAWK+xA/JHpFQeVeV830b Nn/50wOoWdeZzj0VieHKqR52cEsMjZyMGYjCmmM3ZrN9+51w0t3uxiGvwDlvhwaZqsIY +gY2WPTQACNGC/13C4Sjv4z8/goWzAwVulyzhGdDE95PjB5jcD3z5bH4IL9/XtFCyf3m jTjRtiKVpVnTbXy4HnkXT3q+ucTw+f4B2RToeCJH5lkv+6/iYL7wcWy4GBmSAy7JxNBe 4iCg== X-Forwarded-Encrypted: i=1; AJvYcCWmd59YgDrG7azy13pp0DsZRaYIx81A0HKcbS0rF+MPK3035wOFrTxYK+Qx8IksJv53Rj4fogCKnX5Slqc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0QQyTp/b7NVD19qSBi51C3VWKzMuucXkapOv0JUk7E2y2cc2V KNSFVwxHAMC3/ovn6E+3DVy7KMzNy/qcuYDh5heNwZH5Co1gj28QBuez X-Gm-Gg: AY/fxX6RpnMNgCtAY8+z8u3bYxiCskzCN3eyvtDlO3/H5SDbaXN5VH8UeB50vuYHk79 m4izyzG/1wVa/YtoJ+iql4f1dT74XESb3ZqJbfFe0q+hn4V6d41G99814MLkQptV6h+7vaWYc55 RSdldJIMpwqtt2t5JK9ykdSzTJWhqsnGQ8iE0fndBI14V/MY24qcBHqY62zx7lJ5mCNcZTW4rsd Sn7D2GSiNUlTIgng8j/GVD1kP0Ok0FvB1SxBO5X1zCycori4LURG80ede/EAkgMpvhCTgNyvaJY sa10dOaZsUFQ/vIzUfjWflUMkFGUbTj1qWsZQpiPnbUi5Y3rSVrUyU9ZowwD8leMotobnonggbD 2Y1jHFyWrEvvamD9xmXaqtVy7svKDwziHCBvVcshun3nKrw7dz3xnxXBcMss/25QMx9TcXxEUJC gAXeX66YTqNowi6eDKALIehXl3sIyT9sqw X-Google-Smtp-Source: AGHT+IG12c9fYbZGP9nOykXqnzJS+pDmbFLiaSwmm91NRjpscDAFfbr7riNDEmWv3BSjL0w8rp9lSQ== X-Received: by 2002:a05:6a00:420d:b0:7e8:4471:8d2 with SMTP id d2e1a72fcca58-7f669a9517fmr10709049b3a.51.1765863486211; Mon, 15 Dec 2025 21:38:06 -0800 (PST) Received: from localhost.localdomain ([180.172.132.17]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7f5ab7d87e8sm12399192b3a.25.2025.12.15.21.38.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 21:38:05 -0800 (PST) From: stephen.eta.zhou@gmail.com To: linux@roeck-us.net Cc: daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org, stephen.eta.zhou@gmail.com, tglx@linutronix.de Subject: RE: [PATCH v4] clocksource: timer-sp804: Fix read_current_timer() issue when clock source is not registered Date: Tue, 16 Dec 2025 13:38:01 +0800 Message-Id: <20251216053801.331822-1-stephen.eta.zhou@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <75b00815-32e3-4489-9494-438825dd0af2@roeck-us.net> References: <75b00815-32e3-4489-9494-438825dd0af2@roeck-us.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Hi Guenter, On Mon, 15 Dec 2025 15:18:37 -0800, Guenter Roeck wrote: > This patch results in a crash when trying to boot integratorcp in qemu. Thank you for pointing out the problem. > sp804_read_delay_timer_read from read_current_timer+0x24/0x44 > > This is not surprising since sp804_read_delay_timer_read() calls > sp804_read() which dereferences sched_clkevt. sched_clkevt is not > initialized for integratorcp. Thank you for pointing out this issue. I will work on fixing it and submit a new patch as soon as possible. > static int __init sp804_clocksource_and_sched_clock_init(void __iomem *base, > const char *name, > struct clk *clk, > int use_sched_clock) > { > ... > if (use_sched_clock) { > sched_clkevt = clkevt; > sched_clock_register(sp804_read, 32, rate); > } > ... > static int __init integrator_cp_of_init(struct device_node *np) > { > ... > ret = sp804_clocksource_and_sched_clock_init(base, > name, clk, 0); Thanks. Best regards, Stephen