From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E15F33A9C4 for ; Tue, 16 Dec 2025 13:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765892603; cv=none; b=MrTdABcfpZPUXtnRhwr9cOXXz2ptXPTyeP+CW9E6/ek2paZb51mAb7hsypqLFUJo2jNvGtbU1c9ZujD1j8xHQAa0LpfxQaJFF04yatgLbg/MD1ddBAFUXlPUdTDQgWGOQ16yqc8ZeJpKj6MtgQ5geSUTXedD5E/XmO/YtROj/EI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765892603; c=relaxed/simple; bh=tR+5COm7Aajr+rhTyJR6KwpBfk87Pud1IWaOcJU8NXQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=lhXgbNuT0+pJENJzB9j7l5XyPod2+bxpvyis2GZTqgJk2y/0rwNP6xBEr7VOa9idlqpQpehIxJb2KtMuLqZaa4D2V1DqGIxjVCVE+M0PkZH4VgnSHB2+ROzUyzZMtD7kNcgUZ1ptnkwTyT8KWoz21/xsOfpd9mchU89/0LtXrm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=siIgZoXG; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="siIgZoXG" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-42fbad1fa90so3287314f8f.0 for ; Tue, 16 Dec 2025 05:43:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765892597; x=1766497397; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=yUlPjK/WuIqN2nCcCkf3I8wavxJP1d7TYelnQJd0+CY=; b=siIgZoXG0Yvk4Nujo3yIbfCGZ1birFdqmfFOPiZV13TLFcGCHMWFrBQUU17qbe4Wwk TFbAvKlZ+4yM5F54WARxnOaLUxlPfYpmoqw/q3ME/b5NWdb5X8PP8JM3s/WfuUckUmhI y/RXVj2yqEPts3YkcVSlhQOlxvLUa+nNlhx0LTIaDkjBfWnU2agVd8EoG2BNlaunYJtb WEbbBG2DG4kg5oNDGyL4ZmIHXqsHMsro2MbcVFXBAQHtGI0maiZiq83KuwgdxGbx4wyW hvhYIr4iWROnOXBV0jn5W9vftOV1DC2COjNJUKJanbeHqKg7tU514S6vOcq6Ae4QS6Uj FB6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765892597; x=1766497397; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yUlPjK/WuIqN2nCcCkf3I8wavxJP1d7TYelnQJd0+CY=; b=XcVLUi2Ptn0LT9pvZaEMA8sbKDSRPI2k9zRPRmgQU1YnEZBMLxwabk4MyCt9xBnWqb XA6wklDiQVgEQDD9URwOUfzu7iPnSzxrKvc4yiVIEOAo83n2bgLDkIvCNL8Upzo4RaFz u3PZNJkG49e4Huj8Vl9RORRwk6FIKFVIu3ZLL6P+8nplkjUEd/PzDlsbHI6Em7FdqNbA Np8gWp0xKstkmY/XC0TmwYcGvlZoITaV9jd+O2hDAulqGgZ6ya8BBRwJXGKATLHznX3t 4lGDm8Xj+hQzRKoSnEi63gNvCoQr0/Op3itv+ZTAtsqvur15162pqjcJWjZql45htR8R RMdA== X-Forwarded-Encrypted: i=1; AJvYcCVNKFWOO59Rc3pLDFFyTOgT2dx3XVe5R0tdXPct1Z8ig071b5ymziTnmF6nuH9Fdp8HONyE56Fgxuw6Ts4=@vger.kernel.org X-Gm-Message-State: AOJu0YwytgiCGWk6I3ZUHCkMZhcQRuUXLKOLk4KxP/iWGvWyIwjywRwL MsKS+Oc4B5x9Ln3KtX44N9dXSG7tx8EBWlQh/ifvKYrRqWaGJwqkSOxZU7qi1jxnFZg= X-Gm-Gg: AY/fxX6PBESBqel9CdgxgzILjcyHHzVVbeDUNjvxN7vpoulvZU+feaGZzRvoO/r8aPz kmQ2wLt35UkAKj8Qzd1rxXr2JMRbgZmoc55wRrJoGZtAnwPudBkyPV7jQI9K21C7jP0erlfCf/v YaM2AyoK5OkEj3WyuLn1mR5CNoguqQwvFQUEl+2fzuoxzEf4O1CyzW/w/NJSOZ63/vlKpuricZE /OUPEIaKLddZeXAsbiMjLka2ZDJK58YRF7fyL3wx/owu6pQBOBnXsxpN+H7JinPbSnAqC1Lnuo7 A4mfuLC6QCPApsg+P9wLLdMXoH2NAI4ASrl3oYhs+v641+pG6PZ45gWA6M8rsvn+APHBFJMuHVO VcDahDSRx1OFiPYoCN1f5IYbLHHQW/4JDcG9p3phjcvT6zCltpgNrZ+Hz7a3zaudvh3h1+RJLKY eeGSr2qM5K00MORPzc X-Google-Smtp-Source: AGHT+IHuvJ59Z1jzIkZ6nejGnOwd19Br4R1Mgp+JiGBQm8dkLJ8TPIA85El0Ts/AzaUTzTNPgPcHrQ== X-Received: by 2002:a05:6000:2909:b0:42f:a025:92b3 with SMTP id ffacd0b85a97d-42fb44d4395mr13448992f8f.2.1765892596798; Tue, 16 Dec 2025 05:43:16 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-430f38d01d6sm20782702f8f.8.2025.12.16.05.43.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 05:43:16 -0800 (PST) Date: Tue, 16 Dec 2025 16:43:13 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Andreas Kemnade Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Sebastian Reichel , Matti Vaittinen , Matti Vaittinen Subject: drivers/power/supply/bd71828-power.c:469 bd71828_battery_get_property() error: uninitialized symbol 'tmp'. Message-ID: <202512161012.YCn72zq9-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 commit: 5bff79dad20a51fed3ff6d78f6b60321cd145a99 power: supply: Add bd718(15/28/78) charger driver config: openrisc-randconfig-r071-20251214 (https://download.01.org/0day-ci/archive/20251216/202512161012.YCn72zq9-lkp@intel.com/config) compiler: or1k-linux-gcc (GCC) 15.1.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202512161012.YCn72zq9-lkp@intel.com/ smatch warnings: drivers/power/supply/bd71828-power.c:469 bd71828_battery_get_property() error: uninitialized symbol 'tmp'. vim +/tmp +469 drivers/power/supply/bd71828-power.c 5bff79dad20a51 Andreas Kemnade 2025-09-18 437 static int bd71828_battery_get_property(struct power_supply *psy, 5bff79dad20a51 Andreas Kemnade 2025-09-18 438 enum power_supply_property psp, 5bff79dad20a51 Andreas Kemnade 2025-09-18 439 union power_supply_propval *val) 5bff79dad20a51 Andreas Kemnade 2025-09-18 440 { 5bff79dad20a51 Andreas Kemnade 2025-09-18 441 struct bd71828_power *pwr = dev_get_drvdata(psy->dev.parent); 5bff79dad20a51 Andreas Kemnade 2025-09-18 442 int ret = 0; 5bff79dad20a51 Andreas Kemnade 2025-09-18 443 int status, health, tmp, curr, curr_avg, chg_en; 5bff79dad20a51 Andreas Kemnade 2025-09-18 444 5bff79dad20a51 Andreas Kemnade 2025-09-18 445 if (psp == POWER_SUPPLY_PROP_STATUS || 5bff79dad20a51 Andreas Kemnade 2025-09-18 446 psp == POWER_SUPPLY_PROP_HEALTH || 5bff79dad20a51 Andreas Kemnade 2025-09-18 447 psp == POWER_SUPPLY_PROP_CHARGE_TYPE) 5bff79dad20a51 Andreas Kemnade 2025-09-18 448 ret = bd71828_charge_status(pwr, &status, &health); 5bff79dad20a51 Andreas Kemnade 2025-09-18 449 else if (psp == POWER_SUPPLY_PROP_CURRENT_AVG || 5bff79dad20a51 Andreas Kemnade 2025-09-18 450 psp == POWER_SUPPLY_PROP_CURRENT_NOW) 5bff79dad20a51 Andreas Kemnade 2025-09-18 451 ret = bd71828_get_current_ds_adc(pwr, &curr, &curr_avg); 5bff79dad20a51 Andreas Kemnade 2025-09-18 452 if (ret) 5bff79dad20a51 Andreas Kemnade 2025-09-18 453 return ret; 5bff79dad20a51 Andreas Kemnade 2025-09-18 454 5bff79dad20a51 Andreas Kemnade 2025-09-18 455 switch (psp) { 5bff79dad20a51 Andreas Kemnade 2025-09-18 456 case POWER_SUPPLY_PROP_STATUS: 5bff79dad20a51 Andreas Kemnade 2025-09-18 457 val->intval = status; 5bff79dad20a51 Andreas Kemnade 2025-09-18 458 break; 5bff79dad20a51 Andreas Kemnade 2025-09-18 459 case POWER_SUPPLY_PROP_HEALTH: 5bff79dad20a51 Andreas Kemnade 2025-09-18 460 val->intval = health; 5bff79dad20a51 Andreas Kemnade 2025-09-18 461 break; 5bff79dad20a51 Andreas Kemnade 2025-09-18 462 case POWER_SUPPLY_PROP_PRESENT: 5bff79dad20a51 Andreas Kemnade 2025-09-18 463 ret = get_bat_online(pwr, &tmp); 5bff79dad20a51 Andreas Kemnade 2025-09-18 464 if (!ret) 5bff79dad20a51 Andreas Kemnade 2025-09-18 465 val->intval = tmp; 5bff79dad20a51 Andreas Kemnade 2025-09-18 466 break; 5bff79dad20a51 Andreas Kemnade 2025-09-18 467 case POWER_SUPPLY_PROP_VOLTAGE_NOW: 5bff79dad20a51 Andreas Kemnade 2025-09-18 468 ret = bd71828_get_vbat(pwr, &tmp); 5bff79dad20a51 Andreas Kemnade 2025-09-18 @469 val->intval = tmp; Smatch complains that we don't check until ret after we assign the uninitialized variable. 5bff79dad20a51 Andreas Kemnade 2025-09-18 470 break; 5bff79dad20a51 Andreas Kemnade 2025-09-18 471 case POWER_SUPPLY_PROP_TECHNOLOGY: 5bff79dad20a51 Andreas Kemnade 2025-09-18 472 val->intval = POWER_SUPPLY_TECHNOLOGY_LION; 5bff79dad20a51 Andreas Kemnade 2025-09-18 473 break; 5bff79dad20a51 Andreas Kemnade 2025-09-18 474 case POWER_SUPPLY_PROP_CURRENT_AVG: 5bff79dad20a51 Andreas Kemnade 2025-09-18 475 val->intval = curr_avg; 5bff79dad20a51 Andreas Kemnade 2025-09-18 476 break; 5bff79dad20a51 Andreas Kemnade 2025-09-18 477 case POWER_SUPPLY_PROP_CURRENT_NOW: 5bff79dad20a51 Andreas Kemnade 2025-09-18 478 val->intval = curr; 5bff79dad20a51 Andreas Kemnade 2025-09-18 479 break; 5bff79dad20a51 Andreas Kemnade 2025-09-18 480 case POWER_SUPPLY_PROP_CURRENT_MAX: 5bff79dad20a51 Andreas Kemnade 2025-09-18 481 val->intval = MAX_CURRENT_DEFAULT; 5bff79dad20a51 Andreas Kemnade 2025-09-18 482 break; 5bff79dad20a51 Andreas Kemnade 2025-09-18 483 case POWER_SUPPLY_PROP_TEMP: 5bff79dad20a51 Andreas Kemnade 2025-09-18 484 ret = pwr->get_temp(pwr, &val->intval); 5bff79dad20a51 Andreas Kemnade 2025-09-18 485 break; 5bff79dad20a51 Andreas Kemnade 2025-09-18 486 case POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR: 5bff79dad20a51 Andreas Kemnade 2025-09-18 487 ret = regmap_read(pwr->regmap, pwr->regs->chg_en, &chg_en); 5bff79dad20a51 Andreas Kemnade 2025-09-18 488 if (ret) 5bff79dad20a51 Andreas Kemnade 2025-09-18 489 return ret; 5bff79dad20a51 Andreas Kemnade 2025-09-18 490 5bff79dad20a51 Andreas Kemnade 2025-09-18 491 val->intval = (chg_en & BD7182x_MASK_CHG_EN) ? 5bff79dad20a51 Andreas Kemnade 2025-09-18 492 POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO : 5bff79dad20a51 Andreas Kemnade 2025-09-18 493 POWER_SUPPLY_CHARGE_BEHAVIOUR_INHIBIT_CHARGE; 5bff79dad20a51 Andreas Kemnade 2025-09-18 494 break; 5bff79dad20a51 Andreas Kemnade 2025-09-18 495 default: 5bff79dad20a51 Andreas Kemnade 2025-09-18 496 ret = -EINVAL; 5bff79dad20a51 Andreas Kemnade 2025-09-18 497 break; 5bff79dad20a51 Andreas Kemnade 2025-09-18 498 } 5bff79dad20a51 Andreas Kemnade 2025-09-18 499 5bff79dad20a51 Andreas Kemnade 2025-09-18 500 return ret; 5bff79dad20a51 Andreas Kemnade 2025-09-18 501 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki