From: Andrew Morton <akpm@linux-foundation.org>
To: Qiang Ma <maqianga@uniontech.com>
Cc: bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kexec: Replace the goto out_unlock with out
Date: Tue, 16 Dec 2025 11:11:39 -0800 [thread overview]
Message-ID: <20251216111139.9a96dcbde829bf5d667ff50e@linux-foundation.org> (raw)
In-Reply-To: <20251216075518.1626114-1-maqianga@uniontech.com>
On Tue, 16 Dec 2025 15:55:18 +0800 Qiang Ma <maqianga@uniontech.com> wrote:
> The image is initialized to NULL. Then, after calling kimage_alloc_init,
> we can directly goto 'out' because at this time, the kimage_free will
> determine whether image is a NULL pointer.
>
> This will prepare for the subsequent patch to reset the variable in
> kimage_free.
There doesn't seem to be a benefit to applying this patch unless the
"subsequent patch" is also applied. So wouldn't a two-patch series be
more appropriate?
next prev parent reply other threads:[~2025-12-16 19:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 7:55 Qiang Ma
2025-12-16 19:11 ` Andrew Morton [this message]
2025-12-17 2:20 ` Qiang Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251216111139.9a96dcbde829bf5d667ff50e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maqianga@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®