From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDE5E358D33 for ; Wed, 17 Dec 2025 16:35:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765989316; cv=none; b=OkCLqAkOWQ7ma34Bimb8hgfuwAKOzWTjhKGlMPea9piAL/a0jSJD0NjYchnvVr+DHf/HWvkNW3cqCcyfR4644Ue3EvC4M4lxrjTrKEh/y5GAeZdKBmU/BG1V/sfE2U/EDmivcBL5+8VMi2IGKXTA/+c9RkUiwVWYWTG+5jNSGZg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765989316; c=relaxed/simple; bh=yBYzqc0S1JphVHuD2j55BlKNRj4RzOO+Sg8ufDQtOo0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=quPPFPm82wyh+hcqz/I8Ma5pJBBYOD+5gcdBBHDnLJSmVhunZ87vsp2MvpuPuqlvQQ3vbcN286xItwvvMKj+tsxjm/3iJ/692/gveb93gCu5eFFdJgYV9p5C8AgJ2IKw85dY2z+THzrBYE07LX+te6SY3XHH+O7MyP90kMuqbu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cyIBGjY7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bMo5IQiQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cyIBGjY7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bMo5IQiQ" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BHEvRe22720272 for ; Wed, 17 Dec 2025 16:35:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IGO99rWItnnwo77g8rlfsZqn5NHrWegTLAN6ef6NdU4=; b=cyIBGjY7ANvNA+F5 LJrlVHP63kNG7nisScP5ZdNcrl9T6qC/Hg2Rz1ucGlj4RwZ8vZxqQzm71QaaGd4O /3Lvao4/3HXaQR0PCA+uLMWS3o4eFzYbqNfNTuogdUAM2rnPwldVCQy2iGBNeook 60HcQDD0Qemff/elvDJtKKAWpdNyPHAvgTrxFEIGW56gkYSKqET0/XU/az26LoxA bDFI1RUMyLCr5KdL9FLYwZ8SONt93f3lZ2YlP8bE8hevkWRioBDVfLk4epmypFEg KgxRHYerq9hs/NJfO5jroqYcWwGugjlSe76gfX6DIVARnKtZF7HlEn8X8JFsJm9b yypnvw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3xr58cry-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 16:35:13 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2a13be531b2so41964925ad.2 for ; Wed, 17 Dec 2025 08:35:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765989313; x=1766594113; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IGO99rWItnnwo77g8rlfsZqn5NHrWegTLAN6ef6NdU4=; b=bMo5IQiQgZ512Og1XbzqodYVpo5KVeYvYR4hHsqqWizzpZmP3mAQi4rdaMBNmh2DOf kjOp6r452dbnpLWJaBfnHRV/V6YHIgEBFqpFWTD6OkZYYaP9zxQ/mLdRZwlcZgLjIrik /CH7YlBtUJccOSmfvxajd9HkX9vPzGVvvFdjx94AvwtGHyXWCW3CxT4AgRWu0MzFW7CY lzncVlyhQwi7YYJ/V0s84rREgmjLLxejuOfG7Rk/oLbTYvzSxU9JFaH0raZssWcB+DI3 dQE8w/MfXXbEIMCNqJy6ye882hNhjAUMc1i2K4Vd177Z/EJjqq7hac3QmZv/T4gTlZaL p+gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765989313; x=1766594113; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IGO99rWItnnwo77g8rlfsZqn5NHrWegTLAN6ef6NdU4=; b=hicpgYanyy9u/uoUZPf9Pf70DOmsSiW6jN0Qp3tpYNC03/VeA1PL1rtecTCmsKoQxx kOSa8Q24pg/cGAXOgjOsTg6WUalXtpPal89E/DoEViCQZPjW3yCQByNnY82XR6A0EYwB QR3eGbV6Esw7T+VBE9ELtJYxvyx5MjukoeLCMUxPmDeyWnFvCKrDQADZxlKbj3y8YyBH CcWaPlWpIU9lBJhMdPm2q1N/48ldRqFmBI8WkZpk6r23Dh3l20oshHMirblpO8aDF+h7 ZG8MXTw2nUWvyz5oKG2Du/geV1jmwMrFmMFAf9iaYHfImmeyYDKeQjVHnmaBTH/Utp9E heFg== X-Forwarded-Encrypted: i=1; AJvYcCVqpzkX9VoKQWn7VPmGHW82sac7jRDfP7oNaotu23hoHZW0wcnnUCvFyJjeJIMNLKs5qW2uytY/U4Wi5ig=@vger.kernel.org X-Gm-Message-State: AOJu0YxhDt5NUEmUc5dTvczqrRjIBY3XMTowf5eO0Cr8bgPZuR8VwkeY IcjOim1ycSjuX4yVCVSE/c1Rx4FB0sojh97rP333z+ipFgwNsLd15Oq+ZgAePfS9Lhviabo6Ckl db0rNLNchIAOyi0oCf81/5kJQNvOGjKNXvQzfUoK7yAhXbHKLBbvpF6VYRA5oc5bSAtQ= X-Gm-Gg: AY/fxX7sWwQQJb53LkF7+9YIM0enGFFeBu0t7Lwx+CT3hyxfTOrTA19pQguSgy6j9h8 M7Twu1VDHXXgtDdeW8ZZGbfjqdSZBM6bHE80P+OKU1lw69FmgfYMES/2ZkIqiPVZhsfeRRGYYkL fJFMGPQ5/DaJ7KbRlqbappjLPlc89gpzFRqjawB3f799/NAzQ7FlqQyoTCCKXskzCJBgfRvLDk3 N8AgdgvXGSqsFyfer7iYSYFITTq/2/yW3d7mReL1vJi/yGL5a0dCw11c6vGxmd7gIiZH94AnsJ5 AKlYaU6XNQ+3b3zwYAWz6RSWw2aDgFNsjhu7p3FyEOPL3A6aJi865lvCfffWUDtnPmWI8YRyOwJ fPGtItvEHX3nDFWiQoFi2GZHRpZ+3u0pcRVvf X-Received: by 2002:a17:903:3bad:b0:297:d45b:6d97 with SMTP id d9443c01a7336-29f23e3618emr197363725ad.14.1765989312023; Wed, 17 Dec 2025 08:35:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IGu76/RdEU0SDBR8aBaXkqghR90u41/dQnfZUGn0J4HlRjXSeRxIKQx+zyA6K+BSJUGHSMFJQ== X-Received: by 2002:a17:903:3bad:b0:297:d45b:6d97 with SMTP id d9443c01a7336-29f23e3618emr197363235ad.14.1765989311371; Wed, 17 Dec 2025 08:35:11 -0800 (PST) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29ee9b36af7sm204721055ad.18.2025.12.17.08.35.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 08:35:11 -0800 (PST) From: Mukesh Ojha Date: Wed, 17 Dec 2025 22:04:38 +0530 Subject: [PATCH v9 02/14] firmware: qcom_scm: Remove redundant piece of code Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251217-kvm_rproc_v9-v9-2-ab7ac03e0ff1@oss.qualcomm.com> References: <20251217-kvm_rproc_v9-v9-0-ab7ac03e0ff1@oss.qualcomm.com> In-Reply-To: <20251217-kvm_rproc_v9-v9-0-ab7ac03e0ff1@oss.qualcomm.com> To: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mukesh Ojha X-Mailer: b4 0.14-dev-f7c49 X-Developer-Signature: v=1; a=ed25519-sha256; t=1765989299; l=906; i=mukesh.ojha@oss.qualcomm.com; s=20250708; h=from:subject:message-id; bh=yBYzqc0S1JphVHuD2j55BlKNRj4RzOO+Sg8ufDQtOo0=; b=/2jf6vhjy4QLGEOUszAhuO/B64Iqi4w47ebi05Xomx0kqSrrIt2AibMsclR/gJU8gCF/b+VKt sPH2d2qYjiJCMwLNWI/qf5tj5R8+TQ0ctn0KvFVsmp6EWCXAH1faTHK X-Developer-Key: i=mukesh.ojha@oss.qualcomm.com; a=ed25519; pk=eX8dr/7d4HJz/HEXZIpe3c+Ukopa/wZmxH+5YV3gdNc= X-Proofpoint-GUID: QflIhgLKLjBbHT8Od5Yn4sR5mta5d0Y9 X-Authority-Analysis: v=2.4 cv=DsBbOW/+ c=1 sm=1 tr=0 ts=6942dbc1 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=pWxEDRe995Kf1ot4LjYA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDEzMSBTYWx0ZWRfXwyN0N/8SKw6y tBm27E9lkgLmD6yDUzsLTrwEZ68VFki2B1frUh1ZrpQSwv7PduEm0ngZX71a8juXPS/2KPLQ5Z4 YUmAWEV2dL8VM8nofiRPWbdeXrjrPxw2fZIs0T3lZFh9ekjQpcgwpPvX8rbbCTzN+61yKi5i2Kv SUv/Pjv71VCOB7ZZd5KttUyjL9b2edIy7mMO/L/avNC0ESBIHiFeG4G2TLO/TWbqy2iTG43Ml2y 98uJdK8PGF3qB7LTYa43poCZ5INy9QpSKLeJyEgXs7FDRPCuF/B4bq+122RXm3u8y9n4qv83Wvb hwv80DPG2xRrs0qZ8Y6NPGKe7VS300o54T+4/d+jbD5o0V/EbnUdGKmbxd1kr/oH23rSqQFB78H dXC4Ag1zbwJPJKkp2wJ8/uYolu4jIw== X-Proofpoint-ORIG-GUID: QflIhgLKLjBbHT8Od5Yn4sR5mta5d0Y9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_03,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 impostorscore=0 spamscore=0 adultscore=0 clxscore=1015 bulkscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170131 The qcom_scm_pas_metadata_release() function already frees the allocated memory and sets ctx->ptr to NULL. Resetting ctx->phys and ctx->size to zero is unnecessary because the context is expected to be discarded after release. Lets removes redundant assignments. Signed-off-by: Mukesh Ojha --- drivers/firmware/qcom/qcom_scm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c index 1a6f85e463e0..6461408c58a3 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -650,8 +650,6 @@ void qcom_scm_pas_metadata_release(struct qcom_scm_pas_metadata *ctx) dma_free_coherent(__scm->dev, ctx->size, ctx->ptr, ctx->phys); ctx->ptr = NULL; - ctx->phys = 0; - ctx->size = 0; } EXPORT_SYMBOL_GPL(qcom_scm_pas_metadata_release); -- 2.50.1