From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C45905464D for ; Wed, 17 Dec 2025 02:48:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765939732; cv=none; b=JQ5aylTJwTFQWyYTTAqo2J7Q7FmBTY8HQRQwic64kscWo9dSechZO2JOB8+qVfwNfkE0NvLqEJkGadBqmf/ZOHLdSlEcs6dJ12KnbN2RtVGC22PvXqcpXlJEQmLnJsTRBoADAzVTAgVgVOb0lb0BnEp1TkxxbrL6JJzUVPgVmSw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765939732; c=relaxed/simple; bh=Wbj2BPFSD4+24X9YllNFBBT5gywBCPBLau96yo+gKgU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TwJUMX2NC/1Y6w3+35NCWVfpKOPXcxFSpoP8gwj58iWkumM/9gV8MzA/MBJQtr+l8ADiFMBS62O3cKxD52xiVQgyeJ2mKS+Wzfpng1gJWPmWLq2EotbS68lxX+PqfDv/MZa1AKVVnr+GbYZ2C8klJJ4jvWpJquvKlYXATaAkaNo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VQb+LqFg; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VQb+LqFg" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b8010b8f078so9835366b.0 for ; Tue, 16 Dec 2025 18:48:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765939729; x=1766544529; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ggnpTKjc7CoueWSBfB7b7LA8VoJO3XLRhf05Pp+Akus=; b=VQb+LqFgHLNTw6uaDi42lL3n4uKtyQ8xnbOE5vnXPGBQx5O2zTyihE2kK1i1g9TNcj b2FPZeXJoNLV5ncp06M6lRS6ASVCQ8nPamXxlbmEvAsl+Z88KVzA4qDHLoaPL9zPCNN7 m5SLA6I4ZBdk70U6cWS4fLOs/mkxeUOy7djwOfUhElzBeHPWqoVzcHelbcmYPyzyR/gz jS7Rg8p/LDto1fx1p2CxyDrq9NDc3eZ5dDLhL03Sh7lwjW5rEJAacQScYVSXAExiCfa9 oAipXz8zgrvhvvDnvvZiHmThOnbOxVVBnq+rl6kDyRdMvON+m0jBgQHXCkowE8wF9rmu QgTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765939729; x=1766544529; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ggnpTKjc7CoueWSBfB7b7LA8VoJO3XLRhf05Pp+Akus=; b=jv03DeZCwIIRICgHMyIqEMlOhaXlAqeN81ABsmUfNSS9q0p4g35y38ukHrg5h8FulQ Lrxk2VjEV1vUHGBi8T9bAA88GsCX4193QFlQplORpS3GrkIUj6LkdjlyvHxiBNt5bBAM /F/A3NnKUR6DZY/hht10xnBNOv4wx3ouMe1ququh5FEzSv2mO0nGpSjwWDvJyJgg3s48 H48D54Bod4nRkvy50cS6n5+ZpVkJrQOViF/QHJAxEFVt4cgwazYrGGMi8TiBh+e9G/At Dv7t07L5JmaWJKYgiqbYwBOjk4H83uQJrijA/B9I/fS50yAvVCO4b+tXRsIbWuSYsK4I oehA== X-Forwarded-Encrypted: i=1; AJvYcCUUFpQD2xVBSix0jyQsvbmZRaPFUkpTZCUKeF3vjFkA9Vy9pwiyvvHnC09hkr/U47KmvVEM8HgE146zQMs=@vger.kernel.org X-Gm-Message-State: AOJu0YzydVc1eLetVgW4Yzfo2sPBB6HD5CjwQkdMHmHeJgcojRWxp0Sm mqXZHe9eVR1JsTRP5KQStveIvTRTErrNs5PHi+xVy39/DeEd2X77BVjC X-Gm-Gg: AY/fxX7bK5GcMsPH0fgul1J7RjjgZ8bIGtY1AtC/Y2znf+yNdwqHEAZ72ryaE4jglFa vbJt8FDrNJog4f/+jdU+mKoaXSK+qIdqhqbAQEh9hASgpzGNSMGoU7XexJTu2WmaXwItfQZlJO+ 5oLwpQX6O8RieiuyV80fkFsDJ/ji1gyT6cxeXRAyPbeVVwoP/bcjETzHPLdTGwQDCCfFodJBYfb wq6V2B+Ti+w2wCLWA0WC3Aa0gM2/7mJe97U8uIVmytdhZos9vz2ZcUwLTxFqFLkS9djF6I+qTH/ xIHvZxDTL1/ZN44CkzIYWyM+r/i55wjofk5peJ54f1503ar86LdAg8eRvTG9ztQz8qnvstcvdk2 TDJixOwgNnc7ID4k+NZoSuqZfjfXeZb0+XOA76/THbjs7LWXffndPHfgkugYcdRgUKKz0TUMt7D pXHv6Wdk/Jzw== X-Google-Smtp-Source: AGHT+IEGzrL4ei4CYURCoMiWH15xVOBFZFp8TlRYA+TPMXKI5GJcECNuu0kOntwSve234QDDTf/kzQ== X-Received: by 2002:a17:907:e895:b0:b72:5fac:d05a with SMTP id a640c23a62f3a-b7d23a96f0amr1628477866b.37.1765939728848; Tue, 16 Dec 2025 18:48:48 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7cfa57190dsm1884704666b.49.2025.12.16.18.48.48 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Dec 2025 18:48:48 -0800 (PST) Date: Wed, 17 Dec 2025 02:48:48 +0000 From: Wei Yang To: Shivank Garg Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm/khugepaged: make khugepaged_collapse_control static Message-ID: <20251217024848.uolcvqwywhpwdibp@master> Reply-To: Wei Yang References: <20251216111139.95438-2-shivankg@amd.com> <20251216111139.95438-8-shivankg@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251216111139.95438-8-shivankg@amd.com> User-Agent: NeoMutt/20170113 (1.7.2) On Tue, Dec 16, 2025 at 11:11:42AM +0000, Shivank Garg wrote: >The global variable 'khugepaged_collapse_control' is not used outside of >mm/khugepaged.c. Make it static to limit its scope. > >Signed-off-by: Shivank Garg Reviewed-by: Wei Yang >--- > mm/khugepaged.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/mm/khugepaged.c b/mm/khugepaged.c >index 65b1b778378a..d130357a2d88 100644 >--- a/mm/khugepaged.c >+++ b/mm/khugepaged.c >@@ -829,7 +829,7 @@ static void khugepaged_alloc_sleep(void) > remove_wait_queue(&khugepaged_wait, &wait); > } > >-struct collapse_control khugepaged_collapse_control = { >+static struct collapse_control khugepaged_collapse_control = { > .is_khugepaged = true, > }; > >-- >2.43.0 > -- Wei Yang Help you, Help me