From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECBCD19C566
	for <linux-kernel@vger.kernel.org>; Wed, 17 Dec 2025 17:30:37 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1765992638; cv=none; b=N5VOWUf/2bb9ZKqCnINF8Ixz8KTuYoRTq7eFwczdc0Yv3B/o3cXh+lFidZ2nbT3DtBvsvT90mPKxnB9Cnz3Ynng6w1obfyPmE1vPHctlff3SZoQc2/4CYOAKDJ2HsH0hCIdiM3nyirtYzlax1Qh5XaSf9BZ31ye+fpwbrI55ONc=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1765992638; c=relaxed/simple;
	bh=YlRNNGNVHNq6DOUluWj1hnA+ZZEyhiWGq/CaxMEk610=;
	h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References:
	 Mime-Version:Content-Type; b=AYXOCg1wWYWF/9XaE9o/TKlrNuUDKv5OCe+kpNUY2HDhXkilW0uSRW7IYvOYI4z/R/FeFQSgV534RfsH0LIHwbmB03WGQkhmqoPjyVknfGhe81M1jDjMw4UGmRtcOlk4ZzaWLSP82v3lPEEh9a7jXxONSnmmMcdZSMWP9EH/gto=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=0045SR3T; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="0045SR3T"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50630C4CEF5;
	Wed, 17 Dec 2025 17:30:37 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
	s=korg; t=1765992637;
	bh=YlRNNGNVHNq6DOUluWj1hnA+ZZEyhiWGq/CaxMEk610=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=0045SR3TksK3qNPi3s4Txo8Pzjte7WhkqVKUOZJwoc5dZWvT4qDHJLGxPsCTNH5j+
	 jhdk54E4FEzexSvU5618ltLvktkEzjZb2s2foMZXHDV7twyuatgyfxmihhrcTwP9Wp
	 Afu1qYGo0zz4sKF1Npa6Bc3f8rGN7S8Yzelj61HE=
Date: Wed, 17 Dec 2025 09:30:36 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Cc: Kevin Brodsky <kevin.brodsky@arm.com>, linux-kernel@vger.kernel.org,
 Ryan Roberts <ryan.roberts@arm.com>, linux-mm@kvack.org,
 linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/mm: export symbols for lazy_mmu_mode KUnit
 tests
Message-Id: <20251217093036.3231f9613ac8f9cf3943357f@linux-foundation.org>
In-Reply-To: <878qf1kqg3.ritesh.list@gmail.com>
References: <20251216201403.4647a4f9861d3122ee9e90d7@linux-foundation.org>
	<20251217163812.2633648-1-kevin.brodsky@arm.com>
	<878qf1kqg3.ritesh.list@gmail.com>
X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On Wed, 17 Dec 2025 22:15:16 +0530 Ritesh Harjani (IBM) <ritesh.list@gmail.com> wrote:

> ../arch/powerpc/mm/book3s64/hash_tlb.c:158:1: error: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_IF_KUNIT’ [-Werror=implicit-int]
> ../arch/powerpc/mm/book3s64/hash_tlb.c:158:1: error: parameter names (without types) in function declaration [-Werror]
>   AR      init/built-in.a
> cc1: all warnings being treated as errors
> make[6]: *** [../scripts/Makefile.build:287: arch/powerpc/mm/book3s64/hash_tlb.o] Error 1
> make[5]: *** [../scripts/Makefile.build:556: arch/powerpc/mm/book3s64] Error 2
> 
> 
> IMO, we will need the following header in hash_tlb.c
> 
> +#include <kunit/visibility.h>

Yeah, I already added Ritesh's patch which had this include, so I
think we're all good now.