From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBDBC3612EE for ; Wed, 17 Dec 2025 16:03:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765987400; cv=none; b=Ncz+EzuIzSUJr9gsYCgsslEA+sE6s9cn2h+UVUO3nxZi6nas0A6xqrgI+/WBLOl1wgyz0vGArQ8zPFmwSciOwGg/8zxVfuF0nvykU5xnAiSVFo4RL58MFKAjIe5OdCCM6L6U4LF5qiBrXiApl7Qk5NPvU9USM7CM6ebMKIN2I2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765987400; c=relaxed/simple; bh=5ctkryHTSVEBmIKZydISovXFgqs2qFehHGeCxafVmck=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HnaodNjkuic+5J05VFPXDLKsrbv0YmJ7cLv8GoyS8yFskxCu0ldsETAdFN+txPQRo6fgU0+8qcfMiLSiNhXW58mwEPM/bLaEO5qJ3JojC8dzpktJeUkb+mS1Yw5vfS3bwY227fZlksFiCTBDDBuNn6DolPAJr0KIVLH/Aylr2d8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AA8B6C0938; Wed, 17 Dec 2025 16:03:09 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf10.hostedemail.com (Postfix) with ESMTPA id 60D262F; Wed, 17 Dec 2025 16:03:07 +0000 (UTC) Date: Wed, 17 Dec 2025 11:04:43 -0500 From: Steven Rostedt To: Geert Uytterhoeven Cc: Joel Granados , Petr Mladek , Chris Down , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Sergey Senozhatsky , John Ogness , Tony Lindgren , kernel-team@fb.com Subject: Re: [PATCH v8 20/21] printk: Deprecate the kernel.printk sysctl interface Message-ID: <20251217110443.0274c2be@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: jyo5hzp45ry1frem88sh1pjbka3dyndc X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: 60D262F X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX18yRQDKrf1l7OHvdSaLnQOYgrP2GSCMkBs= X-HE-Tag: 1765987387-114749 X-HE-Meta: U2FsdGVkX1/ELmXzYNg2Hpc5cflVCQQWoi6G5SBuDIC97forJynQ8mEp+7byEABF98BdlQnqGT/yTkpB2jtLIOuvmUuQoOvwZ1ZX9kgD5gNfsj3o4A+31QK9cDpISqsbFpDVC96o+EjW+Dyn7nlWtvEpZgGcbFf2Buo3KIk3zzolmMuKLUUwAPM5HxLuKYEw46STHPdbyqQ0hFIOC7w2Vyvoh2gHlOn1iVLF205YMrUvtcaqRxgy1cFCSr/4OxantI3AR2qES9uW1LoLn//ED3efQx+VdnxjJdun3TxwsSDnDhlAkEnZn4YrBwPlQFHp3bjJq91F70Xtl7EHFXRhu5wXn7R1LZ1DP4UKGDQRguzl1nNFmIvvl6YmCfbBVtFP On Wed, 17 Dec 2025 15:33:42 +0100 Geert Uytterhoeven wrote: > > > OK, what about the following? > > > > > > pr_warn_once("printk: The kernel.printk sysctl is deprecated and will be removed in 2036.\n"); > > > pr_warn_once("printk: Use kernel.console_loglevel or kernel.default_message_loglevel instead.\n"); > > I meant it more as a long line in the code. Not a long line in the > > log. Like this: > > > > pr_warn_once("printk: The kernel.printk sysctl is deprecated. Instead, use " > > "kernel.console_loglevel or kernel.default_message_loglevel.\n"); > > > > Its still long, but more manageable. > > Please do not split long messages, as it makes it harder to find them > in the source tree. Right. Linus has stated that strings should not be split just because they go over the column limit. -- Steve