From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A0E734B1AC for ; Wed, 17 Dec 2025 12:57:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765976280; cv=none; b=NMsKYHcgVNRADPi57JlcYBGUt1lXQMoAFrBAKKvpIVkve8qK/MgFxY2to9jJwj90ZdkcUsN5WcCyLY4Tt5/pc9xqhYIYzAtYisso8y3GSGRTSLrHs0jGqBBNB8y7UTldv4UhNVKSCD9o83VPJscDg3EGGCQP/eP3SZtiCJFtLxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765976280; c=relaxed/simple; bh=JR4+kJaBlmpbY4kjmuT+WtD5sCcuiWQvS1lbYm26OEU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=DhROynn/E2siUUvtOqbslSJQUYWYR2vGXN5VD539ujcwPCQ3AxTcEcTgGvOHYROkYYEz06WMISTiWcG3EC0M9Zx8WDuXIapsKdQPxktD56jaeKHSQI6HaUksXPBPkj0p1IJFpjHAbiPyEw4Fmk1P4ZE0uZUrvN1OuEqyq/Vy7HA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NGnsDQXA; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NGnsDQXA" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-bda175a2013so379253a12.3 for ; Wed, 17 Dec 2025 04:57:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765976279; x=1766581079; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=x3j0D4wFBpoCqxcj3+92dqkBBHNQldTemKoyK60bvQY=; b=NGnsDQXAh6iw+EUoYkWvRRhp9aYu8icQkynwWnGh4a+pf1/Rt6P+GW9JVDAKtPDGJO gbBvgnsUsf35lp/QxcpTeauUDa7gz2a16pdAAbPfkmEZNOQlZ9/zdu0WMpgntfd2rz7w gdhHXo9n93mxq8Smv6NtrXh91Dieas/ndTGJnS9hWXOeSavmR4W6oRcKgTzDZ969Gl9Z jf1TwL/GHmzvbknaOnz5qy61Xx7QCFlF3hg/05SCKDYyNqfjdxMnja5EQ+EeBp2mP0sv VrWiwYwHN2/SiYp8dlQyGsa0SevLOeLSriLH1RWUYXmiAOvi82e1GVEZMeLrBWftk1W7 EDNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765976279; x=1766581079; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=x3j0D4wFBpoCqxcj3+92dqkBBHNQldTemKoyK60bvQY=; b=paMJ5zKq+y5VP+BXEgmhdVbOPoPshkO+gbWx9OFkE2gUATC896ShotiZsW1mxgc0wn UjuS4VS/02fdOW6/DDqleDm838VmttQjVXRXk4X1t/gUYMLA9/yRcyGvJ1BUyYA1f6cY 6X3exa7aNa+6IW0o/TdvXvWGMBrvaCTfUR/T/qP0eBXQQ/wefUh+PTpplD4XuPiLH0YG UVsseRpTJH408swLqX/qkXDYZ9HrpchwwRIBYdjnBbhPr9M4kIkn5arlrKB4D6KzsUb1 RdvZBmdF9aUAyyP791c1NL7rbK8oksjPVYuzGoAEyja84djWALU1jldN022O4DMT0cIN 82/A== X-Gm-Message-State: AOJu0YyLkJu7+9mZFMbKQFKpdIMEuJMilxeLf74SFKMxa3QptUTKQPMb SNJeQIS6fqLDgeHDYiklHZqiRJvtqXj+bqhrhxOvJlKvDVffg+eteIrkyAxaqqh4 X-Gm-Gg: AY/fxX5gcyZVLEcNKETxRHWeFqfQxwDkVsaEhgqIDl+1Qtgw66LrJNl4l7EZItN0rbg ajHw2uu23L64a5ilABw/pVRpa+9p7UuPIivJLPmfVtoE4aq/j709LK6iBuPZYaZW6dmClcMFV6L XtwARl2hsQS43D+5TpiFqSN/myj0ZFWkZJ/qL005zb+WrlEveGzUnBIzw4KE7nu1gjWLzBxXDM7 bEkTB3PgybeKg30lw4A8N9NN9j+gH9J31igMNzsq17qoHH60sV5VpYBIJfeGs59H2HVmlhPlfSC czDzAOUsRy+QmkZdhvpzwZnevad0WyGzzwNhuR31GF8e653I/X+rIe+p1oIQB9akZNcqdTIrYsb KwDW70IzjVNWVlGjhynxi9quj013HCtjNEyo/Xiyxm3TuaaiUg4GdRwQwyHoEzdFj0XT4ezkES8 hqVpFfn9J+RuE5T6GUCNm43VZmYDtZidX56+35jtsPlLeInSUM47kbhpsEL2F8JTOGrBNUbPTp X-Google-Smtp-Source: AGHT+IHeFwiM3NT69mj8CR+qRtoImQENjTvcoKBveMjhuZe4k2Ra/OXcxgpLyAQfJWV1SlZBc8mGVA== X-Received: by 2002:a05:6a00:2290:b0:7b8:bab9:5796 with SMTP id d2e1a72fcca58-7f6690b510fmr15170891b3a.3.1765976278489; Wed, 17 Dec 2025 04:57:58 -0800 (PST) Received: from poi.localdomain (KD118158218050.ppp-bb.dion.ne.jp. [118.158.218.50]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7fd974aeb37sm839335b3a.11.2025.12.17.04.57.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 04:57:58 -0800 (PST) From: Qianchang Zhao To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Paolo Abeni , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Simon Horman , stable@vger.kernel.org, Qianchang Zhao Subject: [PATCH v2 0/2] nfc: llcp: fix double put/unlock on LLCP_CLOSED in recv handlers Date: Wed, 17 Dec 2025 21:57:44 +0900 Message-Id: <20251217125746.19304-1-pioooooooooip@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series fixes a refcount/locking imbalance in NFC LLCP receive handlers when the socket is already in LLCP_CLOSED. nfc_llcp_recv_disc() used to perform release_sock()/nfc_llcp_sock_put() in the CLOSED branch but did not exit, and then performed the same cleanup again on the common exit path. Drop the redundant CLOSED-branch cleanup so the common exit path runs it exactly once, while keeping the existing DM_DISC reply behavior. nfc_llcp_recv_hdlc() performed the CLOSED cleanup but then continued processing and later cleaned up again on the common exit path. Return immediately after the CLOSED cleanup. Changes in v2: - Drop Reported-by tags - Add missing Fixes tags Build-tested with: make M=net/nfc (no NFC HW available for runtime testing). Qianchang Zhao (2): nfc: llcp: avoid double release/put on LLCP_CLOSED in nfc_llcp_recv_disc() nfc: llcp: stop processing on LLCP_CLOSED in nfc_llcp_recv_hdlc() net/nfc/llcp_core.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- 2.34.1