From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C691385CD4 for ; Wed, 17 Dec 2025 13:59:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765979967; cv=none; b=mwjHWHGRHznPGuhIqyuqf8Ouh2/TP5wgn5n03rvS0Elk5PNQduoTjTPY3EqLz2ANQ7wRrTKo3EYMFeQ/sw0G4bEOfCo/RmeiMiv71AjfofYcmVgq1JLYiEoPSOYVzzyoF5G0cxNcdqXbzFw0urbdAz4prSFUgfchBaW0ldoGEls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765979967; c=relaxed/simple; bh=BpihFFLfYFP7NquDRCAtsdSMpFO21CfRjAdn8MUNOXM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hBR39ruRyS+Vha1USAlmbiuXBLvCEiJsAD1zNPKMnL7cDIL2Zx3YWfkseMSwvXHAA5gLuMPmNR9aPa7XeOsXPvZOl+L0EHmnRPN4WrZuD7JQcvm8EY9C8RCOMmu2+T2Yainw12Uu1X2x0IU7McFO96BvNu9gVkpv5lsxBtyr654= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=kUyNvbMn; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="kUyNvbMn" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-8b5ccceb382so662919385a.1 for ; Wed, 17 Dec 2025 05:59:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1765979964; x=1766584764; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qNTY0Sqhk7+o+eguXb21G06qwMJTDsQYPt8jfcBPUac=; b=kUyNvbMnHl/q4RfCQxtLHxb+oikTq1pQxCkxw7UZ/XYDa8vA6DbIj58Roi12INE3yq KxlzP+lIugoBf9RvRC4o/FCE2jRSFhWUmcOf+fMC2UQW681ldXiuyIKswtyXoA5sMgCY nric+d4SuEpBkOPHqhICRB1wdEicmutxj/tqqSv2pbT3rnLs86Vz1uTP/uNfeIeIocT6 hmy/drd0TesCODayhEY0HddtSKa+O5ZA9TUX4CZ0W+HVz6Gl7Oi9IyCETtgPGet7oav+ //d3x3aTi31bhHrjtG6Z4O+4KItSUxER3VHT7CCD3aPHBrGh5l43MOn5bnnlCChMTye2 cgBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765979964; x=1766584764; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qNTY0Sqhk7+o+eguXb21G06qwMJTDsQYPt8jfcBPUac=; b=nAqSpdjgr3Avl29XlqUqo36pYz/vYBo2PY25Q2d9vRSI+Smr7YE4Y1LwVfvWOdEpSg m85VL/Rs1RFd199sauHKNiSG514o1/FTBrqhYQ2DuCvCowWnMjiPUw+Gzxry7VnDRmXm UekBlHaHY6DdJGJmsMA5w3l46gw7BwDwF8XsuJchFjzh4YzyvYZECpglGEM11xQXfAun Cg2GNRrSU+hwPmDb7yAn9aFN1xgMbw4b2ll2sWCFcnLOxOvqZbhzzj77ETj8zF9MppuZ 2ZLaihXXs0GrfA+GmbEWoUS6zk82s4OkrIVt5+JfLnOuSLo+cuJQnPowk+02yCB8uO0x zqnw== X-Forwarded-Encrypted: i=1; AJvYcCWKxKGPh79+amBp8NSdFAZa+vuU5ZofiT6SVm6//ETw5CwQ3cDM0dEWE9MjEWgpvP8GiOwO8nL5lDPVCis=@vger.kernel.org X-Gm-Message-State: AOJu0Yxb4SluH2MCXHXWMCExuzWHKVXWK6/UVpg9QFNKa87A8f4k2V5K /OnK4zImq/iDaLUZYCmV4AyOgzbdaRN/jz+WN+3tABtVs4EZl68mZaiXrSgkHLXVK9s= X-Gm-Gg: AY/fxX6eZo0uLj4XrziXBtaoKUYNrQy0W44Qz6XpC9Kr+8fHIHVX1g7MduT00u+zAxX GE3SQXF2kOrIJCFAJOxmeb/PodBDdZjjdNrO9bblXFutZpQK6U68ajnRvon09difj/X2PR9gkEx TXuJL1USsXz8YwCnyzNXFX4p0hJuCzHyMLuN7VdyWbwbEf2wf+7eHRId4J6MyPZGZJv05RZvpXr ct5aCUDtjwjKnQEH4sC1PfJ2PzgarOTRS7lXRdeOcQRn7Wq5HFyHDFRzlUHk30NnduZH5STC6V9 S66x/zWFc79nwVJmT4kUHhTOD/HXN+4AxmXEh+wAe3yDSsdlhoNicfp/iqK3zablBqYwbkFfy3r A8mGZIIC70muzliMNZjJDvm+0taDgk1pnGX5enrjckMIq31NwmTnIlPhDQTyKx4AnbeCs16fx2Y E3J/0swy3Sa6pNGJbwVIsswtfJn45nYHuIh178lj7j6iN23daRDUHMnsrnUqrLWz8EsQs= X-Google-Smtp-Source: AGHT+IExCGpmH3xSn76tDpf9mlwCNxEI0+dX+XnOw8fqnvLy+nODc5UF85vOKaQi2smq9F8P/d+5hQ== X-Received: by 2002:a05:620a:7108:b0:883:9b33:f6b6 with SMTP id af79cd13be357-8bb3a39bb23mr2288717785a.84.1765979964213; Wed, 17 Dec 2025 05:59:24 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8be31b559cdsm418416585a.30.2025.12.17.05.59.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 05:59:23 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vVs3m-00000000fU1-385b; Wed, 17 Dec 2025 09:59:22 -0400 Date: Wed, 17 Dec 2025 09:59:22 -0400 From: Jason Gunthorpe To: Mostafa Saleh Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, joro@8bytes.org, jean-philippe@linaro.org, praan@google.com, danielmentz@google.com, mark.rutland@arm.com, qperret@google.com, tabba@google.com Subject: Re: [PATCH v5 07/27] iommu/arm-smmu-v3: Move IDR parsing to common functions Message-ID: <20251217135922.GE31492@ziepe.ca> References: <20251117184815.1027271-1-smostafa@google.com> <20251117184815.1027271-8-smostafa@google.com> <20251128164816.GC812105@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Dec 12, 2025 at 03:42:15PM +0000, Mostafa Saleh wrote: > On Fri, Nov 28, 2025 at 12:48:16PM -0400, Jason Gunthorpe wrote: > > On Mon, Nov 17, 2025 at 06:47:54PM +0000, Mostafa Saleh wrote: > > > Move parsing of IDRs to functions so that it can be re-used > > > from the hypervisor. > > > > > > Signed-off-by: Mostafa Saleh > > > --- > > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 112 +++----------------- > > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 111 +++++++++++++++++++ > > > 2 files changed, 126 insertions(+), 97 deletions(-) > > > > I don't see that this slow path stuff needs to be inlined? > > > > +10 to my prior remark to not dump all the huge inlines in the main > > header. > > They are inline as they are defined in the header file, otherwise they > get defined multiple times. Put them in a shared C file Jason