From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E03971E0B86 for ; Wed, 17 Dec 2025 22:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766011972; cv=none; b=imOaNOI2bM8uGZ8iMyrQo/peaEAP2aJ5fvnv5nFKMAd50vyjEJy7v6O6Kb0zLt8Ml3WwH5RizPI8HxuidVBrbNMxHWBbPNU7gOdMZ6AgRhL0/QRt62kjqBsJ4gwJw1kcNPyEABQHkIYiXq5pJvUoly+tsETv0UjW339d+3QB0eA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766011972; c=relaxed/simple; bh=dXzAjuZST5taHyAlqJWpBxtqIGIfEewCcsGF41GgIWI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=J4JTmnYHeHBRBpqcPUUh1RY//8EVHGfq0gxGTkGj/HDjp6ggQv0p+ULM4L+etWmGHzt6VPepePMH9Bu7xFAi/YQKns/+aBjtO5ukP9TF3tADrZ48Lel4ua0ktapeXamCO13ntmI7jYwHhlG4YtdJOllRd1CusC7Q4/+HcXSwgQo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZlYkTR7U; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZlYkTR7U" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-42fbc305914so4194647f8f.0 for ; Wed, 17 Dec 2025 14:52:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766011969; x=1766616769; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=HGPp81slurEQiCKzhi07hN+sNzZ7utSqwlfER5CZSGc=; b=ZlYkTR7U46tar7sbRBj7WZWxL8/VuzENZqHtXSexdp1oro/R+rwXFzwOWeeu7LwkNs S5fHFe26da+JAvNu5msWxLRX5UxkBIk1w2fDqTVwOaCLPGgu+UgtTBPxR0LTXsB8qMaR +EKj8559Z0oVhDuXP53cFTJW+92Tli0gr8jLVi7TngG32hE+qh+Dcf3ZXvk5m/qjuB28 zYnr8jLe92rkoHsOnA0fKRv4CpQ+CzxHONEqPb/ZSTQTlI3t/IBLiuZAFzuxTRrRZ76j PjYxN09UHFMtH6Ilh3g2KwBMXEUHOrnydILnOX8JXxNnc1oE3w1meGDnkezDTCtysg4e Q7fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766011969; x=1766616769; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HGPp81slurEQiCKzhi07hN+sNzZ7utSqwlfER5CZSGc=; b=GwxVUcoy2L0tg9VlVAOxwyMr36qrClbgvjEWcoQK7k0098vTsuS4P0cUmmvkY5upPq sBWD0MkNLn2QTe6F/xcybDKEiWdgzDyos260NkrlL8I6DzuHfB6bz5oIIxnbm1u01bmR WeZBxAfaOaGmgrmlF0IXjf5Yq7L7uhL+qThkKxXyINUidKBnm8UEG6C1XzYc9+4e9SP9 +CRgXHoSRwlkiMSTxYJqCDg+gzNlN+Z3Te7+mMWa6qMwWLqkbGOFMQsLZd+wnAnZNAFV iJ0jw9iXnyzAi55qrcYGg9xGTWZZyBo8GULbcIxfeU3rXLnmo9VSRLVvZsAvB2dhtsur E5kg== X-Forwarded-Encrypted: i=1; AJvYcCUq6pzv6HW9HUV1Tut0I5QVeqy4M5LL0Ckmt6WCcQsMPmk7C9T3x9b+22wJQge15cm38TqcoLjWkyc/1+o=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0F4HkWy6HkMAwQkphOeCyI1WowGcn5yWYQfuCai5ZjJmkL+mV nuBnw7oKp9i9KGWFhM4LxQFdEbGiUCcetb1jDE85vwbGIt7tHvk/sCuB X-Gm-Gg: AY/fxX5K5RDq3y7+mrro5/mLLBmyXFqswnvIQ+xpKes3WXewPtz2qRYi77bGwj02xjh MSqSo7svQ7K4oCxnruQ8xAHo38DZkh83XIIGHHz5iSGAKNSgXxzV5jGVpWk1CSz29pnslmVLsLh ghAagK3NY8s2IE9KD5/OWEX0+Tfxb1gQ2cdFCqVyvAyCFKmaXaFf/tshUpChgkKIC4sl5z8q9qC Y5PVSr3XeFYFQ2I96CnYZ13n6EBDNQdggD7pagi+AklyL6mAwHFfD975pgt/FnovRCEet27Ti8G Ox0fExFDVYlwK9Nf6JzNolnX05lEU+zAsnyV2MpBAUj9dfjXkKSbL1tpVWK0gI8e1LfzArWg6eB 8ZqksAzuvq62/Vlr3/vWf1l7KgGH7AkXC2I9yOzMTpRxd2s45Y3p1mjERnrlNCrb5NtpfnZ+h+0 ZOued4P3XdgR2hu/OHuk6qJd/kKFdc6gq6Ha3yKFZEW8gs3UpG0Qfs X-Google-Smtp-Source: AGHT+IFHracCeKFQUGLufy+gAUMi7FrrgHnQjkM7P0uiBL8gQC6IuWLanr1sVMzxU6eIKSkuIoFwNw== X-Received: by 2002:a05:6000:4010:b0:430:f1d3:f96 with SMTP id ffacd0b85a97d-430f1d31a78mr16655611f8f.6.1766011969160; Wed, 17 Dec 2025 14:52:49 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324498fbdfsm1420841f8f.26.2025.12.17.14.52.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 14:52:48 -0800 (PST) Date: Wed, 17 Dec 2025 22:52:47 +0000 From: David Laight To: Rosen Penev Cc: linux-gpio@vger.kernel.org, Linus Walleij , Bartosz Golaszewski , linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH] gpio: realtek-otto: use unsigned long Message-ID: <20251217225247.5873449e@pumpkin> In-Reply-To: <20251217202331.9449-1-rosenp@gmail.com> References: <20251217202331.9449-1-rosenp@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 17 Dec 2025 12:23:31 -0800 Rosen Penev wrote: > Fixes compilation on 64-bit platforms as pointers need a larger type. Not a good description... > > Change device_get_match_data to of variant. The data is obtained through > OF anyway. > > Signed-off-by: Rosen Penev > --- > drivers/gpio/gpio-realtek-otto.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-realtek-otto.c b/drivers/gpio/gpio-realtek-otto.c > index e6694d5d1696..e9c89b191989 100644 > --- a/drivers/gpio/gpio-realtek-otto.c > +++ b/drivers/gpio/gpio-realtek-otto.c > @@ -360,7 +360,7 @@ static int realtek_gpio_probe(struct platform_device *pdev) > struct gpio_generic_chip_config config; > struct device *dev = &pdev->dev; > unsigned long gen_gc_flags; > - unsigned int dev_flags; > + unsigned long dev_flags; You don't need to change the type of the variable, just the cast. David > struct gpio_irq_chip *girq; > struct realtek_gpio_ctrl *ctrl; > struct resource *res; > @@ -372,7 +372,7 @@ static int realtek_gpio_probe(struct platform_device *pdev) > if (!ctrl) > return -ENOMEM; > > - dev_flags = (unsigned int) device_get_match_data(dev); > + dev_flags = (unsigned long) of_device_get_match_data(dev); > > ngpios = REALTEK_GPIO_MAX; > of_property_read_u32(dev->of_node, "ngpios", &ngpios);