mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: muhammadamirulasyraf.mohamadjamian@altera.com
Cc: Guenter Roeck <linux@roeck-us.net>,
	linux-hwmon@vger.kernel.org,  Dinh Nguyen <dinguyen@kernel.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Ang Tien Sung <tien.sung.ang@altera.com>,
	 Khairul Anuar Romli <khairul.anuar.romli@altera.com>
Subject: Re: [PATCH v1 2/5] dt-bindings: firmware: svc: add hwmon property
Date: Thu, 18 Dec 2025 09:26:49 +0100	[thread overview]
Message-ID: <20251218-imported-satisfied-beetle-ace590@quoll> (raw)
In-Reply-To: <20251216064926.15817-3-muhammadamirulasyraf.mohamadjamian@altera.com>

On Mon, Dec 15, 2025 at 10:49:23PM -0800, muhammadamirulasyraf.mohamadjamian@altera.com wrote:
> From: Muhammad Amirul Asyraf Mohamad Jamian <muhammad.amirul.asyraf.mohamad.jamian@altera.com>
> 
> Altera SoCFPGA support hardware monitor feature through mailbox. Hence,
> hwmon property has to be added to the DT to enable the feature beside the
> hwmon bindings and driver.
> 
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> Signed-off-by: Muhammad Amirul Asyraf Mohamad Jamian <muhammad.amirul.asyraf.mohamad.jamian@altera.com>
> ---
>  .../devicetree/bindings/firmware/intel,stratix10-svc.yaml     | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
> index b42cfa78b28b..4767904c7b76 100644
> --- a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
> +++ b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
> @@ -62,6 +62,10 @@ properties:
>      $ref: /schemas/fpga/intel,stratix10-soc-fpga-mgr.yaml
>      description: Optional child node for fpga manager to perform fabric configuration.
>  
> +  hwmon:
> +    $ref: /schemas/hwmon/altr,socfpga-hwmon.yaml

This cannot be applied alone and you did not describe merging
dependencies anywhere.

Squash the patches or be explicit how this must be merged.

Other patches from Altera have exactly the same problem, so you keep
repeating the same.


Best regards,
Krzysztof


  reply	other threads:[~2025-12-18  8:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16  6:49 [PATCH v1 0/5] hwmon: Add support for Altera SoCFPGA hardware monitoring muhammadamirulasyraf.mohamadjamian
2025-12-16  6:49 ` [PATCH v1 1/5] dt-bindings: hwmon: add altr,socfpga-hwmon.yaml binding muhammadamirulasyraf.mohamadjamian
2025-12-18  8:25   ` Krzysztof Kozlowski
2025-12-18  9:57     ` Mohamad Jamian, Muhammad Amirul Asyraf
2025-12-16  6:49 ` [PATCH v1 2/5] dt-bindings: firmware: svc: add hwmon property muhammadamirulasyraf.mohamadjamian
2025-12-18  8:26   ` Krzysztof Kozlowski [this message]
2025-12-18  9:57     ` Mohamad Jamian, Muhammad Amirul Asyraf
2025-12-16  6:49 ` [PATCH v1 3/5] hwmon: (altr-hwmon): Add initial support for SoCFPGA muhammadamirulasyraf.mohamadjamian
2025-12-18  8:29   ` Krzysztof Kozlowski
2025-12-18  9:57     ` Mohamad Jamian, Muhammad Amirul Asyraf
2025-12-22 11:34   ` kernel test robot
2025-12-16  6:49 ` [PATCH v1 4/5] arm64: dts: socfpga: stratix10: Add hwmon node muhammadamirulasyraf.mohamadjamian
2025-12-16  6:49 ` [PATCH v1 5/5] arm64: dts: socfpga: agilex: " muhammadamirulasyraf.mohamadjamian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251218-imported-satisfied-beetle-ace590@quoll \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=khairul.anuar.romli@altera.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=muhammadamirulasyraf.mohamadjamian@altera.com \
    --cc=robh@kernel.org \
    --cc=tien.sung.ang@altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®