From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA61632E73A for ; Thu, 18 Dec 2025 07:19:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766042379; cv=none; b=TYGBDH9itCyoVS1BdmA6bJ+lf6rsK/n1t0W39HGZPGDVpW+XZQyuBQynlvw2m15mhwjr4ehOHfGWvjWiVYyma2EcCqohjbsP7n0tC8nAQn61JBYbcOKegsuF2yXQDEKWfiYa8xzKfKkw+LvSs+nzeRqCwhrIfojwYoapQ34ZzxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766042379; c=relaxed/simple; bh=2XAZN4yfY+YxnTEtRiXRky2l9hu9s+c9ZZ5klJhe86k=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=p6Mafdfe4KLYIMaJwfnS0Xb204LAnuK9NX5HdLMQZlAbTt7MRr1WQIZMG8VI8riDmIWNtkiTz+OEX/SOTXlTfia9GA2ciy6svl3V70HHChJunRZUZcGmguYbSt8zLS4NPtHVjYvhCFBSbAvyTmQdrMBx3Bsp/ISNp/4bnAeX1dw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PcFX2eBH; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PcFX2eBH" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47a95efd2ceso2367955e9.2 for ; Wed, 17 Dec 2025 23:19:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766042376; x=1766647176; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=BgDX8RRTzLlxHeg4crYid4bpMw6ddH0fqfjWnakhqlo=; b=PcFX2eBHub7vBH0Owflg7GfgwE3egpZsklDNSykkZ/CWcXqWuScVDWJNFa7/NxcAK/ 3KXJYPYNJOJ/rR+Q12oSH79JgMu1UYrGtIKbfxikY41zyPIWHLuHoZTO67zSb6GATtth UkLnjjVEE9JeJKrQiA15OcnU2/GASxuBNIDqRSBuOErG6xf1Os9d46D8cd41aARUAkXK SiE+/diU2g3XHr5Bcm1ZOs8JtgOc/DP/j0/UtBBc72iupbu5P9G7UQQ8iw0LHE/kfjMT DSstCbTAEBE0Mvwis7T4T2rmqmcVXDnzMMP6H1jU+SYrsPsV2LJLiMx2sTnAw6/3yEIH CS1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766042376; x=1766647176; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BgDX8RRTzLlxHeg4crYid4bpMw6ddH0fqfjWnakhqlo=; b=Is5K5E8LWdO8f3mpx3tEWfU2eE41w4dcXwtzkUI1ckea/WXVAophWOkjNIu2RsWKT9 E8OYedsYcU8Ja+unhmy7atu3PCr3LM/rmMB+kLDsVRu7LGSWFuDYNi/Zq0HI3/l5TeSH kBI5UC7+4PGx/bYviovKAipaY6abmFhifNc5F5Tb4/0JRY+Z6H4ATpUmr0ywuO77qODA VhT48q+IzNYEvnLnoVws8454wNtoDwz6z4qTD/UQXXXSu5Tl3NxZ4Gjh3f9HWigWr7lC BuOyAABY7zCuT/uPCkBmN6D1uSfS1yO3YVzNubWyEB0a1XwDslDZtjHJQX4zVg97aM9/ UAJg== X-Forwarded-Encrypted: i=1; AJvYcCVExdiIyiAPhDFRO1kUdVyIfp+nd0+XSOccS1r2qsKmJLqqgbm3cFOE07+DuGE3Nu7ORw0DrBDn4Xugx84=@vger.kernel.org X-Gm-Message-State: AOJu0Yyj3/hMhE5zVufdyu7ARVlAM29Xj5bwFJ7VG+hl1kYv+wOTHKCv 45tnYInAXLEV1r1Y4luYNyLIy/+QkSA1dw0ma6sUNKYBIP0pQl49LOfrgWqA7n4MsXk= X-Gm-Gg: AY/fxX4jnQqdocAE19lCgWGKvR6DMAr5fKR5gI/CHP+7z7HRhVxdGkNVUfo8/YWfdTC dysXr+tJlNrhro2OszdeCGqDzbGqPIqrzqLI8V7z99J+Z31xdN4vTmBiYzy9wmaVYozT4UufNpx 2VLLhkkRR1JHE9wAP3TzGvo/h5rSiiFNvOR9LoeV49eEr4CjuAZLcBNmprfWeM3zM3XW6Pdh8gI h1RiPfoZDxfGng2EzqLb05j7IVl5VnkK+GFbJZ3I4r/VcmC3iU4PBpCgr9yOaFQAVk3/m5WbKhk W9tUqH+1Qm9fS9ruenLdx7i6lXEAWpqUwawOzhIwglSP2kU8sZOgpZNRQhg6RHlukRTIFbwrk8K a/XFU/C9psnOhDm1qrCMvkPfkfnq+1KhAV9NIpE75u4XPHj9//7v6dLdBOlqkL5VjHYbq5DNX7L OAESWcVpeoeU7AjZ4E X-Google-Smtp-Source: AGHT+IGwbf7mQ1WdrnPH46HyySiH44r9KZkX+tyRiOr/VP6+a5FY5gNWMsktIsul821W7jrPcYjxPQ== X-Received: by 2002:a05:600c:3b84:b0:477:b0b9:3129 with SMTP id 5b1f17b1804b1-47a8f89babcmr220630665e9.3.1766042375908; Wed, 17 Dec 2025 23:19:35 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be3278439sm24779915e9.13.2025.12.17.23.19.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 23:19:35 -0800 (PST) Date: Thu, 18 Dec 2025 10:19:32 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Herbert Xu Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org Subject: drivers/crypto/ti/dthev2-common.c:44 dthe_get_dev() warn: can 'dev_data' even be NULL? Message-ID: <202512181322.nBkDZbGb-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Herbert, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: ea1013c1539270e372fc99854bc6e4d94eaeff66 commit: 35c5097f737a164b3afe23d07698db95061f0db8 crypto: ti - Enable compile testing for dthev2 config: s390-randconfig-r071-20251217 (https://download.01.org/0day-ci/archive/20251218/202512181322.nBkDZbGb-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 14.3.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202512181322.nBkDZbGb-lkp@intel.com/ smatch warnings: drivers/crypto/ti/dthev2-common.c:44 dthe_get_dev() warn: can 'dev_data' even be NULL? vim +/dev_data +44 drivers/crypto/ti/dthev2-common.c 52f641bc63a4665 T Pratham 2025-08-20 35 struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) 52f641bc63a4665 T Pratham 2025-08-20 36 { 52f641bc63a4665 T Pratham 2025-08-20 37 struct dthe_data *dev_data; 52f641bc63a4665 T Pratham 2025-08-20 38 52f641bc63a4665 T Pratham 2025-08-20 39 if (ctx->dev_data) 52f641bc63a4665 T Pratham 2025-08-20 40 return ctx->dev_data; 52f641bc63a4665 T Pratham 2025-08-20 41 52f641bc63a4665 T Pratham 2025-08-20 42 spin_lock_bh(&dthe_dev_list.lock); 52f641bc63a4665 T Pratham 2025-08-20 43 dev_data = list_first_entry(&dthe_dev_list.dev_list, struct dthe_data, list); 52f641bc63a4665 T Pratham 2025-08-20 @44 if (dev_data) 52f641bc63a4665 T Pratham 2025-08-20 45 list_move_tail(&dev_data->list, &dthe_dev_list.dev_list); dev_data can't be NULL. Probably this should use list_first_entry_or_null() 52f641bc63a4665 T Pratham 2025-08-20 46 spin_unlock_bh(&dthe_dev_list.lock); 52f641bc63a4665 T Pratham 2025-08-20 47 52f641bc63a4665 T Pratham 2025-08-20 48 return dev_data; 52f641bc63a4665 T Pratham 2025-08-20 49 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki