From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011068.outbound.protection.outlook.com [52.101.62.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CAB22D97A6 for ; Thu, 18 Dec 2025 15:43:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.68 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766072626; cv=fail; b=UW0hx9cDdLuAAwYzj3lkUzU/CZaN7+NXOESwsPiXGQUKkDo5Me0MMSDwqgON6Bs9noKx3+1YXbSTMw8BFR7toL1QZ9utTVZDLjlo+edWNoaXX780Ux2g4J861G1QevLeHUkivS8jMHKwXJiW8myPjXBxz4SHmq4SZcxuMB82Gk4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766072626; c=relaxed/simple; bh=pftr3TTBYt3xxoB346E2QPz1wO8eVA2CWPcrR6HFZXQ=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=jsFOtuFNxrp2eW2uRSDJZCURwcfkM0YmzwD5bWKRECmbZdi/NoV9lSl6h37SdKwG+80rzqKDLJ+ZBt/s1G9djMZfV6QFhBamUxkIjweXvtDF6odOvkPFCq6C9Tw4ydMdCmLMabkgTUSEpBZjgLzTFMkriGrFC5WpSeJAzqQ23x4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ZDGSOqEs; arc=fail smtp.client-ip=52.101.62.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ZDGSOqEs" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cMNMBrXVqBUkXFIm8jDUin5f/zZNyNz81hycNdxuSut70Lp40Ng6AKVcH+eSi9Vqg95X4HG4RcRDi8kCdkQfAx79rY/EyLcxybbGALVIvea+gRfRYGcJuNyuhYxmkFbtGiGo9PJD1JUAMog9d58xZU5IAtQXeU6ntQy4QX6uNAauhs3kvSLcNRcU6v+xbPFhzRx71ah3ykKIw6HeiPWJWl3HDo9qVilZej+i8SPN9Sht8NzSKixfLO6mCO3M2CyhnXCESz6s2/T5RQPoTBn9o5LvORW2Xrkee8rrsHsbF9j3iXeH5qz0wY4xPzIkmVuJ0EA6HdPpdtwn4RRpKMJp4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ppl7mfBEyQg5ARFMKvu09MfqZ+LANEodY0ODq//7bLY=; b=qUdJ6LMZKQ89EGyU/TpXQPinCZgw+N3vC7v0k73kijwTdeRNFYkArV/iT29kJelkLFVd0yDVIVCdSHZbEldkB57CfD6vHjLWQgOaOAxV5ujamnG63QRfQ0F6zTdmJ/M7jab6dRphQOUTHSRGp0MIzMbsfB5hFpP7+yMb/9KsLdmfp6DctbckpV+qazASwEEmdiuNDPSxFNfyODI/uU6T9JrIyrHEpzUFKauHiZx9chj0I2UFVwgdijpJO/QG3pdQXgHpVJpyzYzmfATX5LtOhkJOBCNnQRqAR7IULpeJBS7k/2Of9P9f6Q1BO2bUJKh1Y0BVwah5K8nUD+oYeJy+oQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ppl7mfBEyQg5ARFMKvu09MfqZ+LANEodY0ODq//7bLY=; b=ZDGSOqEsYRMh9Ovb4wX8RiIFrGw9E7V+y8zXXmt5395KDmmThJCKKOavk1LnWBbTT/KNV8Z+l7tjR2kfnnABO3wOk6Vv4PVomUhv5g8tECPmgCdumQsOYtLV3x35hD5N91urhZAsCBh6LGmTVDiQOTVfxKnneKoiyq7LIeP9904= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CY5PR12MB6369.namprd12.prod.outlook.com (2603:10b6:930:21::10) by BY5PR12MB4305.namprd12.prod.outlook.com (2603:10b6:a03:213::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Thu, 18 Dec 2025 15:43:30 +0000 Received: from CY5PR12MB6369.namprd12.prod.outlook.com ([fe80::d4c1:1fcc:3bff:eea6]) by CY5PR12MB6369.namprd12.prod.outlook.com ([fe80::d4c1:1fcc:3bff:eea6%4]) with mapi id 15.20.9434.001; Thu, 18 Dec 2025 15:43:30 +0000 Date: Thu, 18 Dec 2025 10:43:25 -0500 From: Yazen Ghannam To: Mario Limonciello Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Jean Delvare , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/7] firmware: dmi: Read additional information when decoding DMI table Message-ID: <20251218154325.GB1346661@yaz-khff2.amd.com> References: <20251216123354.9219-1-superm1@kernel.org> <20251216123354.9219-4-superm1@kernel.org> <20251217210352.GA1263950@yaz-khff2.amd.com> <78dbc0eb-37a3-468d-b43e-f5a5a06ad8fe@kernel.org> <20251217212134.GD1263950@yaz-khff2.amd.com> <7d19e83a-9017-4058-8993-53fa1a9bd64f@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d19e83a-9017-4058-8993-53fa1a9bd64f@kernel.org> X-ClientProxiedBy: BL1P221CA0005.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:2c5::19) To CY5PR12MB6369.namprd12.prod.outlook.com (2603:10b6:930:21::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY5PR12MB6369:EE_|BY5PR12MB4305:EE_ X-MS-Office365-Filtering-Correlation-Id: a2719e06-e30f-4fa5-2c31-08de3e4c315b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?JsanywxePTak4/ii97OWN9Dd20RvNGP+XY6JGyNvEh1yBoHmXyIA0o0zzKI8?= =?us-ascii?Q?9exm/Pky94soWKalTAY+qsDMyp6ploTzVIS8gmiFfsZ/4Wx9BJJPPdTjBbkx?= =?us-ascii?Q?Zs89VauUK3lLMb8m/gftcrT+y46WEmfjcXADYAWUaBz1KNSByBP3P9F+DZd6?= =?us-ascii?Q?dG56sfTkGy/xx13rL5UrF6pfBuNN6tstMP2DT69q0TIIfby6w+SDvyJbqy8D?= =?us-ascii?Q?+WPjUhAXMm+dBDQ1r/buzr1bDqA5FwHgTQHTjVWPKVCCYUFLqwyEmqyVIZ8r?= =?us-ascii?Q?I7NDYY6YK0MfFIL3K9EAa4EqahOl0LJI3o4l20bUzmGx88w2/VfxMeN9bIhv?= =?us-ascii?Q?jx96SpOBF7s2WTkcWphiisnobxHxT6qDi37EVuo6S7/1R9F+zg4B7W4u1YIZ?= =?us-ascii?Q?NbIW/krETg1iNzEec/vgLI+ABiV6jJdBItZAjH7ChvtlhYlMa0ftgkeoAzra?= =?us-ascii?Q?WmK3qbcouT4YtV37zfD1pC8UOCPfc8XSZK3M/UqHwiQ7oc0rGNNZN896C2cU?= =?us-ascii?Q?nDkXlkhpjOnm5VRXg8tjqg/V1KUrWJTPmRpj0DGelq1pMfBhWP5djOtj3/zg?= =?us-ascii?Q?I1Gau+9smw9rDoiP7OQE8Kr3VMpcDQUMltMfzqzLLj27CFGi1TdT4D9svjw+?= =?us-ascii?Q?QUf5FN7fvz6/bqzHyZ/yZvF+LSZS8K61YGXZ4OXkvRgJDmz8xPNWp8NvhBMg?= =?us-ascii?Q?IZfUTKCrk65PxO79L1JhH9MdQ7LHEcLrUsscenQfN/fp94lTn7ZUwi49FL8J?= =?us-ascii?Q?CTjoZAAbvyzYWxXRxdcEFAZLxU1duxKMPqbCCD0IYO8rJGCBzf3wC1sTaE4I?= =?us-ascii?Q?YXPICOj7iBOkmhoqMgZcgCFhno97CHI+Xk4G+azJRUCGcfuiYSNmrgNKari8?= =?us-ascii?Q?pXVYJ+IlHLny0uDmJCxHpbilMTXwU36Alcery5QSjQm5FQ+2dCW6xaxCI4QP?= =?us-ascii?Q?77BY+zKZi6+H4juKomhikt87asLtgvJa4XdECCPC/E8+UFNKN9Ersh/h+dmQ?= =?us-ascii?Q?WWPWxtFT7E/RIkP5hWXOy+/9xf5oexij43+SRN5ts3qd61XaewTAWa9Z2Yij?= =?us-ascii?Q?auChEWDUiFDdZvMAJqRUmJ6Z8FW/aU7f8SOsvg3RLfzFJmcDsGNJq7aUqZiV?= =?us-ascii?Q?/yrmq1VG4eym10S4Foc82EUfBDg4j0a6a9XkRiDdtdbNidB8EOGs6HD3HYcs?= =?us-ascii?Q?ODsNI9q1PjwH4I/LwbJ1WyaMw2EWVTadHgtqHMZ87PtGXj79+r9a3x9ABTs9?= =?us-ascii?Q?PmmP3ySnuHTn7x1EMTPa6mHmDtL75sgg/N3VjX3ijM/9D/4oGz1C51YbQXtP?= =?us-ascii?Q?tUENN5CHLhRJ4wUSlPr7mFaJ5yD4MLq+okhcYW1+nML2+Fh0RlPyXKD4rl3N?= =?us-ascii?Q?KkzreQPP+Cdsx0WsH8hB5DQOSgWIKR25gA96g11m6jvmbcUoSeqhtMuZOjxr?= =?us-ascii?Q?17pMHkg9KWxMP1ov3rSKkGSsW9cBZjyD?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY5PR12MB6369.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kYuf4b4SKcV/BbxyyGuW+reVrTGtKinheFhGz4gUK0GdtlWjkworO3LTPu6t?= =?us-ascii?Q?gVdQdXEAOOeRJrvlDB/3vi6nOmdGBOiA0EgVHOuaSkHV2Kl1Kykxs2OTnazb?= =?us-ascii?Q?/cMj/7/lY8DnbvmHHNxqCwaDMVOjS/qcyP+iMaDT2GmqHEY/gHEd3ioEpTTD?= =?us-ascii?Q?sYVK6GVKqMMiTvy7W/JgTouHmTK6THKFEBkM+YHFAR8szHW+vnyjfYJ5iAxS?= =?us-ascii?Q?9spP1KwhoMAMX1+iJ3aU0O55yHKTsC7JEZPL/8kC06UeSiGHOV5Osj7d334i?= =?us-ascii?Q?o18bRkDITBwymeUdVoKTIKZtAu3eqOXZdWsRBgCXqQVaLISmh94uykF8CLiR?= =?us-ascii?Q?bV1WF3I2MlhDfsxnyn+z3e0ig6udVmfMWgXS6yWAsMf5YOhYv+pvOPp9zUdz?= =?us-ascii?Q?jeqVnXSFsF+4fD/oWgi/KKsITbgPvvM72bfKpx4RSjiUcf1yWvANyguuabTC?= =?us-ascii?Q?Cm01ZYRhg+a+6lwyy2SA06cnsIQRgF7osBFF0lKlvDqaWLwUjx/Qt5CPi1yq?= =?us-ascii?Q?ld9c8sXz/DaUb46y5y51aeP9+xlVcZ57SK3QRpDnCrwYZh29Swl+EcMn9tco?= =?us-ascii?Q?lvP6w/Rg0Foj8OZvvIPQwGyCcC8rEUOw6OBYy0BT2/tkbtkQxpDqy4B4Ovo9?= =?us-ascii?Q?996BtCdrsiDuIxEHN/xvrjpEteq0Gf3eaNovV3R+4AJb0mtbV5FXkPx8h4Tl?= =?us-ascii?Q?yd6lLFpuKG0qktmo8d9ABHGPjGak2LdbzoV9nA5Kdjn08HFNSYPxhXaAWDtk?= =?us-ascii?Q?vNV0Z+SGOezG+ikjaNJAZQfA7xrVT+nE3zwhtHlcXJE8w6ayOtT6TcHpRPHy?= =?us-ascii?Q?a4fFm9FPSuIVePn42cNkR4BE3VIt1oQ7m15yEpoJfy8rj6DUwS2xQzlNl84j?= =?us-ascii?Q?hmL8P/xoDpRWiXsnRjgFRDAX3jdHubqPVjm0FGWQXG7q3C05n2P3JxWUoLg0?= =?us-ascii?Q?z4zBPNNzqd2wIyRV4Ue1Cwm28E4aK0hYoGBIhJZtK5RMXqbvZbLCZ4vNjSuc?= =?us-ascii?Q?VQZlNZO4G/yepFR4npf/v6m/1NXOiLZVILC3puk2ErNqGrOVLVb9ky+LMn4/?= =?us-ascii?Q?5267aTx+m8rqayj4hEmmpUuV3j8pQ9MZTWAYLNw1Cd86jYSuqIlXkYfk+zGw?= =?us-ascii?Q?QLQWF58Aza9M61JDamP/8UY4vopWF+BTkhgRPfiBq2fQHb7Fd9U3B/VeIkW0?= =?us-ascii?Q?ee4pGTK38jcPnxAK5f5cCf8KHchTg1P+8+Envf0KjX/UnIBRC7CxwdQuGYCj?= =?us-ascii?Q?RXYbLk3E+DoqNaPIsvpTSDodCDPXpsVdlLO36xgNLh+1GnMybMz628hOklq/?= =?us-ascii?Q?h97KUod2wIgC4d8yJtC0Xfc0v3UREanXHM7+IowbjaHM/FITgQWI+s5W5Xjw?= =?us-ascii?Q?FDiluIafVwKSwz+w6Y3G0yIi5X1DXNKcKJrIl+SWOEDVErYlm+6Vx3+kopwP?= =?us-ascii?Q?KO2ZCnvFWatieToSevdfpd/iJxX02LwQNOkhfTa2oP5EdzIemi2mZpVPoSht?= =?us-ascii?Q?r/8b9taU2nCszI7UAjsfrABxcnewrAaH4/HiZhskNKgpmExCekdA6poJDAi6?= =?us-ascii?Q?R96RF984zCpPmIQ4n1jIRhD54ROvfjfEPmxfy/mI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2719e06-e30f-4fa5-2c31-08de3e4c315b X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6369.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2025 15:43:30.2476 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LBlWXTVFryi/PooReiSXXn+bH0mOyWftg8xG/ZhScG5SsFU9TrYZUDBQ/6yx/ScVMe+GeBY/Hn8Pi1wNP/EWhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4305 On Wed, Dec 17, 2025 at 03:23:10PM -0600, Mario Limonciello wrote: > On 12/17/25 3:21 PM, Yazen Ghannam wrote: > > On Wed, Dec 17, 2025 at 03:09:33PM -0600, Mario Limonciello wrote: > > > On 12/17/25 3:03 PM, Yazen Ghannam wrote: > > > > On Tue, Dec 16, 2025 at 06:33:50AM -0600, Mario Limonciello (AMD) wrote: > > > > > Type 40 entries (Additional information) are summarized in section > > > > > 7.41 as part of the SMBIOS specification. Save these entries when > > > > > decoding the DMI tables. > > > > > > > > > > > > > Why can't an interested user just use dmidecode? > > > > > > > > Thanks, > > > > Yazen > > > > > > They could. The reason for doing it in this series is the same reason for > > > the one that we did the S5 bit. > > > > > > It shows up in the logs, you can tie regressions to the AGESA version at > > > specifically at the time of the failure if they've done BIOS updates since > > > then. > > > > Yes, right. Sorry, I mixed this up with the debugfs patch. > > > > We need to save it here so the init code can find it. > > > > But why do we need a debugfs entry for it? > > Ah. That one I don't feel strongly about. > > I used it when I was getting the series working and it felt like a waste to > toss. Oh okay. Yeah, maybe "don't feel strongly about it" is a good reason to drop it. Just trying to think like a more frugal reviewer. :) Thanks, Yazen