From: David Sterba <dsterba@suse.cz>
To: Qiang Ma <maqianga@uniontech.com>
Cc: clm@fb.com, dsterba@suse.com, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: Fix -Wmaybe-uninitialized warning
Date: Thu, 18 Dec 2025 21:37:43 +0100 [thread overview]
Message-ID: <20251218203743.GU3195@twin.jikos.cz> (raw)
In-Reply-To: <20251218081618.2038279-1-maqianga@uniontech.com>
On Thu, Dec 18, 2025 at 04:16:18PM +0800, Qiang Ma wrote:
> Fix a -Wmaybe-uninitialized warning by initializing
> the variable to NULL.
>
> $ make CFLAGS_tree-log.o=-Wmaybe-uninitialized
>
> In file included from fs/btrfs/ctree.h:21,
> from fs/btrfs/tree-log.c:12:
> fs/btrfs/accessors.h: In function 'replay_one_buffer':
> fs/btrfs/accessors.h:66:16: warning: 'inode_item' may be used uninitialized [-Wmaybe-uninitialized]
> 66 | return btrfs_get_##bits(eb, s, offsetof(type, member)); \
> | ^~~~~~~~~~
> fs/btrfs/tree-log.c:2803:42: note: 'inode_item' declared here
> 2803 | struct btrfs_inode_item *inode_item;
> | ^~~~~~~~~~
>
> Warning was found when compiling using loongarch64-gcc 12.3.1.
We have the -Wmaybe-uninitialized warning enabled per fs/btrfs/
directory, there are no other known reports fixing the uninitialized
inode_item so this might be specific to loongarch gcc 12.x. I'll add the
patch to for-next as we still want to get all the warnings fixed, thanks.
next prev parent reply other threads:[~2025-12-18 20:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 8:16 Qiang Ma
2025-12-18 20:37 ` David Sterba [this message]
2025-12-19 3:11 ` Qiang Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251218203743.GU3195@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maqianga@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®