From: Francesco Dolcini <francesco@dolcini.it>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Parth Pancholi <parth.pancholi@toradex.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Dmitry Osipenko <digetx@gmail.com>
Subject: Re: [PATCH 4/7] drm/bridge: tc358768: Support non-continuous clock
Date: Fri, 19 Dec 2025 11:34:18 +0100 [thread overview]
Message-ID: <20251219103418.GD39796@francesco-nb> (raw)
In-Reply-To: <20251021-tc358768-v1-4-d590dc6a1a0c@ideasonboard.com>
On Tue, Oct 21, 2025 at 04:23:00PM +0300, Tomi Valkeinen wrote:
> The driver prints a warning if MIPI_DSI_CLOCK_NON_CONTINUOUS is set, and
> falls back to continuous clock mode. This was added in commit
> fbc5a90e82c1 ("drm/bridge: tc358768: Disable non-continuous clock mode").
>
> However, there have been multiple changes to the driver since then, and
> at least in my setup, non-continuous clock mode works: I can see an
> image on the panel, and I can see the clock lanes being non-continuous
> with an oscilloscope.
>
> So, let's enable MIPI_DSI_CLOCK_NON_CONTINUOUS support.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Cc: Dmitry Osipenko <digetx@gmail.com>
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
next prev parent reply other threads:[~2025-12-19 10:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 13:22 [PATCH 0/7] drm/bridge: tc358768: Long command support Tomi Valkeinen
2025-10-21 13:22 ` [PATCH 1/7] drm/bridge: tc358768: Fix typo in TC358768_DSI_CONTROL_DIS_MODE Tomi Valkeinen
2025-12-19 9:41 ` Francesco Dolcini
2025-10-21 13:22 ` [PATCH 2/7] drm/bridge: tc358768: Set pre_enable_prev_first for reverse order Tomi Valkeinen
2025-12-19 9:42 ` Francesco Dolcini
2025-10-21 13:22 ` [PATCH 3/7] drm/bridge: tc358768: Separate indirect register writes Tomi Valkeinen
2025-12-19 10:29 ` Francesco Dolcini
2025-10-21 13:23 ` [PATCH 4/7] drm/bridge: tc358768: Support non-continuous clock Tomi Valkeinen
2025-12-19 10:34 ` Francesco Dolcini [this message]
2025-10-21 13:23 ` [PATCH 5/7] drm/bridge: tc358768: Add LP mode command support Tomi Valkeinen
2025-12-19 10:37 ` Francesco Dolcini
2025-10-21 13:23 ` [PATCH 6/7] drm/bridge: tc358768: Separate video format config Tomi Valkeinen
2025-12-19 10:44 ` Francesco Dolcini
2025-10-21 13:23 ` [PATCH 7/7] drm/bridge: tc358768: Add support for long command tx via video buffer Tomi Valkeinen
2025-12-19 11:17 ` Francesco Dolcini
2025-11-10 16:27 ` [PATCH 0/7] drm/bridge: tc358768: Long command support João Paulo Gonçalves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251219103418.GD39796@francesco-nb \
--to=francesco@dolcini.it \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=francesco.dolcini@toradex.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=parth.pancholi@toradex.com \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®