From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 215C32EB5A6 for ; Fri, 19 Dec 2025 10:44:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.194.8.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766141065; cv=none; b=QzQ6tuWLzuLqRSVcEVTZKitUenmaf2DivI/B2eOlAWeSm2rSZo8OnUOlxoE6A0iVqPglH8Wq//cJ9TB/RPKVWVw6pPiigETu7wcB0RWZQKI3LpNmm7sPIYHbPYDBM8qjZk09t3hsYAH0sguKGhaMuPpf17Dz13HRF00Svt/01tk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766141065; c=relaxed/simple; bh=PueZ/DPwnrY7kZEN8OK45fr7KuDMl9PTYk7QZaGoSDc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kmIZ9n+bImt7GgjKvi/NEivP8I8B4t4kQqYHHa5tJ+Sa87Eph+H15nq/eMMTzdl09UUUtocyxLMztudBX7vo0d6a9PVz+pNfjMElQvfeHydGUjeCPyRYv4V7/ijmyp96sF/YUa/3tLzTZu48iOv8FdFfuSXRo3sHXDUWE74c3Po= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it; spf=pass smtp.mailfrom=dolcini.it; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b=Dr0raZbC; arc=none smtp.client-ip=217.194.8.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dolcini.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b="Dr0raZbC" Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id A24331FA97; Fri, 19 Dec 2025 11:44:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1766141062; bh=ygYhk4F/F4fhxwftKgOcsB4V9H6QAgiyK9zktEtsWUI=; h=From:To:Subject; b=Dr0raZbChInnpaLl3hfnMxlrpaGw7mu27dHn/ikvgql9B4JoUcCuQvbUPdwTJRA7o mW7rDKzpbSisj48RoVDCPa3M0WxTXcWHOnLzprCumzpB6ERCqJitbXQm/1mySR+ahP YN8gBIoMzNyauzkYozbU5vEbnyO5Xk+DmWFufgdKd17hAS2uXf66FNHcDJnnR+cmQM qgrKxpAHnUKZhBDiWUHlEnhqH3fvbkXrCX9dkAC/lADM9HTKJ/ih7R0CiZJ+50ULHo W4OukFLiZWKVD84wrGT50gFiAhWv7g+ajhLOBncfi3NvY/m/h3AX3TG5LgOEI7OiJ5 KwPN36M12ruFw== Date: Fri, 19 Dec 2025 11:44:20 +0100 From: Francesco Dolcini To: Tomi Valkeinen Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Parth Pancholi , Francesco Dolcini , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] drm/bridge: tc358768: Separate video format config Message-ID: <20251219104420.GF39796@francesco-nb> References: <20251021-tc358768-v1-0-d590dc6a1a0c@ideasonboard.com> <20251021-tc358768-v1-6-d590dc6a1a0c@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251021-tc358768-v1-6-d590dc6a1a0c@ideasonboard.com> On Tue, Oct 21, 2025 at 04:23:02PM +0300, Tomi Valkeinen wrote: > Sending long commands using the video buffer (to be implemented in > following patches) requires setting TC358768_DATAFMT and > TC358768_DSITX_DT registers for command transfer. The same registers > also need to be configured properly for video transfer. > > The long commands will be sent between the bridge's pre_enable() and > enable(), and currently we configure the registers for video transfer in > pre_enable(). Thus, they would be overwritten by the long command > transfer code. > > To prevent that from happening, set those registers for video transfer > in enable(), not in pre_enable(). > > Based on code from Parth Pancholi > > Signed-off-by: Tomi Valkeinen Reviewed-by: Francesco Dolcini