From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32F6718CC13 for ; Fri, 19 Dec 2025 10:54:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766141674; cv=none; b=Mx/16BTxFeBXkk/sB3l6k85xRtXbhFleJc57ScHmQx/zSy96pZQvc0ikjr0ai5kqnWgU/KQ34AMOhHlfo6Qx80VvnfRGFxJTtFmFW8UCM+pC3M8FgSGcnXnDN7PmuIfFw2D6y1qAYD5Ph8KcIsQfleQylCIgJ56oI7hT4BUM4FY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766141674; c=relaxed/simple; bh=PwQcMTxx/HxA8gx8WEPNw5Slq81aHbx/VE7sNTDPfZg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nT9smG30IqgPa3JUjso+tWpGutAeA8xt5tiyvQwwt4D73oxduldhKbV/cDKpwlloFdxXi1exbnvNVXBUea753fNCPYc9wknh+wlNQVwQLqqxy/l6UDL1Gmh/hgr1i05DG7OFwor1PjhkjHs6pQ5a2wd0IFc/EGlSiMjOhorodtM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=r6PZxLSg; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="r6PZxLSg" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QaCSzdGCAIBKimen6e2MsOVHIdJQW/XFztU1o88KUj4=; b=r6PZxLSgd9LMRDrmAfYKq6THIo eCdUN2XpH8e/xGrMxVcIRwW7968Pt+yMYTfJe5aBSP2jMBVnlOOYYLTC6BthXn9Al4UEDWNv3zMor XBtIM0VQgklbKQqORuJIr3X2yJhF7u2EyOMf7XtfhJUhcjkAQmEL586/RX0YJm6WNypTfpaXldSla OB1Vd93KQs3Z3RRd+AxSeZDM42r116trESEZsGMCxhUYUb8c/pZdOX0ejvhN7K4fdUTmWSeOqkxC3 ZgiwiV2z/p61Qi0X7QS/GW2894lOpTVBRSIRo1LPqoIvAg1Qm2BWV3VcKp3mKmrTQpm4rSq3tYgxf 3gNzUbig==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vWY7x-00000007Sd9-0BZW; Fri, 19 Dec 2025 10:54:29 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 92FDD30057C; Fri, 19 Dec 2025 11:54:28 +0100 (CET) Date: Fri, 19 Dec 2025 11:54:28 +0100 From: Peter Zijlstra To: Zhan Xusheng Cc: Ingo Molnar , linux-sched@vger.kernel.org, linux-kernel@vger.kernel.org, Zhan Xusheng Subject: Re: [PATCH 1/2] sched/fair: fix comma operator misuse in NUMA fault accounting Message-ID: <20251219105428.GD1132199@noisy.programming.kicks-ass.net> References: <20251219085005.50906-1-zhanxusheng@xiaomi.com> <20251219085005.50906-2-zhanxusheng@xiaomi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251219085005.50906-2-zhanxusheng@xiaomi.com> On Fri, Dec 19, 2025 at 04:50:04PM +0800, Zhan Xusheng wrote: > Replace the comma operator with separate statements when assigning > NUMA fault statistics. This improves readability and follows kernel > coding style. This is the only one of the lot I would remotely consider applying. The rest is just noise. Please don't do style patches. > > Signed-off-by: Zhan Xusheng > --- > kernel/sched/fair.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index da46c3164537..56dd655d9bc2 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -13957,7 +13957,7 @@ void show_numa_stats(struct task_struct *p, struct seq_file *m) > tpf = p->numa_faults[task_faults_idx(NUMA_MEM, node, 1)]; > } > if (ng) { > - gsf = ng->faults[task_faults_idx(NUMA_MEM, node, 0)], > + gsf = ng->faults[task_faults_idx(NUMA_MEM, node, 0)]; > gpf = ng->faults[task_faults_idx(NUMA_MEM, node, 1)]; > } > print_numa_stats(m, node, tsf, tpf, gsf, gpf); > -- > 2.43.0 >