From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76A701E7C34 for ; Fri, 19 Dec 2025 13:51:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766152316; cv=none; b=Njctqghg7eJNpJdYIeuFvDIHb8Kxl11npNjqTl8e9LPXidbr1gRrV6uiyJyJtmlaC+9aZD4HUQvZUL4UiuhoQalsE8ZyPyel6Y+YuWAZxZjFtZXQyBWrSD2MPXXzSur/fTSBxaaycdKOz+R3EGak42iub+TMEmDrO4utDhpSzEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766152316; c=relaxed/simple; bh=Un+XdBU3I3O1U8e2BADpnWtabL+5oxe0RFc0dPO8UIw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Pf1gP+uqNyMcgdFeHwiR6xuY37fuufzt1vdkVYwXWlvnxchJv8yCtEqBSwA9WHAOlBYlcaTRgyUP3Ty+hn1Ly0HzLqEqrcOQor4bLn6hNJbYYGXtDpCmrl025T2jHekXLDtB1N/VuPurMd9Gsy46+U83/lf2kTyZ/hK71hrcb/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=anhg0O3d; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="anhg0O3d" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2a0834769f0so16629945ad.2 for ; Fri, 19 Dec 2025 05:51:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766152315; x=1766757115; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TxgXlnQdF+cSEGYxVmlOlYry6iRAaIH6LrCkKfjLYP0=; b=anhg0O3d95AeXGYV5XkbiD4lrXN1YjEyInlCcX6gqNV8EfaFrtAs+/TUhhJldwjFzg N1Yda+n0XZcJJQqL8M9RVSbWLyTFfPPgtiDi/RBSqDw/Uh1oJT2Nhl7CVyV6ClO3Jp0E Swqun2dz3hAGeC9zz4TreVJb6DNJH08rRnS9MNtcVPrlio2FpUmuJdIUlGunwWeAOr+/ ajIY4uMfAZrG34LbWJmZZe3mthIQ2WSlR4L/xDdnY00v0Gyv1urkGdzryV602rAD2a+2 64l4HRX/lqPMj3ZkZoXBY5PxK4cdVLM7YG92kfr3Urc3VBkE5/JBPRKvm0mwNoENEvtP b9GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766152315; x=1766757115; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TxgXlnQdF+cSEGYxVmlOlYry6iRAaIH6LrCkKfjLYP0=; b=C5obGceMwmeUmXOUUdHu//Q+LPqaeT3gpHT/UBRknCkRSlDhAbZ1NFk4+D419wofYq pnMF22JeQoXlfEUgjNBjKSQMDzKihQjbUp5sm0gwMk5M8klYsdBokNOus3S82PD+PvLN pWyZr6+aC7Wj5SxryAbvLAwUylsnllHF1HKosyYEMo09tEfaZe9Pq7CuwzqD4GXz5HFi 1jdISCTMPaYMI+LBYidY2iVk0/geFa4TsDtgFrK5Urv9UVp0Vl58Hlgp6CYanBvVY9mE Qr61XIwhD6lF9bEoC/0j1Yw5Bs2Ub1Ybe967GVe4oSDoQQ7P9fHIlL0KhHWwyuQGg0PT xSZg== X-Forwarded-Encrypted: i=1; AJvYcCW6DVR5hGkgQJDjOIR3eAriSY7loU9jPe1Lsjtw9X1vBmJoQ+SyxfzINEnruWU904j5f+D4w1SnTnMV3yg=@vger.kernel.org X-Gm-Message-State: AOJu0YxTHo6JZyWrcvqzGGIZ8GCBgnNJtXQ5O/7G60wZ78djUGk3CmMw 1cXVfa2/HvOzdId140JiHz40IcQqL1N46yXc5oe8LCwkxwYRDX9g0Ztt X-Gm-Gg: AY/fxX4mgaFMqY8whgHzVRGFpjOr7eZFXQeaYN+IlhwCGv7VEEI4/eXESSX3ZAL/+0/ UHgldZbUEDILUn3RVUcr/lCM0i/fHXpHOYSQTeJNDemPCmRe3iLS6HGSAolVkaxOiO4h/lP6Nwc Adoib6ib5iU6Hd4M8MwQA2qD8mBU+71ZGoCJvzotXfPgLHTcxS2OfbAnwcBzUXECaHPIKYiehOy iHFpShecFiACFkMmnBFmmUuNPlEJqosbT58s9azTyh9wp0HzRCSQ5ag2XfVssqX9UgjgLc6XFIf yiJansLPJdpiQ/jHxkE1BYMYnN4Ban4niu8u+a6HiTtL+tJnYWmRCZJkU/wXQQdhurNyTSL+x85 iLTEVZ0/giwF+aYIDQ02ZCPl+aKKCCmpjsDzRjcvVrM/D04YdrBaDBPwRYIyzpjcwDvSZX0dDej KUq9RId1OSIKCT3Ozt1MQ= X-Google-Smtp-Source: AGHT+IHjUG82LmuZwnH/oGWzPoXaTmIsKDM9p+CYDLUCdGZKybZEGn81EAxGcdYrlvsBkx8OQqUwiw== X-Received: by 2002:a17:903:120b:b0:2a1:325d:8219 with SMTP id d9443c01a7336-2a2f2735237mr27124255ad.38.1766152314579; Fri, 19 Dec 2025 05:51:54 -0800 (PST) Received: from LilGuy ([2409:40c2:1162:1559:f712:85ce:d14f:d48c]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2a2f3d5f5dasm23367305ad.82.2025.12.19.05.51.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 05:51:54 -0800 (PST) From: Swaraj Gaikwad To: lgoncalv@redhat.com Cc: akpm@linux-foundation.org, ast@kernel.org, bigeasy@linutronix.de, cl@gentwo.org, clrkwllms@kernel.org, david.hunter.linux@gmail.com, harry.yoo@oracle.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rt-devel@lists.linux.dev, rientjes@google.com, roman.gushchin@linux.dev, rostedt@goodmis.org, skhan@linuxfoundation.org, swarajgaikwad1925@gmail.com, syzbot+b1546ad4a95331b2101e@syzkaller.appspotmail.com, vbabka@suse.cz Subject: Re: [PATCH] slab: fix kmalloc_nolock() context check for PREEMPT_RT Date: Fri, 19 Dec 2025 19:21:43 +0530 Message-ID: <20251219135143.7337-1-swarajgaikwad1925@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit I agree that we can simplify this. I think !preemptible() would be the most descriptive choice here, as it directly expresses the constraint, we cannot take a sleeping lock when preemption is disabled. The updated check would be: if (IS_ENABLED(CONFIG_PREEMPT_RT) && !preemptible()) I'll send a v2 with this change unless there are objections. Swaraj