mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Tomas Melin <tomas.melin@vaisala.com>
Cc: Michael Hennerich <Michael.Hennerich@analog.com>,
	Nuno Sa <nuno.sa@analog.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	David Lechner <dlechner@baylibre.com>,
	Andy Shevchenko <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: adc: ad9467: make iio backend optional
Date: Sun, 21 Dec 2025 20:00:14 +0000	[thread overview]
Message-ID: <20251221200014.29af7df8@jic23-huawei> (raw)
In-Reply-To: <20251216-b4-ad9467-optional-backend-v1-2-83e61531ef4d@vaisala.com>

On Tue, 16 Dec 2025 11:40:06 +0000
Tomas Melin <tomas.melin@vaisala.com> wrote:

> Not all users can or want to use the device with an iio-backend.
> For these users, let the driver work in standalone mode, not coupled
> to the backend or the services it provides.
> 
> Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
Hi Tomas,

>  static int ad9467_probe(struct spi_device *spi)
> @@ -1352,21 +1361,25 @@ static int ad9467_probe(struct spi_device *spi)
>  	indio_dev->channels = st->info->channels;
>  	indio_dev->num_channels = st->info->num_channels;
>  
> +	/* Using a backend is optional */

I'll largely defer to Nuno on the backend aspects but I would like a
lot more than a statement that it is optional in this comment.
At least something about where the data goes and what a real system
that didn't provide a backend would look like etc.

I can think of some setups where I'd be fine with this change and others
where I'd push back harder.

Jonathan


  parent reply	other threads:[~2025-12-21 20:00 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16 11:40 [PATCH 0/2] iio: adc: ad9467: Enable operation without iio-backend Tomas Melin
2025-12-16 11:40 ` [PATCH 1/2] iio: adc: ad9467: include two's complement in default mode Tomas Melin
2025-12-18 13:43   ` Nuno Sá
2025-12-20  3:28   ` kernel test robot
2025-12-20  5:13   ` kernel test robot
2025-12-21 19:54   ` Jonathan Cameron
2025-12-16 11:40 ` [PATCH 2/2] iio: adc: ad9467: make iio backend optional Tomas Melin
2025-12-16 12:56   ` Nuno Sá
2025-12-16 15:39     ` Tomas Melin
2025-12-16 21:27       ` David Lechner
2025-12-17  5:38         ` Tomas Melin
2025-12-17  9:26       ` Nuno Sá
2025-12-17 10:39         ` Tomas Melin
2025-12-17 11:44         ` Tomas Melin
2025-12-18 13:41           ` Nuno Sá
2025-12-19 11:25             ` Tomas Melin
2025-12-18 13:49   ` Nuno Sá
2025-12-19 11:16     ` Tomas Melin
2025-12-19 14:46       ` Nuno Sá
2025-12-21 20:00   ` Jonathan Cameron [this message]
2026-01-05 11:06     ` Tomas Melin
2026-01-05 14:57       ` Nuno Sá
2026-01-11 11:41         ` Jonathan Cameron
2026-01-12 13:21           ` Nuno Sá
2026-01-13  7:47             ` Tomas Melin
2026-01-13 10:00               ` Jonathan Cameron
2026-01-13 10:52               ` Nuno Sá
2026-01-13 11:49                 ` Tomas Melin
2026-01-13 12:44                   ` Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251221200014.29af7df8@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=tomas.melin@vaisala.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®