From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A61AC32AAD5 for ; Mon, 22 Dec 2025 08:23:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766391793; cv=none; b=jBouqJ6/NXcZcIh5W6dP9GPwaaUnsQQfx9pWNag7SgikC56A8x99LYOr9enBiq/f22VVaBNTEi36IJqnzRPZmKhtHKOBVifS13y2o1jthhYccjyHLIg5BxBbYx1jAzmuif4DNQ5EMCcNdqECRPwSBYJ8iOhuGCJDPWfoi1aI1tE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766391793; c=relaxed/simple; bh=a7QzjZykrf+nhpVu0FMe0jqhJkw6SImZcec8zbEQ0hM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=thm+XzlONb6Uog0FxmsFfaQLjt+5NRmOURYaluPNkUQPTdiguIogW9UiN5Au45H4Ps7uQvnM4LWQNJ0L/O9uNtirLgM0U9sPwbm0iBIQGeEkAe4iBq8HkHPZbBVXcAMwotlZZsH5nWuDlxCSNhmWEcCx1pRGFp1HoeP0pY8pnAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N+YIhg/v; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N+YIhg/v" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-7bb710d1d1dso5330413b3a.1 for ; Mon, 22 Dec 2025 00:23:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766391791; x=1766996591; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kB9XGvfi6ObodyigSZBf40IoYnb1xkrL/FFwh/sfSnM=; b=N+YIhg/vBEsmj7U7fd1H5hELJPKzU2LT2VhHA8yiIa8Frr2BSkmKvI42DgHECpSGUK ck1oB3PsSB6SdViwiK1vuds3wGXDyl/+7v7KE0injlf1OeBu6pRu2xDPa8d4rDzGLVGo xt3xAubh8aqMyjOYVkYR+H+YOuij/ZKF+qSPDqcY/Mx9ipEetMKrru5zZre9xXpgJkFP Inau4okQSdbfGFti70CCrjSbcJIpJ7sg1DjMbVSFSO0svpxx1GS6QqlSiBgHDtZAEpv8 UPci0LbgFVHXESP66rqUrfAmOBVJYuOCdZRNcdmQi+A4hDVnsj7SVmubSCIm7C2dzFIR MIuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766391791; x=1766996591; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kB9XGvfi6ObodyigSZBf40IoYnb1xkrL/FFwh/sfSnM=; b=T3E5KxV7cE6q42bpU71QKBKMORt7Pts9a3EUyKKxbQlV1gfE/hHIXL+MTqlY66hFYB mHMpRrIQvWsIq42QSth46TtK4GO/s5WyDBmX62G0fbmkLK7nttejbXAAcfJH22r3HBpn RZ1nYa6H3Sio4m9fTqcH3Z0M0x4+8l3xRJWYyBJGXmvoLtZCBjHiE1873L2eSk4JE/ZP FTbTz4G5u80X5WMNAHDOBkbWJT7o4RSjLS/hLF2+idBhlB9I3wG0j9EqTAxb8Bpy2BVl 84rYXeb28m1jJUoiYvCzKbQd/nQl1fgI7fHxbmsIT2atUYfZFSaITF5EpV2J2iSbKo+0 +evA== X-Gm-Message-State: AOJu0YxTpInsyLZr3ojBaMOMmPdDfIwLJqQvr9jypqc0lrkZq+KeCrvH lL0Y1paRJtaOXj3TTmydXgVL+4iNScNT3Ld6xeLQ6Qjhpz/iXxG0XTIx4q37iNoQnDg= X-Gm-Gg: AY/fxX4SSbrZmIJJFS+U4DHZfV/N9Zl3baGFlzMLmBm8nZRJ0Ma+LdZdP1EgJoDXp8u VdNKq9ggTx+8SRhx/nJx6sTdarulEzejX7sEUDZMPgqc5gxjUSW/A0ZBapb4DAxNPMXWfLgrJRE PPTj5oihPn1neC4Pf7Cb0QhSGeL81Ib+j2GHuDl/3CQMvXJbKiPshmN5RYJCnwcrmkrXkufKRC6 yeAr/RVExncqWPdfc8+1Qg1LGnI8gT4uf/vkdokCUx2WmVaEoGt5/YgdIhjWEzJu1qK17ugm+LR +bQ73QGmGJFb/t0Vbv1chE/h9ka9+W3lsozgnZgD2upvJn2mK696YL4CGXgGYcNe6Cxh0QSSB3U 0Ddsgw97CWQhs5UXpU874e0jedB8qp1FHof8P+v1VY5HG2k6k4z9Ijfhec1oE/g/F8be9xugIVh H6n3hwrwVe X-Google-Smtp-Source: AGHT+IGznpKTz6ixXv+s26nHooFtLIG4Ke1AWMjy0/WKJaDBXTq6iXxKo6TPfotRdJtMkjnB8IbN1A== X-Received: by 2002:a05:6a20:b905:b0:366:14b0:1a3b with SMTP id adf61e73a8af0-376ab2e4dd1mr7445280637.73.1766391790723; Mon, 22 Dec 2025 00:23:10 -0800 (PST) Received: from frodo ([2404:4400:417e:3d00:8b90:7f55:1261:772f]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7ff7e493123sm9540699b3a.50.2025.12.22.00.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 00:23:10 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org, louis.chauvet@bootlin.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, groeck@google.com, yanivt@google.com, bleung@google.com, quic_saipraka@quicinc.com, will@kernel.org, catalin.marinas@arm.com, quic_psodagud@quicinc.com, maz@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, mingo@redhat.com, jim.cromie@gmail.com Subject: [PATCH v7 10/31] dyndbg: reduce verbose/debug clutter Date: Mon, 22 Dec 2025 21:20:27 +1300 Message-ID: <20251222082049.1782440-11-jim.cromie@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251222082049.1782440-3-jim.cromie@gmail.com> References: <20251222082049.1782440-3-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit currently, for verbose=3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' dyndbg: flags=0x1 dyndbg: *flagsp=0x1 *maskp=0xffffffff dyndbg: parsed: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: no matches for query dyndbg: no-match: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: processed 1 queries, with 0 matches, 0 errs That is excessive, so this patch: - shrinks 3 lines of 2nd stanza to single line - drops 1st 2 lines of 3rd stanza 3rd line is like 1st, with result, not procedure. 2nd line is just status, retold in 4th, with more info. New output: dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' flags=0x1 *flagsp=0x1 *maskp=0xffffffff dyndbg: no-match: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: processed 1 queries, with 0 matches, 0 errs Also reduce verbose=3 messages in ddebug_add_module When modprobing a module, dyndbg currently logs/says "add-module", and then "skipping" if the module has no prdbgs. Instead just check 1st and return quietly. no functional change Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 21c1db7e8705..1db2f627237a 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -275,9 +275,6 @@ static int ddebug_change(const struct ddebug_query *query, } mutex_unlock(&ddebug_lock); - if (!nfound && verbose) - pr_info("no matches for query\n"); - return nfound; } @@ -510,7 +507,6 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) pr_err("bad flag-op %c, at start of %s\n", *str, str); return -EINVAL; } - v3pr_info("op='%c'\n", op); for (; *str ; ++str) { for (i = ARRAY_SIZE(opt_array) - 1; i >= 0; i--) { @@ -524,7 +520,6 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) return -EINVAL; } } - v3pr_info("flags=0x%x\n", modifiers->flags); /* calculate final flags, mask based upon op */ switch (op) { @@ -540,7 +535,7 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) modifiers->flags = 0; break; } - v3pr_info("*flagsp=0x%x *maskp=0x%x\n", modifiers->flags, modifiers->mask); + v3pr_info("op='%c' flags=0x%x maskp=0x%x\n", op, modifiers->flags, modifiers->mask); return 0; } @@ -550,7 +545,7 @@ static int ddebug_exec_query(char *query_string, const char *modname) struct flag_settings modifiers = {}; struct ddebug_query query = {}; #define MAXWORDS 9 - int nwords, nfound; + int nwords; char *words[MAXWORDS]; nwords = ddebug_tokenize(query_string, words, MAXWORDS); @@ -568,10 +563,7 @@ static int ddebug_exec_query(char *query_string, const char *modname) return -EINVAL; } /* actually go and implement the change */ - nfound = ddebug_change(&query, &modifiers); - vpr_info_dq(&query, nfound ? "applied" : "no-match"); - - return nfound; + return ddebug_change(&query, &modifiers); } /* handle multiple queries in query string, continue on error, return @@ -1245,11 +1237,10 @@ static int ddebug_add_module(struct _ddebug_info *di, const char *modname) { struct ddebug_table *dt; - v3pr_info("add-module: %s.%d sites\n", modname, di->num_descs); - if (!di->num_descs) { - v3pr_info(" skip %s\n", modname); + if (!di->num_descs) return 0; - } + + v3pr_info("add-module: %s %d sites\n", modname, di->num_descs); dt = kzalloc(sizeof(*dt), GFP_KERNEL); if (dt == NULL) { -- 2.52.0