From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F3993161A9 for ; Mon, 22 Dec 2025 08:22:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766391723; cv=none; b=N5Vmx+eoqkQ1+hoQURHqLoQBAc+JzDv66Pok4mspxpyAWI9GnO1gHYbsCKwkE4k9rHv8SUMYAYd4zETsX0nCivgHS7QGfucPs+FycZYNfbJYUz0+Cg1LYuIdgXxelK1ixccOnerduscR2LP6wR89iXh/Z3Pal5QSseEtFs3oBII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766391723; c=relaxed/simple; bh=EqxGeITc2UKYaMAzZMDYQfg02UCHl3X6FUpCJ4R9urE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M2+DhpjbDy115aFIomWGE9Qu2OFeV5POKTQZsj8DHG1z7tUUKVPjHj1xmtKiSJXaDWJVqZZ+FMFukWP6JzjVCfFD9PA40LA1UJiJguJ4hejLMxZmfYGyzyC2a9Y/5xO9+Nv2pKMHq91Xe6yOGp9XHORYdcW+XN9ylLhhNByP4sE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eJXpRmsj; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eJXpRmsj" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7aae5f2633dso3689420b3a.3 for ; Mon, 22 Dec 2025 00:22:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766391721; x=1766996521; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dFfaj1jg7DkAQbZ2xQqGZ0nerYqYJ2u1eC/UX4LEwiY=; b=eJXpRmsjLS3VyGb8byupvVr5yTocjvkDkbcR3XuO6rdwDL7aCCy0Hg4jHwQOjjgmJ6 oWJ15u6kkZhZUdF3NyqIqTAa6BVl5RYexz5XbXRbemf6AZqctZD2x5aosKb44UpMSXJM xZ/sYgWGEQjd9nRs9VJJ8X+jnsEhoSBzgE80MXKDCfOPvvfKhJGskO+m/I6hYmqpvrMx GLBuDeR2oJqueRHPKUoA+13rfESg7uvJ/sL958TEmv0nSijITW1TYTvQRXJB98WKAod/ UBBucn1bWWIxxYIlUms7Aj5/jVlmeF0iL4i82SPWK0SssLsBVU/hzxZwqJ4/OVPjVFu2 ADow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766391721; x=1766996521; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dFfaj1jg7DkAQbZ2xQqGZ0nerYqYJ2u1eC/UX4LEwiY=; b=HrpG/cL90nivzjDmLA9xLQqBhkW1IuSaicTwQqqF/5OB2R3lGwwGIFTTFEYuO255tE 2N3gSH9bLWs1a0NCG4vRE2grmHMa/AVTvTAuLIJR7MI04J8Ufsbg3uz+Q68jBj2mkN0W +XDSb8BT4adOUP1qBcachJI64EVF6US1bUWXDQFQ8FCYfSsalWCz49gLizuha/0KuJrd SEgI8C83QGtqYXUvdEb7OyXRbnc8cx3jrRUBQrRbjPPTDJX/Gj0M752dDPGsPvu2/lpn +1JzPBq4oNsUFxWPeYPU8L3yR/QijhfryouCPAKG4oG8+2pX/Fx4e96ysm5HY45FrdZL +p3w== X-Gm-Message-State: AOJu0YyD3yXSEuX6dqpqguYxjyxJIz93Lz9ydp30P5FcSlAAGTLAqspb /0k06fq8pTjhrL2M6Ew9AiHIhRU/0LcR71Uhr/uirB9OQt7qlj8hMlm6WpdFwCNT/ds= X-Gm-Gg: AY/fxX6kzMDHmq9k4jUr2wjE3VNqmxMWm5z4BW/C2nYBgshFupiasi4E7dII4skvpaO M0QpeDLSb5ft4Sr4ZFuzVHqrzgNzSi7jS6bK16DkFyt0bqOhh0nYCHf9cra/WLkrk2kt6wCEUpd QcJPQdGrhJTvOOodnjYEpClE+dejn1q/u1ome3TNQJCzVf5udzsh/8cpjxz8M00t7Tyrw/OoFIn N+y9a/oHCxPtZpaF0+xmhD2qUALDmCWrMMBoHnJ5TLOdfOYGTthuu9tDPLRGH2MYYlrMIUOCSPH lCy6zaakquRRKWKMxVmE+7T4FAOJyyyMpv2kOR6gJwHbEKWxr8gZz3AbGnBB/zvuiRQ7DG23J/i aZK4XMUPAcAHvt2ZgL1NJBMiQfU5WvGejFC+dSs6eBDglKG+3B5Ij2gQXklgBDPizvispcllelN Q8OEm6XCx2 X-Google-Smtp-Source: AGHT+IG3eUuB5Tb1s+Zs70IjrZagHo/mf8fIHvmKfCB1AS8Rh4HCdjBPUwGbrg6oNBn8UN6DCsv0tQ== X-Received: by 2002:a05:6a00:3e2a:b0:7ff:9657:d6c8 with SMTP id d2e1a72fcca58-7ff9657d93bmr10043630b3a.27.1766391721087; Mon, 22 Dec 2025 00:22:01 -0800 (PST) Received: from frodo ([2404:4400:417e:3d00:8b90:7f55:1261:772f]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7ff7e493123sm9540699b3a.50.2025.12.22.00.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 00:22:00 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org, louis.chauvet@bootlin.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, groeck@google.com, yanivt@google.com, bleung@google.com, quic_saipraka@quicinc.com, will@kernel.org, catalin.marinas@arm.com, quic_psodagud@quicinc.com, maz@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, mingo@redhat.com, jim.cromie@gmail.com, linux-doc@vger.kernel.org Subject: [PATCH v7 04/31] docs/dyndbg: explain flags parse 1st Date: Mon, 22 Dec 2025 21:20:21 +1300 Message-ID: <20251222082049.1782440-5-jim.cromie@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251222082049.1782440-3-jim.cromie@gmail.com> References: <20251222082049.1782440-3-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When writing queries to >control, flags are parsed 1st, since they are the only required field, and they require specific compositions. So if the flags draw an error (on those specifics), then keyword errors aren't reported. This can be mildly confusing/annoying, so explain it instead. cc: linux-doc@vger.kernel.org Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- .../admin-guide/dynamic-debug-howto.rst | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst index 4ac18c0a1d95..e76ccd987704 100644 --- a/Documentation/admin-guide/dynamic-debug-howto.rst +++ b/Documentation/admin-guide/dynamic-debug-howto.rst @@ -109,10 +109,19 @@ The match-spec's select *prdbgs* from the catalog, upon which to apply the flags-spec, all constraints are ANDed together. An absent keyword is the same as keyword "*". - -A match specification is a keyword, which selects the attribute of -the callsite to be compared, and a value to compare against. Possible -keywords are::: +Note that since the match-spec can be empty, the flags are checked 1st, +then the pairs of keyword and value. Flag errs will hide keyword errs:: + + bash-5.2# ddcmd mod bar +foo + dyndbg: read 13 bytes from userspace + dyndbg: query 0: "mod bar +foo" mod:* + dyndbg: unknown flag 'o' + dyndbg: flags parse failed + dyndbg: processed 1 queries, with 0 matches, 1 errs + +So a match-spec is a keyword, which selects the attribute of the +callsite to be compared, and a value to compare against. Possible +keywords are:: match-spec ::= 'func' string | 'file' string | -- 2.52.0