From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 145643271E4 for ; Mon, 22 Dec 2025 08:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766391739; cv=none; b=Tus48zA5AVBhEOB5QKzORkigm3gXz+dbojDPeB5CZ74Zp3aRXLlF+QmVdy0KerQVzou3JAvXZp307WRcHwxbaBq56O3BCEHfFyp5LjqR4Q8OYRFAHrN5+QKNAWsQzE6YctS6kTsyZsQ7IAOOvU+hvKZPdWLQF/ELORQM5jbEXo0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766391739; c=relaxed/simple; bh=fM95hmZ04ed6zy8idewI3EL31tuL2KItDxeKe01AAec=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bL19NSsZ2ilRuYkOjeLWVrFpyM4WOHTwEWxC4njcNxWb0R0C3vj4i6bXxP8ia97sN6ebe7zN5uVXDq0XvZ6nuss3nmaiYFlDccY6nUsvaftQFiY7JPC1viHsvf8PxwGhG7liPQAgIZsWDLEUeo9e6CQbWx4p5ycfR47IyaLIA90= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RhMVUnsV; arc=none smtp.client-ip=209.85.210.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RhMVUnsV" Received: by mail-pf1-f196.google.com with SMTP id d2e1a72fcca58-7b6dd81e2d4so3895111b3a.0 for ; Mon, 22 Dec 2025 00:22:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766391736; x=1766996536; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HpOUBSAqvR/6qLOY5JhuGvZqZpKLgLxKB67YbPHT84s=; b=RhMVUnsVzatGDTAsw4htZYuG+cZoEJkfnEmyXofPAAA0OilxS4Db8x/gFg9DxEzY+/ 8PvPMoIhpZyY/1+5tNN6PhI+juGPMitihoRSBZ8SOZhnbs5x6eMxxAlEVpuK9g1meyT/ z1OR/1rttXGhRCfuBSC+QRuX8UVY17nM4dDJ9v69Vly0Gd0Ck/9V6xJmMTOHRI/EZ2S5 vDXAm8tPOcrxg3wCHfFrteR0iyZ8vkrxf5wOUZXqUezF4RNQhYReIPoKovdEgIkAsMrC c7cctsivdilZsF1SrbEdNK6u5SZG4bKd+lNi/gajWV0Vuinpl9GnoE5icPabK3kK2tIA ettw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766391736; x=1766996536; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HpOUBSAqvR/6qLOY5JhuGvZqZpKLgLxKB67YbPHT84s=; b=awY16Se+DcAfvcNceAFNZayGws3LtaENTtsVWyjjEEKA887ywR5VL2uGz7YjeVaoa5 GD3hBUVn42xJqfSAOp+z4iUfyjeP+BmRR+dF+5Big5joMp4LnxHJjeyz38tQqEXyAxim rHZAeJwjNuvCR2Gru8tfzZ78plR0a+fhcx7wTVh1HVZwF2v/NPzENK9rP9mCiG2fbnFC 1akT8lpoPOcCEJbmLPmBtNAbbngu9T01EUQzSRALbFRxv7h/Q0Infg3eN3AIWD7vuao6 Yrigq0PxKxzka3tsK4zDg6lBasy3G99VO89VA/F7yGqcBljEboTJM98aLLpXukVfMVJJ 8qtQ== X-Gm-Message-State: AOJu0Yx3nJnv2/6YLyiSxwVf/P0lBObf//fsy0TAAgczVOTEEhOvcC8H siivGti8LPFp16e6QPpLzpLgIz8hVeaaXPsBwG7scLzhGny1X0qTydkbIpnd+PrfXoRooA== X-Gm-Gg: AY/fxX659jNPNv9hpV8mMNJW2Qm3u2O0jNQxHoESGa51JvJe7+1uy+tBoD+2rNx7R36 7xLpOQhEZAGMBGzni+s3N51FCvHDmUZTUbgTMyJjpfvvd3awbs3LlWZ0Mzcz++VfZ8EeF+b40q1 ZaxQSzr2W2r2ioXfx91g3LC9kwFoeXLTxj0hOsB14ydMcYXdFMzCQjdzxKnIxH87NsqgPxBtEGd 64sNIx6CutGbOfQqC/23rIe8USp4Z2nACg1KYWeEBx0DFvma1So9166QvqGF7k7EKkk6HAYVchO FJWJn+ZQl0ZCiYLymikQgzf6G8tpZ/waug/GZU/kSt8DfcfbhlbobeZHIvN8bFCWJp8ac1l5pBo ANIKHalKrGWic9+dDQuqmZPX9nHO31p6tDc37cYcTFIcJf/u1X0pQJe/0vErS/xJi2K1TtHpjBB NMKVLCoeU+ X-Google-Smtp-Source: AGHT+IFHqnkLVdqcXm7bGw59SVF2bpwuPS776EDpm2DBSj3/f5x17l2ZGosn+Y6e7lRKYamOLqvnUw== X-Received: by 2002:a05:6a00:ac85:b0:7e8:4433:8fa3 with SMTP id d2e1a72fcca58-7ff6607e4demr9148599b3a.43.1766391735766; Mon, 22 Dec 2025 00:22:15 -0800 (PST) Received: from frodo ([2404:4400:417e:3d00:8b90:7f55:1261:772f]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7ff7e493123sm9540699b3a.50.2025.12.22.00.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 00:22:15 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org, louis.chauvet@bootlin.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, groeck@google.com, yanivt@google.com, bleung@google.com, quic_saipraka@quicinc.com, will@kernel.org, catalin.marinas@arm.com, quic_psodagud@quicinc.com, maz@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, mingo@redhat.com, jim.cromie@gmail.com Subject: [PATCH v7 05/31] test-dyndbg: fixup CLASSMAP usage error Date: Mon, 22 Dec 2025 21:20:22 +1300 Message-ID: <20251222082049.1782440-6-jim.cromie@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251222082049.1782440-3-jim.cromie@gmail.com> References: <20251222082049.1782440-3-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit commit 6ea3bf466ac6 ("dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes") A closer look at test_dynamic_debug.ko logging output reveals a macro usage error: lib/test_dynamic_debug.c:105 [test_dynamic_debug]do_cats =p "LOW msg\n" class:MID lib/test_dynamic_debug.c:106 [test_dynamic_debug]do_cats =p "MID msg\n" class:HI lib/test_dynamic_debug.c:107 [test_dynamic_debug]do_cats =_ "HI msg\n" class unknown, _id:13 107 says: HI is unknown, and 105,106 have a LOW/MID and MID/HI skew. DECLARE_DYNDBG_CLASSMAP() _base arg must equal the enum's 1st value, in this case it was _base + 1. This leaves HI class un-selectable. NB: the macro could better validate its arguments. Reviewed-by: Louis Chauvet Tested-by: Louis Chauvet Signed-off-by: Jim Cromie --- lib/test_dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c index 77c2a669b6af..396144cf351b 100644 --- a/lib/test_dynamic_debug.c +++ b/lib/test_dynamic_debug.c @@ -75,7 +75,7 @@ DD_SYS_WRAP(disjoint_bits, p); DD_SYS_WRAP(disjoint_bits, T); /* symbolic input, independent bits */ -enum cat_disjoint_names { LOW = 11, MID, HI }; +enum cat_disjoint_names { LOW = 10, MID, HI }; DECLARE_DYNDBG_CLASSMAP(map_disjoint_names, DD_CLASS_TYPE_DISJOINT_NAMES, 10, "LOW", "MID", "HI"); DD_SYS_WRAP(disjoint_names, p); -- 2.52.0