From: Eric Dumazet <edumazet@google.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Eric Dumazet <edumazet@google.com>
Subject: [PATCH] x86/apic: Inline __x2apic_send_IPI_dest()
Date: Mon, 22 Dec 2025 09:22:08 +0000 [thread overview]
Message-ID: <20251222092208.770136-1-edumazet@google.com> (raw)
Avoid one call/ret in networking RPS/RFS fast path, at a little space cost.
scripts/bloat-o-meter -t vmlinux.before vmlinux.after
add/remove: 0/2 grow/shrink: 2/0 up/down: 102/-86 (16)
Function old new delta
x2apic_send_IPI 165 217 +52
__x2apic_send_IPI_mask 617 667 +50
__pfx___x2apic_send_IPI_dest 16 - -16
__x2apic_send_IPI_dest 70 - -70
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
arch/x86/kernel/apic/local.h | 8 +++++++-
arch/x86/kernel/apic/x2apic_phys.c | 6 ------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/x86/kernel/apic/local.h b/arch/x86/kernel/apic/local.h
index bdcf609eb28352530ffcbb3c66ffb32c82df4d7f..14ac32c014eebff968658c5fb4db136edfe7f447 100644
--- a/arch/x86/kernel/apic/local.h
+++ b/arch/x86/kernel/apic/local.h
@@ -14,7 +14,6 @@
#include <asm/apic.h>
/* X2APIC */
-void __x2apic_send_IPI_dest(unsigned int apicid, int vector, unsigned int dest);
u32 x2apic_get_apic_id(u32 id);
void x2apic_send_IPI_all(int vector);
@@ -42,6 +41,13 @@ static inline unsigned int __prepare_ICR(unsigned int shortcut, int vector,
return icr;
}
+static inline void __x2apic_send_IPI_dest(unsigned int apicid, int vector,
+ unsigned int dest)
+{
+ unsigned long cfg = __prepare_ICR(0, vector, dest);
+ native_x2apic_icr_write(cfg, apicid);
+}
+
void default_init_apic_ldr(void);
void apic_mem_wait_icr_idle(void);
diff --git a/arch/x86/kernel/apic/x2apic_phys.c b/arch/x86/kernel/apic/x2apic_phys.c
index 12d4c35547a6f928d14df005dbcbffb71eab4641..10f79026e8e3130ca05764faed6847b16e0f5273 100644
--- a/arch/x86/kernel/apic/x2apic_phys.c
+++ b/arch/x86/kernel/apic/x2apic_phys.c
@@ -107,12 +107,6 @@ void x2apic_send_IPI_self(int vector)
apic_write(APIC_SELF_IPI, vector);
}
-void __x2apic_send_IPI_dest(unsigned int apicid, int vector, unsigned int dest)
-{
- unsigned long cfg = __prepare_ICR(0, vector, dest);
- native_x2apic_icr_write(cfg, apicid);
-}
-
static int x2apic_phys_probe(void)
{
if (!x2apic_mode)
--
2.52.0.322.g1dd061c0dc-goog
next reply other threads:[~2025-12-22 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 9:22 Eric Dumazet [this message]
2025-12-22 22:18 ` kernel test robot
2025-12-23 1:06 ` kernel test robot
2025-12-23 4:51 ` Eric Dumazet
2025-12-23 10:43 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251222092208.770136-1-edumazet@google.com \
--to=edumazet@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=eric.dumazet@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®