From: Bartlomiej Kubik <kubik.bartlomiej@gmail.com>
To: tytso@mit.edu
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com,
skhan@linuxfoundation.org, khalid@kernel.org,
linux-kernel-mentees@lists.linux.dev,
Bartlomiej Kubik <kubik.bartlomiej@gmail.com>,
syzbot+703d8a2cd20971854b06@syzkaller.appspotmail.com
Subject: [PATCH] fs/ext4: Initialize new folios before use
Date: Tue, 23 Dec 2025 22:58:55 +0100 [thread overview]
Message-ID: <20251223215855.2486271-1-kubik.bartlomiej@gmail.com> (raw)
KMSAN reports an uninitialized value in adiantum_crypt, created at
write_begin_get_folio(). New folios are allocated with the FGP_CREAT
flag and may be returned uninitialized. These uninitialized folios are
then used without proper initialization.
Fixes: b799474b9aeb ("mm/pagemap: add write_begin_get_folio() helper function")
Tested-by: syzbot+703d8a2cd20971854b06@syzkaller.appspotmail.com
Reported-by: syzbot+703d8a2cd20971854b06@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=703d8a2cd20971854b06
Signed-off-by: Bartlomiej Kubik <kubik.bartlomiej@gmail.com>
---
include/linux/pagemap.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
index 31a848485ad9..31bbc8299e08 100644
--- a/include/linux/pagemap.h
+++ b/include/linux/pagemap.h
@@ -787,7 +787,8 @@ static inline struct folio *write_begin_get_folio(const struct kiocb *iocb,
fgp_flags |= FGP_DONTCACHE;
return __filemap_get_folio(mapping, index, fgp_flags,
- mapping_gfp_mask(mapping));
+ mapping_gfp_mask(mapping)|
+ __GFP_ZERO);
}
/**
--
2.39.5
next reply other threads:[~2025-12-23 21:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 21:58 Bartlomiej Kubik [this message]
2025-12-24 1:39 ` Baokun Li
2025-12-28 13:00 ` Bartłomiej Kubik
2025-12-28 20:09 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251223215855.2486271-1-kubik.bartlomiej@gmail.com \
--to=kubik.bartlomiej@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=david.hunter.linux@gmail.com \
--cc=khalid@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+703d8a2cd20971854b06@syzkaller.appspotmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®