From: Alex Tran <alex.t.tran@gmail.com>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: linux-kernel@vger.kernel.org, Alex Tran <alex.t.tran@gmail.com>
Subject: [PATCH] checkpatch: Fix false positive check for dt-binding docs and include
Date: Wed, 24 Dec 2025 17:41:17 -0800 [thread overview]
Message-ID: <20251224-checkscript_dt_bindings_fp-v1-1-0e18877ced62@gmail.com> (raw)
The check for when to display a DT_SPLIT_BINDING_PATCH warning
is performed on all files that are not MAINTAINERS files.
This causes issues, specifically when checking against a
patch that only touches docs/dt-bindings or a patch that
only touches include/dt-bindings. The warning is still
displayed when it should not be, giving false positives.
The check for when to issue a DT_SPLIT_BINDING_PATCH warning
is currently too pervasive and should only be performed when
a change under docs/dt-bindings is detected or include/dt-bindings.
If the current changed file is under include/dt-bindings or
docs/dt-bindings then it is compared to the last file detected
under include/dt-bindings or docs/dt-bindings. If there is a
difference then a warning is issued.
Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
---
scripts/checkpatch.pl | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c0250244cf7a3cb5e289b04fa4a9f644692dc278..fe3499bc9adda158c88231b48b3b0100f3af0ee1 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2668,7 +2668,7 @@ sub process {
my $authorsignoff = 0;
my $author_sob = '';
my $is_patch = 0;
- my $is_binding_patch = -1;
+ my $is_doc_binding_patch = -1;
my $in_header_lines = $file ? 0 : 1;
my $in_commit_log = 0; #Scanning lines before patch
my $has_patch_separator = 0; #Found a --- line
@@ -2924,13 +2924,13 @@ sub process {
}
$checklicenseline = 1;
- if ($realfile !~ /^MAINTAINERS/) {
- my $last_binding_patch = $is_binding_patch;
+ if ($realfile =~ m@^(?:Documentation/devicetree/|include/dt-bindings/)@) {
+ my $last_binding_patch_is_doc = $is_doc_binding_patch;
- $is_binding_patch = () = $realfile =~ m@^(?:Documentation/devicetree/|include/dt-bindings/)@;
+ $is_doc_binding_patch = () = $realfile =~ m@^(?:Documentation/devicetree/)@;
- if (($last_binding_patch != -1) &&
- ($last_binding_patch ^ $is_binding_patch)) {
+ if (($last_binding_patch_is_doc != -1) &&
+ ($last_binding_patch_is_doc ^ $is_doc_binding_patch)) {
WARN("DT_SPLIT_BINDING_PATCH",
"DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst\n");
}
---
base-commit: fa084c35afa13ab07a860ef0936cd987f9aa0460
change-id: 20251224-checkscript_dt_bindings_fp-0e5938f6d274
Best regards,
--
Alex Tran <alex.t.tran@gmail.com>
next reply other threads:[~2025-12-25 1:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-25 1:41 Alex Tran [this message]
2026-01-03 9:24 ` Bagas Sanjaya
2026-01-04 11:34 ` Alex Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251224-checkscript_dt_bindings_fp-v1-1-0e18877ced62@gmail.com \
--to=alex.t.tran@gmail.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®