From: Hans de Goede <johannes.goede@oss.qualcomm.com>
To: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans de Goede <johannes.goede@oss.qualcomm.com>
Subject: [PATCH v4 08/15] media: mt9m114: Put sensor in reset on power down
Date: Wed, 24 Dec 2025 13:31:17 +0100 [thread overview]
Message-ID: <20251224-mt9m114-atomisp-v4-8-60b25da7a1bc@oss.qualcomm.com> (raw)
In-Reply-To: <20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com>
Put the sensor back in reset on power down. Putting the sensor in reset
reduces power-consumption by putting all the data / ctrl pins in High-Z
mode. This helps save power on designs where the regulators may need to
stay on while the sensor is powered down.
This also ensures that the sensor is properly reset on power up,
since now the sensor will see a reset high to low transition after
the regulators have been turned on.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
---
Changes in v3:
- Improve commit message
Changes in v2
- After setting reset high wait 20 clk cycles before disabling
the clk and regulators
---
drivers/media/i2c/mt9m114.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c
index 60afc32acee4df1e7d4f820838b72f6aa3506f8d..39f9d20221fee4f1d12c24a031d9f33c953b9a9c 100644
--- a/drivers/media/i2c/mt9m114.c
+++ b/drivers/media/i2c/mt9m114.c
@@ -2228,6 +2228,13 @@ static int mt9m114_power_on(struct mt9m114 *sensor)
static void mt9m114_power_off(struct mt9m114 *sensor)
{
+ unsigned int duration;
+
+ gpiod_set_value(sensor->reset, 1);
+ /* Power off takes 10 clock cycles. Double it to be safe. */
+ duration = DIV_ROUND_UP(2 * 10 * 1000000, clk_get_rate(sensor->clk));
+ fsleep(duration);
+
clk_disable_unprepare(sensor->clk);
regulator_bulk_disable(ARRAY_SIZE(sensor->supplies), sensor->supplies);
}
--
2.52.0
next prev parent reply other threads:[~2025-12-24 12:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-24 12:31 [PATCH v4 00/15] media: mt9m114: Changes to make it work with atomisp devices Hans de Goede
2025-12-24 12:31 ` [PATCH v4 01/15] media: aptina-pll: Debug log p1 min and max values Hans de Goede
2025-12-24 12:31 ` [PATCH v4 02/15] media: aptina-pll: Add comment documenting the PLL chain Hans de Goede
2025-12-28 12:50 ` Laurent Pinchart
2025-12-30 15:44 ` Hans de Goede
2025-12-24 12:31 ` [PATCH v4 03/15] media: mt9m114: Use aptina-PLL helper to get PLL values Hans de Goede
2025-12-28 17:12 ` Laurent Pinchart
2025-12-24 12:31 ` [PATCH v4 04/15] media: mt9m114: Lower minimum vblank value Hans de Goede
2025-12-24 12:31 ` [PATCH v4 05/15] media: mt9m114: Fix default hblank and vblank values Hans de Goede
2025-12-24 12:31 ` [PATCH v4 06/15] media: mt9m114: Tweak default hblank and vblank for more accurate fps Hans de Goede
2025-12-24 12:31 ` [PATCH v4 07/15] media: mt9m114: Avoid a reset low spike during probe() Hans de Goede
2025-12-24 12:31 ` Hans de Goede [this message]
2025-12-24 12:31 ` [PATCH v4 09/15] media: mt9m114: Add and use mt9m114_ifp_get_border() helper function Hans de Goede
2025-12-24 12:31 ` [PATCH v4 10/15] media: mt9m114: Adjust IFP selections and source format when source format changes to/from RAW10 Hans de Goede
2025-12-24 12:31 ` [PATCH v4 11/15] media: mt9m114: Update source pad selection and format when sink pad format changes Hans de Goede
2025-12-24 12:31 ` [PATCH v4 12/15] media: mt9m114: Don't allow changing the IFP crop/compose selections when bypassing the scaler Hans de Goede
2025-12-24 12:31 ` [PATCH v4 13/15] media: mt9m114: Drop start-, stop-streaming sequence from initialize Hans de Goede
2025-12-28 17:20 ` Laurent Pinchart
2025-12-24 12:31 ` [PATCH v4 14/15] media: mt9m114: Return -EPROBE_DEFER if no endpoint is found Hans de Goede
2025-12-24 12:31 ` [PATCH v4 15/15] media: mt9m114: Add ACPI enumeration support Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251224-mt9m114-atomisp-v4-8-60b25da7a1bc@oss.qualcomm.com \
--to=johannes.goede@oss.qualcomm.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®