From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E21B3128B1 for ; Wed, 24 Dec 2025 10:04:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766570677; cv=none; b=f9qirMwCro7sOpNcrIz/vuX2btJLCLwrNsGylkHncSDMJgGq2Om6QiZc3+ecCxqZ9L2TQEZPzlPptzI3UYowpomzpbexPNs2TOCRdpbB9HDeQlz/O5ihsLtCJJu1QXWQJc62m4207ADON3ITbhc24LRdpGePWoMAevRtUqAWkLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766570677; c=relaxed/simple; bh=a1R9f9yHLwbz+I4PxKmZT+oys7sVkRkm1ijOJ+xQHh8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UwU2lRwGJdKUFxNlN4VB6rfBYfB4VqqxiktAUHnAKR058zRGZPeq/EbmDwDafUT+7opJ0+BDwsxTQuUSovkKcyllAFddGpdWu8uqJ5zCRBbze1cQ4FNURwX0GvadXMu/ah0gonKaP4Sdfcixqt1LNaJ/fGGDiNqjV6z9ImQUleM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FL9xh7bb; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FL9xh7bb" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-64d0d41404cso5521647a12.0 for ; Wed, 24 Dec 2025 02:04:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766570674; x=1767175474; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=G9glelcpJM+PxER11SMVAuXCWtXkfXh4lHJsv/3Mb4o=; b=FL9xh7bb0vhrVbJubGZMKg2i99fJIjcPTvbdWYJonJ4G4bHMxztOv1G7WO6taTpoOe UVz54gcgQYQplX7MRocWxDrTfhQiNx6GxwRRZ/aj6uCciaH4ayj3Yhf6DEoaHUCfiaJi W3eYKIFnl0v7f3mVwfFqc7drFA0QzxBc4zrBr89uYnP7M40Ve1lagWHKJO49quxtY0BT bCIf5B+LTVujOXao/bObMFFasKS9X2PwgmtxauEQ5VuT83k0aXQ2WlJ6pik6zNqQwO4o ldTvA3RaOwVFn5UGO8okRqJgLoq1PcdvsMYyJBNahjsSoFqUrLkBDsiM4bkhITGmdh8c +z3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766570674; x=1767175474; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G9glelcpJM+PxER11SMVAuXCWtXkfXh4lHJsv/3Mb4o=; b=tmU6l9OZA6s0bQbCLsJZdCQ1qUoSKFzqS854L1hWSJ8BrebCKBGfjFCPOhvW8ihMgl 3U/FeQnV/k++nBMnltI8LHPxOKIp6gSxXcBrFkisN9jA+FGT8g96zUKw3ObL595gcNao U5ZnHpgxLcjRBhlPS3+aL9GQnzvhzs3m6kI/3tyEB/9k516ni4BroEVW43YaYtudmMhL yXFP7LbwdUO8OYC0vCZsBc9ANgdXFRyPYPtMQYcqLyFk6LZL0xphlo6io8Hll5qwcGEs C3PaLrGul3A9BgrGn3T6k1zQoLO27huDJdrhqnOWG2gj0EbHFRPefWi2pAXRwJDBF0ta ry2Q== X-Forwarded-Encrypted: i=1; AJvYcCUaG5qiOmAcYpu4nvc2d53u43B247tyVtADnxHPoCzBhC0f0VMlFTOwnV4m56hz5eX9x3T/VMQkgcQRE8I=@vger.kernel.org X-Gm-Message-State: AOJu0Yw47X57rqE26xgzeJVJAPXeeVcAKz7sXZGaW4G4u/vO9RcDc2dr TadO7bkS7jYS9YPVnR/N7waK4NUVh8KWxsxHraSGsXNj8KRgPqcDXhsM X-Gm-Gg: AY/fxX61/SiZmRnKBGUPyBVRYh5mn03wLBMogk5Qt4lrKk1E6v5k+cjwyn9D7AWR72N eZJ4he1gmsbEX4U0I2P9iPYL8+lC3iEUpR1WbF1dKX3P/3adbn/6KtxM3AxNhggAocfMOXfGlcp 1dnPWpaWJqFXHoRboIkVkQnJGSFaXvMvSdNPM0fFjDHYb5oSIXemkqjITVncCUZ8AMvxdIPhneN 2a9nuGnmZjcmrRfN5ttJzS9+DaHmlN2nyr2OAoTwURQRYFUA4h1bKMaAigEDl0U0FMSJueIIJzG qoX3slYRgyQrXoA6rgHz94H7Q+OL7gPr9yqX3bzF3eT7mUFq4kck7h7IWaK2doubvf2UzylV4xN +BBTDMinqdIplamXQEm8dnOYQWmlpoQ1giClnO1lDuXILP3TD9UhaVXmh/Eud11Y5x4BqnamJRX p1GOCSmdPsa+/qlgeSRxjycrIQTYqd4dbUqoHigsbLIKT5AIAQTEss3nr1UCGYwkczcTq/RG/7 X-Google-Smtp-Source: AGHT+IFrit3HjGYBhSElt3+3JlaTipTh/uoXNKhnenjs0sUyaiTe6+SZD0FWJXgDi4riqOGq5h/YMg== X-Received: by 2002:a17:907:d87:b0:b73:5d8c:dd0d with SMTP id a640c23a62f3a-b80371d69e5mr1826627066b.52.1766570674054; Wed, 24 Dec 2025 02:04:34 -0800 (PST) Received: from localhost (19.120-65-87.adsl-dyn.isp.belgacom.be. [87.65.120.19]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037a6050dsm1742246266b.9.2025.12.24.02.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 02:04:33 -0800 (PST) From: William Hansen-Baird To: Greg Kroah-Hartman Cc: Michael Straube , Hans de Goede , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, William Hansen-Baird Subject: [PATCH 1/3] staging: rtl8723bs: core: remove empty if-statements Date: Wed, 24 Dec 2025 05:02:54 -0500 Message-ID: <20251224100329.762141-1-william.hansen.baird@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch removes if-statements with no body in rtw_recv.c and rtw_xmit.c. If-statement conditions have no side-effect and can be safely removed. Signed-off-by: William Hansen-Baird --- drivers/staging/rtl8723bs/core/rtw_recv.c | 3 --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 -- 2 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index e893cb6fa273..24cc4a9e0445 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -2035,9 +2035,6 @@ static int recv_indicatepkt_reorder(struct adapter *padapter, union recv_frame * preorder_ctrl->indicate_seq = (preorder_ctrl->indicate_seq + 1)%4096; - if (retval != _SUCCESS) { - } - return retval; } } diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 21690857fd62..ae482c28b40b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1707,8 +1707,6 @@ s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_frame *pxmitfram queue = &pxmitpriv->free_xmit_queue; else if (pxmitframe->ext_tag == 1) queue = &pxmitpriv->free_xframe_ext_queue; - else { - } spin_lock_bh(&queue->lock); -- 2.52.0