From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92B2C329E62 for ; Wed, 24 Dec 2025 10:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766570740; cv=none; b=Pub+v3EXaVIDCk7H0F20cqg56vRx1+0f9FZvj9gZU3tvNbB4eog+jDhlpKo/JAnQV0QUTmcwd+IZcWLScHS9hGJMQgYgnjIgqwjst9zDNWTLx8GL9tPEFj3HnpaE81sku8xxQ3xzvSfYzAgvz12p7Hf4UEXu4V0lYIST7lcJDJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766570740; c=relaxed/simple; bh=vV2AxVBGWNPf5DfiHymaldGfVCu4+j83dikHYL9Al40=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H1OGfRmHfgwMsfQAN1W4FtJAEkA1M9JaG8dSUobIYNi4m5IztA4F/ZQ8mIT72v/x9NiRMrfh4PzGWbyD9WYiwU2DTQ9zPTdx+Cw9c5QXxzojKuCPrvy++lRZRErcNFIUE+s0hkdpsrZibsQRJfQxnI6kvthex6YjecZ0uXRzDEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MgIHsEKm; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MgIHsEKm" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-64dfb22c7e4so129702a12.1 for ; Wed, 24 Dec 2025 02:05:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766570737; x=1767175537; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ggySzSK5iKOIYAfFp9jHFvxyzRSSRMRx7Zg28buJhXU=; b=MgIHsEKm1rse8sVGGtjrtVJtgwK7dL1oHlpGwZQkCDCFlrGyyMPlCO9Ki1xyYGVPKI efS+/Ha8+8RP+Feebw4CSAkEOSCa7yyVdLg3U9rkj2CCoaD58kxgM+uyL72RKW7Ooq6f Yd/Kmp3rzcPShhgCd64GWQxpfKqOrvzblSWk89bMEGJubwN3trTg/l/Ovr7s4XPIZcxd 3j9419h0k8wif2X2GguHMoZfiqLi85GSh4rkEbzrkrmhbXGzz8T8gpc4Kyte5/cZWmS3 /VAgs/y/eV1aqXtqvMKc6LsvWoFz+MaNIPwIVFpQX/FBEFwNdKdvwgeaAaitsXZv4VqV yRyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766570737; x=1767175537; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ggySzSK5iKOIYAfFp9jHFvxyzRSSRMRx7Zg28buJhXU=; b=mHOi9Tw55wAibJtT0uyl2EvORrZS7+k2qNjjZ35CS6qlZVSwnGVtVBwuEfaCMtsD7Z zP9ONonS5nwZ/DaBzsHSTL7k4yn0PR8PunQ/Nphr3BJ6QrVFm3gOih851nj6PgrKSIk3 ChVqvgjRGHUmYHYXBd3PmJw2zb6ME/tdATqPTt9uY6Cg7gAIs26C30SBFN1VLMz6YeJI rvm5+2pSF3IWgRf3cH4A0qJzSeCSC4gNPeyFM4r16YbY1C31Lp3FJ8iMMkZH9u286sdy mHJpygQj+J5uXGdizjphYGbjI0YPqZus462hfP+eiNMnUk6ndARinOifOG+EDvfupkGd h0ug== X-Forwarded-Encrypted: i=1; AJvYcCWvxKAKj3hsVzkujHnVPSMzL/CFjiiM2hn/fGv1aMbWS+Y/+KfAaZVm4Dtt0vvfWKepBORfRuHwImaiTKk=@vger.kernel.org X-Gm-Message-State: AOJu0YyC/rATMlNNAVHEhMyjsLP/1hsqOTVzBfR+sgzsZXq9Uu/wIX9Q B6LyXd62VlHlex+R9RRf1TSdiBBxKna7KEXpCDe3Q+qiv7jZFI4DyuYK X-Gm-Gg: AY/fxX5oZs8wB9pCQ2zODu06IU2r0AwaY/3uLq0CHUmGTAkVkltROqI8TeZYdwnf0Cx t5vG6uN5fMK/0ca3TPjZnoET4bkbYFKfqMRCmBl55SoU3Kh51cFgMZPwT61N2LGP0hVs8w169zf KAvjSWcoc2txzYyEvx095o9vpbPoDBR8f9JV3mqCK745mh67cLDdvPIPEvNZn0dajsRR6BaUQFV BX+zqvhRMQPm95lIPcqxw1uQUWNzGqCQH0lVR/4gwMnpySbCKKGb7gVAdgYztpQ8mpyZAYh8eQG k90N2LgZIp8zxC5JzIEaE8wc0f6CzRP2xsL5LFmmFvHa3Orn4ohujKDgowHltRpk/mrlHOuQVgP b4iTzKVDEktdFCu3FVySh3M6V0KcNQTmIuaWpZCef/1wFfnujzhqvFW0N4g3qQ1jrKCTujuY4/h vzfD4CVksWPJ+pbOo44Vp6wm2nEwW/17NKUff1MH27vPL+2b+9RwleeAONMKBQkg== X-Google-Smtp-Source: AGHT+IG5A7MgeSNs6EXtL/BhNu3tiByZhWc3rS3e0jv396fxloE3TxxnIVdR90mG625aGYB2El5wpg== X-Received: by 2002:a05:6402:1467:b0:64b:5851:5e7b with SMTP id 4fb4d7f45d1cf-64b8d34f12dmr18291199a12.14.1766570736665; Wed, 24 Dec 2025 02:05:36 -0800 (PST) Received: from localhost (19.120-65-87.adsl-dyn.isp.belgacom.be. [87.65.120.19]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b90f53be0sm16237966a12.2.2025.12.24.02.05.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 02:05:36 -0800 (PST) From: William Hansen-Baird To: Greg Kroah-Hartman Cc: Michael Straube , Hans de Goede , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, William Hansen-Baird Subject: [PATCH 3/3] staging: rtl8723bs: core: move constants to right side in comparison Date: Wed, 24 Dec 2025 05:02:56 -0500 Message-ID: <20251224100329.762141-3-william.hansen.baird@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224100329.762141-1-william.hansen.baird@gmail.com> References: <20251224100329.762141-1-william.hansen.baird@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move constants to right side in if-statement conditions. Signed-off-by: William Hansen-Baird --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++-- drivers/staging/rtl8723bs/core/rtw_security.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c index 8fdeeda88a6d..92b12a13d27c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -1009,7 +1009,7 @@ static int rtw_get_cipher_info(struct wlan_network *pnetwork) pbuf = rtw_get_wpa_ie(&pnetwork->network.ies[12], &wpa_ielen, pnetwork->network.ie_length-12); if (pbuf && (wpa_ielen > 0)) { - if (_SUCCESS == rtw_parse_wpa_ie(pbuf, wpa_ielen+2, &group_cipher, &pairwise_cipher, &is8021x)) { + if (rtw_parse_wpa_ie(pbuf, wpa_ielen+2, &group_cipher, &pairwise_cipher, &is8021x) == _SUCCESS) { pnetwork->bcn_info.pairwise_cipher = pairwise_cipher; pnetwork->bcn_info.group_cipher = group_cipher; pnetwork->bcn_info.is_8021x = is8021x; @@ -1019,7 +1019,7 @@ static int rtw_get_cipher_info(struct wlan_network *pnetwork) pbuf = rtw_get_wpa2_ie(&pnetwork->network.ies[12], &wpa_ielen, pnetwork->network.ie_length-12); if (pbuf && (wpa_ielen > 0)) { - if (_SUCCESS == rtw_parse_wpa2_ie(pbuf, wpa_ielen+2, &group_cipher, &pairwise_cipher, &is8021x)) { + if (rtw_parse_wpa2_ie(pbuf, wpa_ielen+2, &group_cipher, &pairwise_cipher, &is8021x) == _SUCCESS) { pnetwork->bcn_info.pairwise_cipher = pairwise_cipher; pnetwork->bcn_info.group_cipher = group_cipher; pnetwork->bcn_info.is_8021x = is8021x; diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c index 2f941ffbd465..86e54454145a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -1488,7 +1488,7 @@ void rtw_sec_restore_wep_key(struct adapter *adapter) struct security_priv *securitypriv = &(adapter->securitypriv); signed int keyid; - if ((_WEP40_ == securitypriv->dot11PrivacyAlgrthm) || (_WEP104_ == securitypriv->dot11PrivacyAlgrthm)) { + if ((securitypriv->dot11PrivacyAlgrthm == _WEP40_) || (securitypriv->dot11PrivacyAlgrthm == _WEP104_)) { for (keyid = 0; keyid < 4; keyid++) { if (securitypriv->key_mask & BIT(keyid)) { if (keyid == securitypriv->dot11PrivacyKeyIndex) -- 2.52.0