From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 914A08634F for ; Thu, 25 Dec 2025 05:45:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766641522; cv=none; b=lk9hC7u1Wd318foE553priy2jmIkPGGi7qiSzJwy6evB/9viVqC7R1uZk8xdZXg7ed3+fA6S4+5SPKNpUYcgvo3w1s+4Am9+sENonWs/0MbLRX5bZS1LM9iOkSLfwBqwvBvqK37cgiFWGZt01VhI6kyeAkaeY4/qxlAK7xwex6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766641522; c=relaxed/simple; bh=kBUpURs3pGOQdFiZ9Dk0mRzCg9JjMr0p4w906V1sjKM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pZL7fm6GEXJKOo1ZLcryLtotTJQebOh6cYN/5aOAgJM8wEaUHCil7oMEGPnBPS9yUx4MlzGvmLYtPpwEAGkCBnu4TCrNzHhhKYPwkC3TwQjgnKnFOuY0UhaSOS6UmJECsdDqK4WX/uHw+4h2qw9WXV0ceaOHtJU+D3/dqSgvsx4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NnwCuSuD; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NnwCuSuD" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-7f0da2dfeaeso6643877b3a.1 for ; Wed, 24 Dec 2025 21:45:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766641520; x=1767246320; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=awLWGoGgdpXkNXwkBZeX3hqOx9uYLiEWuERrTaaxVGg=; b=NnwCuSuDP1vsAmxbLVEka8TIkE4VqspUrKxb/sJms0CJi88VHNJkl72IqSDCRoHnUz 8m7b5yvVVyAcPj/BQE7GaRhheM6mfv8CqMX087cgVz1kLS8YzlAMpZfy7P36oatW0vJD xVwxl8Qw62v97d2pIVETaU7F1TNCUVCIqmn/puYVAXU2/V2ebbXXrke6fBXei+bgqwd8 MtaS4mb9Yr01r7w1Xd9CDu6hbn60YF6gYnW1f/3XxgSDFvHJE7JEjx+drXimC4aIrrA+ VZfp9/DjfsoWw4hyxKzYLqPIS9ExNdjiuxLVJf0k6ykYOE3+Wu6zizVfzoRB5w3zRdrc pTqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766641520; x=1767246320; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=awLWGoGgdpXkNXwkBZeX3hqOx9uYLiEWuERrTaaxVGg=; b=pBcvwx2ssFMjC/cG5TdVs8g+LmUZmTiQ1Jmj0H3ubPYNck5fZ5wru933DwWJYdfySy jmC8ZHOhwtWdKQdB/8oRmy/OsE4LmrRimYZwtXon2PPKYPoZM4xJmQBjz79APCtKhJEp UsxyVjPOF9trGRBJjc5nc4pkM1AEtGBU9O2osq8EoDDswvZMAfYkw4hKMN8ePRvnjJN6 Ww1TEccaVxvpYE5xVmKapm+uQJF+zA12AnKJOTInGvJxBl6FYJXwAWboGrSGER03YUv1 cZJpJZ1sLvu4STQO8q3Js9jMSE5w/S6HSyab0SR4lAUfAkPWwxA0Bzx683NIC9tLAEfW IwCQ== X-Forwarded-Encrypted: i=1; AJvYcCWRX7c6rUbT6R0dVeHzovwF116+OZyWtgDslC2GblVOHQNzVJ+he9vgJ8u9oNG9hW30+VTfqBLP2UfcAjg=@vger.kernel.org X-Gm-Message-State: AOJu0Yyy7uLSF1O9TIqoPrssOqVzqwb7iXJDzsMiL7R2lO7V0W1b6cv5 VQVOk5/7oKQnXf83m4gVOaky3PkLdrYmIPkhe8tMYb21PERHH3oh5CXn X-Gm-Gg: AY/fxX4El9e/Sr83Y1yN5v+6x6lz7Eag+tJSbsTX686WRf++tUHLAEwMNcpCLCeXMl4 /V1bKROU9B2b5N8mRHH5cSTIIo6REs9X4kT/mk5EOyCBIwopAks2x7Xs68Q3VGmCzZXfjxbMA8/ hXpRtvE4KG/ygEnLl2dp8ONod3RI70xojvz6Q2opfHjPr9ftF+kaU2ifEfYEUuNLOog1afU6bqU HmeYCy8xiA09SORQw12vSIY4FbRM0RWh10a1IDPA3C2F+ZZg80bM3bPb5H12aYgNjlbt/RkfpW0 IjYMePq2PRgNtsmyMdutgmB677k9XIIUMxLMvJjp2dffCbgJ6WECdv7sgusd4BJI8KWgd0HFILZ LEpAhs/JWkxycuTxztHhYysKb1w+BYVbMAWk5nonMQAh4qfz6q6+no4qS5jQ5sJI2c4mAOgxPCT RKUbF0Xc/6Sdtn X-Google-Smtp-Source: AGHT+IFjiH0lz0LAVTw+YGN3qXPK1250UhDPFxtbuSuejwFf6Kj2hl7RPgmOjGUptvke7p9I5vERZg== X-Received: by 2002:a05:6a00:35cf:b0:7fd:f3e9:5a03 with SMTP id d2e1a72fcca58-7ff66f591a2mr17677975b3a.40.1766641519773; Wed, 24 Dec 2025 21:45:19 -0800 (PST) Received: from barry-desktop.hub ([47.72.129.29]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48f300sm18385848b3a.54.2025.12.24.21.45.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 21:45:19 -0800 (PST) From: Barry Song <21cnbao@gmail.com> To: leon@kernel.org Cc: 21cnbao@gmail.com, ada.coupriediaz@arm.com, anshuman.khandual@arm.com, ardb@kernel.org, catalin.marinas@arm.com, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, maz@kernel.org, robin.murphy@arm.com, ryan.roberts@arm.com, surenb@google.com, v-songbaohua@oppo.com, will@kernel.org, zhengtangquan@oppo.com Subject: Re: [PATCH 5/6] dma-mapping: Allow batched DMA sync operations if supported by the arch Date: Thu, 25 Dec 2025 18:45:09 +1300 Message-ID: <20251225054509.39917-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251224085145.GF11869@unreal> References: <20251224085145.GF11869@unreal> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > > > > > > > OK. Could you take a look at [1] and see if any further > > improvements are needed before I send v2? > > Everything looks ok, except these renames: > - arch_sync_dma_for_cpu(paddr, sg->length, dir); > + arch_sync_dma_for_cpu_batch_add(paddr, sg->length, dir); Thanks! I'm happy to drop the rename as outlined below-feedback welcome :-) diff --git a/arch/arm64/include/asm/cache.h b/arch/arm64/include/asm/cache.h index dd2c8586a725..487fb7c355ed 100644 --- a/arch/arm64/include/asm/cache.h +++ b/arch/arm64/include/asm/cache.h @@ -87,6 +87,12 @@ int cache_line_size(void); #define dma_get_cache_alignment cache_line_size +static inline void arch_sync_dma_flush(void) +{ + dsb(sy); +} +#define arch_sync_dma_flush arch_sync_dma_flush + /* Compress a u64 MPIDR value into 32 bits. */ static inline u64 arch_compact_of_hwid(u64 id) { diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c index b2b5792b2caa..ae1ae0280eef 100644 --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -17,7 +17,7 @@ void arch_sync_dma_for_device(phys_addr_t paddr, size_t size, { unsigned long start = (unsigned long)phys_to_virt(paddr); - dcache_clean_poc(start, start + size); + dcache_clean_poc_nosync(start, start + size); } void arch_sync_dma_for_cpu(phys_addr_t paddr, size_t size, @@ -28,7 +28,7 @@ void arch_sync_dma_for_cpu(phys_addr_t paddr, size_t size, if (dir == DMA_TO_DEVICE) return; - dcache_inval_poc(start, start + size); + dcache_inval_poc_nosync(start, start + size); } void arch_dma_prep_coherent(struct page *page, size_t size) diff --git a/include/linux/dma-map-ops.h b/include/linux/dma-map-ops.h index 4809204c674c..e7dd8a63b40e 100644 --- a/include/linux/dma-map-ops.h +++ b/include/linux/dma-map-ops.h @@ -361,6 +361,12 @@ static inline void arch_sync_dma_for_cpu(phys_addr_t paddr, size_t size, } #endif /* ARCH_HAS_SYNC_DMA_FOR_CPU */ +#ifndef arch_sync_dma_flush +static inline void arch_sync_dma_flush(void) +{ +} +#endif + #ifdef CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU_ALL void arch_sync_dma_for_cpu_all(void); #else