From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 210EF2B2DA for ; Fri, 26 Dec 2025 23:53:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766793236; cv=none; b=swf4higp1bwilHrwJGtRQN8AiyY5EVfkVQ6OhbaKh0vNmjqkUuoUKgL4DWOJkt2H4r1GJAokp9+sKC6og2clIjAdeCXO3kdSVKN1nEOj1hn0EWghTBd6vhJ3Z6797gdTeyurHjmcuuEcJCsxnp/i+z23+p0Ipp5outEmaISRVRM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766793236; c=relaxed/simple; bh=Xn89Z7LlNJRh+TRBmYqTnWl1iqTuZgasa4aVYS0pnY4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TDMk2r2l5lJGitCQJCd4F1YLgT4VsqeqkbLdsf1hTtacUltjJTb0YVWiRnPHjz6tJUt+qVgl8TuuDa6j4EWEcIPyQX+5NMVJxh6s9jgqQ1d6zT3isYOsdt+HKx6uUR2U2X0uOs89HzXayBYB0bK1RlO8t6ZS/khnJyk91HShxTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GKXlynqT; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GKXlynqT" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7aae5f2633dso7596574b3a.3 for ; Fri, 26 Dec 2025 15:53:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766793234; x=1767398034; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=f0vyeocCV33HEg26/iuFmDPXpUFL78V+AfewKJRB7/s=; b=GKXlynqT5B+YeAXWwxYel6zmA7CxjIy6K2w8fxPwhLlrU8/fT9G8CsrsgiSQJmRvkQ N00CiWKzTMIPGt0XEDMpKK4A5zuqcCwPKiaRm0tdV5/nXdWLPMRW1dzPekVYH0ABlGao gh7H5EYEjWUMMjKpps3pcIylZO0l73Qs2bKVV5eDoP9dDNHp1kRwbeiC/3csOkV3Zh9Q Lq12RWMFR7G7Aiztd0qDa67du4psGEkCRm2qBmJDiHYPjbSEo4mjFc1+3IST4uAs53hM LsBUd8M6ZjM5BmLUq/DtldeVPGDqyaZInGfvQePb2YGxLc0wyegNe4mP5ZJ0vNfhBwYh Murw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766793234; x=1767398034; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f0vyeocCV33HEg26/iuFmDPXpUFL78V+AfewKJRB7/s=; b=J803iyah3CfINAhAn9bu2MflQBXYoHh19wdssIzpqLbK8e+bOdGbPm41ppawYkLeSb oVk/vAPG6z61dh6Y0aVGm1/qCec/h5+uSssDyt6V84+fyDiSDfRHuuUu6QiMTkrAkT3S u/M/ke9oDiqr6LLi45NxJ+Gjj6dkm9O+xmfz2dGbU9ecU/FmHHEKhbuhzw+3BUARSAn9 K+H1e1g+nUrgrBDly+RwV85ww24EsjOWiblRjeS490LlsNbaSBkXh6RAwcNEKdoku1eV +T3mAMHpPajdQEqSy1I1nJN2aOCb8k7RItlB1KNwPFCAT1lch1fZ29TKwOf6KXBAQrBh n2vA== X-Forwarded-Encrypted: i=1; AJvYcCUy4EINNU+MCYddn1IPPMFH/FhP8hrvzFkXZOJ6LN90RL4cJeiXHlHk0eCw6x6Bl6/5ebOqaVbzJIwSg44=@vger.kernel.org X-Gm-Message-State: AOJu0YxdNw40KFyUTM1M5y1/fmQRtAuPNzVozdR1S+bflnFbnskxHnFS fFTXn5WQ3j5VuuV4XchK0d2AYn+chXaWWvS6PRQ6NxvOtzHTPuxDZF44 X-Gm-Gg: AY/fxX7DK53auk7Kz2gc518qmapD3UgxFd2VV16vrKMuOXxotZS8r26QDknX/6BDXzO aoXaAoIeCTGJ7rPaizDqnJItz1bUhf4B4yUqkIHuuaJnZwhBu5wNYY4EYlomsOwDVY4AuwKEmEO ACEGomV/VgpuGIsXgbf2a6LuYAgEPTkRNs+bWVGFIWG7aySe0bvIlMRI4LSTSja5PZwKQm7w8LL Ywxqb3k4CjFblKJSqT3kZW1oZn4f/4ghT0RigDoDzg/MwYxK7a/9hG/9KyPIXpwZ3MvwNI1nCw9 SOz3xSE9oASIRr/ghiTTFS8u4sClF2t9VMDZzTur1TygF2PXo8OLvMz0fI9m6LttHcEMdmN3M2R rAZZ7ieRyfrnMdmC7nfHdQhID08V7Edulqg6mysZyncwmPyp2e37nWCpSbkqUwGPsyGrurVMfYm DGjcEZHFnuKBS8klOxkW0WXg0Q66sSDtCO4/ovMpKg5WSQmbkg0FKUmtIFnwSDtnGMCA== X-Google-Smtp-Source: AGHT+IEtpUCwGLlNLxKyNXIMX8+tzq7l0KJnLDuBLqpsPtLogCjtkzSZeYADQRlUzu4Ad7mZhlnfvA== X-Received: by 2002:a05:6a00:4512:b0:7e8:450c:61c8 with SMTP id d2e1a72fcca58-7ff6667c5a7mr22939512b3a.56.1766793234329; Fri, 26 Dec 2025 15:53:54 -0800 (PST) Received: from c12-ThinkPad-X1-Carbon-Gen-12 (softbank221049092147.bbtec.net. [221.49.92.147]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48cea1sm23395216b3a.45.2025.12.26.15.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Dec 2025 15:53:53 -0800 (PST) From: Vishnu Sankar To: dmitry.torokhov@gmail.com, hmh@hmh.eng.br, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, corbet@lwn.net, derekjohn.clark@gmail.com Cc: mpearson-lenovo@squebb.ca, linux-doc@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, vsankar@lenovo.com, Vishnu Sankar Subject: [PATCH v5 0/3] TrackPoint doubletap enablement and user control Date: Sat, 27 Dec 2025 08:50:58 +0900 Message-ID: <20251226235101.106451-1-vishnuocv@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series adds support for TrackPoint doubletap with a clear and simple separation of responsibilities between drivers: 1. Firmware enablement (trackpoint.c): Automatically enables doubletap on capable hardware during device detection. 2. User control (thinkpad_acpi.c): Provides a sysfs interface to enable or disable delivery of doubletap events to userspace. The approach follows the KISS principle: - The TrackPoint driver enables hardware functionality by default. - The thinkpad_acpi driver controls whether ACPI doubletap events are delivered, using existing hotkey filtering infrastructure. - No cross-driver APIs or dual filtering paths are introduced. Changes in v5: - Rename sysfs attribute from doubletap_filter to doubletap_enable to reflect actual behavior. - Fix inverted logic so events are delivered only when doubletap is enabled. - Suppress ACPI hotkey delivery instead of injecting or filtering input events. - Register the sysfs attribute via hotkey_attributes[] instead of device_create_file(). - Drop unnecessary helper wrappers and debug logging. - Update Documentation to reflect the new naming and semantics. Changes in v4: - Complete redesign based on reviewer feedback. - trackpoint.c: Simplified to only enable doubletap by default. - trackpoint.c: Removed all sysfs attributes and global variables. - trackpoint.c: Uses firmware ID detection with deny list. - thinkpad_acpi.c: Added sysfs interface for kernel-level event control. - thinkpad_acpi.c: No cross-driver dependencies. - Documentation: Updated to reflect simplified sysfs approach. Changes in v3: - No changes. Changes in v2: - Improved commit messages. - Removed unnecessary comments and debug messages. - Switched to strstarts() usage. - Simplified firmware capability detection logic. This version addresses the remaining review feedback by correcting the naming and logic inversion, aligning sysfs semantics with behavior, and fully integrating with existing thinkpad_acpi hotkey handling. Vishnu Sankar (3): input: trackpoint - Enable doubletap by default on capable devices platform/x86: thinkpad_acpi: Add sysfs control for TrackPoint double-tap Documentation: thinkpad-acpi - Document doubletap_enable attribute .../admin-guide/laptops/thinkpad-acpi.rst | 20 ++++++++ drivers/input/mouse/trackpoint.c | 47 +++++++++++++++++++ drivers/input/mouse/trackpoint.h | 5 ++ drivers/platform/x86/lenovo/thinkpad_acpi.c | 42 ++++++++++++++--- 4 files changed, 107 insertions(+), 7 deletions(-) -- 2.51.0