From: Karthikey D Kadati <karthikey3608@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Karthikey D Kadati <karthikey3608@gmail.com>
Subject: [PATCH] staging: rtl8723bs: fix missing transmission lock in rtw_xmit
Date: Sat, 27 Dec 2025 17:03:48 +0530 [thread overview]
Message-ID: <20251227113348.26272-1-karthikey3608@gmail.com> (raw)
The packet transmission path in rtw_xmit.c contained TODO comments
indicating a missing lock. This patch implements spin_lock_bh and
spin_unlock_bh around the station attribute update section.
This prevents a potential race condition where station security and
PHY information could be modified on another CPU core during
transmission. The use of _bh variants ensures safety in bottom-half
contexts common in network transmit paths.
Verified that psta is NULL-checked prior to acquisition and that no
double-unlocks occur on the exit path.
Signed-off-by: Karthikey D Kadati <karthikey3608@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 21690857f..5f11afb63 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -715,8 +715,9 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p
if (!(psta->state & _FW_LINKED))
return _FAIL;
- /* TODO:_lock */
+ spin_lock_bh(&psta->lock);
if (update_attrib_sec_info(padapter, pattrib, psta) == _FAIL) {
+ spin_unlock_bh(&psta->lock);
res = _FAIL;
goto exit;
}
@@ -724,7 +725,7 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p
update_attrib_phy_info(padapter, pattrib, psta);
pattrib->psta = psta;
- /* TODO:_unlock */
+ spin_unlock_bh(&psta->lock);
pattrib->pctrl = 0;
--
2.43.0
reply other threads:[~2025-12-27 11:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251227113348.26272-1-karthikey3608@gmail.com \
--to=karthikey3608@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®