From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D543B32BF4B for ; Mon, 29 Dec 2025 15:40:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767022821; cv=none; b=AcBhM7PtQJeQb6cYIggxpi7KBAZPCdXNKjDioXUBVscZw+nXR4n/JrhfYhz0XQarcuGPQ4RM4L1Ogdw2HMkKpGU8pFDVGMU7qtxhoh97r5r1074538KrTQ8qJ29SGs1jaL4uwEmNuYy0QteLbHsJjK5sAr48g/Py3WiOYuZTdUU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767022821; c=relaxed/simple; bh=n+Fq+ObkEr/etJHF641cORxlzQqWUAHZMsfIZZuH+ZY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pYGlPYugYdFsyUo7rycjEMesRnWmfobm83DYyN1M3IQyc0Z6y30rEgtqqxWM6eflu4IXp/0rDgnIYbrIKrP/qNVOHnKzkzgvxMUc+AnZx3zz1JV3kE5+y8hENF+ib0sE51DxRvoigmsnavbK1DmxkW65xkqm7sfodb/dpf/PiPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D62D252501; Mon, 29 Dec 2025 15:40:06 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf18.hostedemail.com (Postfix) with ESMTPA id 4AB8F32; Mon, 29 Dec 2025 15:40:01 +0000 (UTC) Date: Mon, 29 Dec 2025 10:40:05 -0500 From: Steven Rostedt To: Julia Lawall Cc: "Paul E. McKenney" , "Dr. David Alan Gilbert" , Theodore Tso , Sasha Levin , Gabriele Paoloni , Kate Stewart , Chuck Wolber , Dmitry Vyukov , Mark Rutland , Thomas Gleixner , Lorenzo Stoakes , Shuah Khan , Chris Mason , linux-kernel@vger.kernel.org Subject: Re: Follow-up on Linux-kernel code accessibility Message-ID: <20251229104005.18b25def@gandalf.local.home> In-Reply-To: <435c7085-34e-16e9-5711-e53aa54cf4fc@inria.fr> References: <20251224091158.6ab443cb@gandalf.local.home> <20251225150331.GB15088@macsyma.lan> <20251226114830.6bc7a3eb@gandalf.local.home> <20251226192217.GB67711@macsyma.local> <6915da9a-6cd7-c2a9-776d-963949a413c@inria.fr> <8005c35a-d8dc-4908-93e5-46bd206f0139@paulmck-laptop> <435c7085-34e-16e9-5711-e53aa54cf4fc@inria.fr> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout06 X-Rspamd-Queue-Id: 4AB8F32 X-Stat-Signature: 7zqej91ax7f4ic83qop6nmtriawa1xnu X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/G+ulHHMQkowmAY13vBeN1vlVROJAewd4= X-HE-Tag: 1767022801-919317 X-HE-Meta: U2FsdGVkX1/YY/FuZlReO06OfR11ie9qaDru9s7mUFt7J727n8D+MCGBTXYKbCVgNtTkJmeAZbnSAiJgvhy4upAzU4XfjIIyaNYj6ecFDDJHqpBfWhvGIpj5Q8aR+InZFrmH0BPcN66gytUzTGEUb5x+OYc5ek/f8siiPNYbvTKMSsUlyIB2TbZvhvqujPkCCAiI2PCS90rcDJmqS+bH/3qTp7IP96J6PyaI2ESpqAnCyuOukt/P1hJjUfduLZeKDYy00bJ/Pvg6GVLq2WiHA49uWDyu+0XSlcSCSKnnPcruWVw8OaCK9Es68UWAWTgP On Sun, 28 Dec 2025 10:36:39 +0100 (CET) Julia Lawall wrote: > > > > > j = (j + 2) / 3; > > > > > > > > "Divide by three rounding up." That's as useful as: /* Add one to X */ x++; > > > > > > That's not *that* obvious, but ok, but then why 3? > > > Bingo! You win a cigar! :-) I know that was a round up (and yes, as David pointed out, we have macros for that too). The question is why are you dividing it by 3? I don't see anything in that function which suggests the reason for needing to divide j by 3. If the comments you were adding in the past was things like "Divide by three rounding up" then yeah, I can see why people would say you have too many comments. The comments are not to be discussing what is being done, but why is it being done. WRITE_ONCE(rcu_state.jiffies_kick_kthreads, jiffies + (j ? 3 * j : 2)); Why the: (j ? 3 * j : 2) ? Why is 3 so magical? /* * j is the Father, Son and Holy Ghost. * But only one may be active at a time. * They each take a third. Father is first, * Son is second, and Holy Ghost is third. */ j = (j + 2) / 3; /* * j may not be zero, as that would lead to * damnation. */ if (j <= 0) j = 1; -- Steve